fix(alert): various alert fixes

- make the type optional (in this case only a default alert class is applied)
- remove the 'alert-block' from a template - it can still be added on the alert element if needed
- add replace:true
- uncomment a test

Author: pkozlowski-opensource

src/alert/alert.js

@@ -3,16 +3,15 @@ angular.module("ui.bootstrap.alert", []).directive('alert', function () {
     restrict:'EA',
     templateUrl:'template/alert/alert.html',
     transclude:true,
+    replace:true,
     scope:{
       type:'=',
       close:'&'
     },
     link:function (scope, element, attrs) {
-      scope.type = scope.type || 'info';
       scope.dismiss = function () {
         scope.close();
       };
     }
   };
-});
-
+});

src/alert/test/alert.spec.js

@@ -37,11 +37,21 @@ describe("alert", function () {
     expect(alerts.length).toEqual(3);
   });
 
-  it("should use correct alert type", function () {
+  it("should use correct classes for different alert types", function () {
     var alerts = createAlerts();
     expect(alerts.eq(0)).toHaveClass('alert-success');
     expect(alerts.eq(1)).toHaveClass('alert-error');
-    expect(alerts.eq(2)).toHaveClass('alert-info');
+
+    //defaults
+    expect(alerts.eq(2)).toHaveClass('alert');
+    expect(alerts.eq(2)).not.toHaveClass('alert-info');
+    expect(alerts.eq(2)).not.toHaveClass('alert-block');
+  });
+
+  it('it should be possible to add additional classes for alert', function () {
+    var element = $compile('<alert class="alert-block">Default alert!</alert>')(scope);
+    scope.$digest();
+    expect(element).toHaveClass('alert-block');
   });
 
   it("should fire callback when closed", function () {

template/alert/alert.html

@@ -1,4 +1,4 @@
-<div class='alert alert-block' ng-class="'alert-' + type">
-  <button type='button' class='close' ng-click='dismiss()'>&times;</button>
-  <div ng-transclude></div>
+<div class='alert' ng-class="(type) && 'alert-'+type || undefined">
+    <button type='button' class='close' ng-click='dismiss()'>&times;</button>
+    <div ng-transclude></div>
 </div>