Skip to content

Commit ef25fc5

Browse files
committed
fix: compound can also be DOM (todo: need a way to exclude compoundPrefix)
1 parent aa905ff commit ef25fc5

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

libs/angular-three/src/lib/renderer/renderer.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -236,8 +236,12 @@ export class NgtRenderer implements Renderer2 {
236236
// if child is three but haven't been attached to a parent yet
237237
(newChild.__ngt_renderer__[NgtRendererClassId.type] === 'three' && !getLocalState(newChild).parent) ||
238238
// or both parent and child are DOM elements
239-
(parent.__ngt_renderer__[NgtRendererClassId.type] === 'dom' &&
240-
newChild.__ngt_renderer__[NgtRendererClassId.type] === 'dom');
239+
((parent.__ngt_renderer__[NgtRendererClassId.type] === 'dom' ||
240+
(parent.__ngt_renderer__[NgtRendererClassId.type] === 'compound' &&
241+
!parent.__ngt_renderer__[NgtRendererClassId.compounded])) &&
242+
(newChild.__ngt_renderer__[NgtRendererClassId.type] === 'dom' ||
243+
(newChild.__ngt_renderer__[NgtRendererClassId.type] === 'compound' &&
244+
!newChild.__ngt_renderer__[NgtRendererClassId.compounded])));
241245

242246
if (shouldFindGrandparentInstance) {
243247
// we'll try to get the grandparent instance here so that we can run appendChild with both instances

0 commit comments

Comments
 (0)