Skip to content

Commit d1da0cd

Browse files
committed
fix: ensure parent and newChild isn't the same before calling append
1 parent 47f7b5f commit d1da0cd

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

libs/angular-three/src/lib/renderer/provider.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { ChangeDetectorRef, RendererFactory2 } from '@angular/core';
1+
import { ChangeDetectorRef, makeEnvironmentProviders, RendererFactory2 } from '@angular/core';
22
import { NgtStore } from '../stores/store';
33
import { NGT_COMPOUND_PREFIXES } from './di';
44
import { NgtRendererFactory } from './renderer';
@@ -18,10 +18,10 @@ export function provideNgtRenderer({ store, changeDetectorRef, compoundPrefixes
1818
compoundPrefixes.push('ngtp');
1919
}
2020

21-
return [
21+
return makeEnvironmentProviders([
2222
{ provide: RendererFactory2, useClass: NgtRendererFactory },
2323
{ provide: NgtStore, useValue: store },
2424
{ provide: ChangeDetectorRef, useValue: changeDetectorRef },
2525
{ provide: NGT_COMPOUND_PREFIXES, useValue: compoundPrefixes },
26-
];
26+
]);
2727
}

libs/angular-three/src/lib/renderer/renderer.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ export class NgtRenderer implements Renderer2 {
233233
// refChild: NgtRendererNode
234234
// isMove?: boolean | undefined
235235
): void {
236-
if (!parent.__ngt_renderer__) return;
236+
if (!parent.__ngt_renderer__ || parent === newChild) return;
237237
this.appendChild(parent, newChild);
238238
}
239239

0 commit comments

Comments
 (0)