Skip to content

Commit c92c021

Browse files
committed
refactor(soba): use raycast=null instead of nullRaycast
1 parent 1d00903 commit c92c021

File tree

4 files changed

+4
-8
lines changed

4 files changed

+4
-8
lines changed

libs/soba/misc/src/index.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,3 +10,4 @@ export * from './lib/html/html';
1010
export * from './lib/html/html-content';
1111
export * from './lib/intersect';
1212
export * from './lib/sampler';
13+
export * from './lib/scale-factor';

libs/soba/performances/src/lib/instances/instances.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ const defaultOptions: NgtsInstancesOptions = {
8282
#instancedMesh
8383
[userData]="{ instances }"
8484
[matrixAutoUpdate]="false"
85-
[raycast]="nullRaycast"
85+
[raycast]="null"
8686
[parameters]="parameters()"
8787
>
8888
<ngt-instanced-buffer-attribute
@@ -108,7 +108,6 @@ const defaultOptions: NgtsInstancesOptions = {
108108
})
109109
export class NgtsInstances {
110110
protected readonly DynamicDrawUsage = DynamicDrawUsage;
111-
protected readonly nullRaycast = () => null;
112111

113112
options = input(defaultOptions, { transform: mergeInputs(defaultOptions) });
114113
parameters = omit(this.options, ['limit', 'frames', 'range']);

libs/soba/performances/src/lib/points/points.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ const defaultInstancesOptions: NgtsPointsInstancesOptions = { limit: 1000 };
128128
#points
129129
[userData]="{ instances: positionPoints }"
130130
[matrixAutoUpdate]="false"
131-
[raycast]="nullRaycast"
131+
[raycast]="null"
132132
[parameters]="parameters()"
133133
>
134134
<ngt-buffer-geometry>
@@ -161,8 +161,6 @@ const defaultInstancesOptions: NgtsPointsInstancesOptions = { limit: 1000 };
161161
changeDetection: ChangeDetectionStrategy.OnPush,
162162
})
163163
export class NgtsPointsInstances {
164-
protected readonly nullRaycast = () => null;
165-
166164
options = input(defaultInstancesOptions, { transform: mergeInputs(defaultInstancesOptions) });
167165
parameters = omit(this.options, ['limit', 'range']);
168166

libs/soba/staging/src/lib/spot-light.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ const defaultVolumetricMeshOptions: NgtsVolumetricMeshOptions = {
6767
selector: 'ngts-volumetric-mesh',
6868
standalone: true,
6969
template: `
70-
<ngt-mesh #mesh [geometry]="geometry()" [raycast]="nullRaycast">
70+
<ngt-mesh #mesh [geometry]="geometry()" [raycast]="null">
7171
<ngt-primitive *args="[material]" attach="material">
7272
<ngt-value attach="uniforms.opacity.value" [rawValue]="opacity()" />
7373
<ngt-value attach="uniforms.lightColor.value" [rawValue]="color()" />
@@ -88,8 +88,6 @@ const defaultVolumetricMeshOptions: NgtsVolumetricMeshOptions = {
8888
imports: [NgtArgs],
8989
})
9090
export class NgtsVolumetricMesh {
91-
nullRaycast = () => null;
92-
9391
options = input(defaultVolumetricMeshOptions, { transform: mergeInputs(defaultVolumetricMeshOptions) });
9492

9593
meshRef = viewChild.required<ElementRef<Mesh>>('mesh');

0 commit comments

Comments
 (0)