fix: match with latest react three fiber on applyProps

nartc · nartc · commit b36d3abffa33 · 2023-02-20T20:51:47.000-06:00
diff --git a/libs/angular-three/src/lib/utils/apply-props.ts b/libs/angular-three/src/lib/utils/apply-props.ts
@@ -68,7 +68,12 @@ export function applyProps(instance: NgtInstanceNode, props: NgtAnyRecord): NgtI
         else {
             currentInstance[key] = value;
             // auto-convert srgb textures
-            if (!rootState?.linear && currentInstance[key] instanceof THREE.Texture) {
+            if (
+                !rootState?.linear &&
+                currentInstance[key] instanceof THREE.Texture &&
+                currentInstance[key].format === THREE.RGBAFormat &&
+                currentInstance[key].type === THREE.UnsignedByteType
+            ) {
                 currentInstance[key]['encoding'] = THREE.sRGBEncoding;
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,12 @@ export function applyProps(instance: NgtInstanceNode, props: NgtAnyRecord): NgtI`
`68`	`68`	`else {`
`69`	`69`	`currentInstance[key] = value;`
`70`	`70`	`// auto-convert srgb textures`
`71`		`- if (!rootState?.linear && currentInstance[key] instanceof THREE.Texture) {`
	`71`	`+ if (`
	`72`	`+ !rootState?.linear &&`
	`73`	`+ currentInstance[key] instanceof THREE.Texture &&`
	`74`	`+ currentInstance[key].format === THREE.RGBAFormat &&`
	`75`	`+ currentInstance[key].type === THREE.UnsignedByteType`
	`76`	`+ ) {`
`72`	`77`	`currentInstance[key]['encoding'] = THREE.sRGBEncoding;`
`73`	`78`	`}`
`74`	`79`	`}`