Skip to content

Commit 9728392

Browse files
committed
fix: only attach if there's parent
1 parent b9f91f3 commit 9728392

File tree

1 file changed

+2
-9
lines changed
  • libs/angular-three/src/lib/renderer

1 file changed

+2
-9
lines changed

libs/angular-three/src/lib/renderer/state.ts

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -209,27 +209,20 @@ export class NgtRendererStore {
209209

210210
applyProperty(node: NgtRendererNode, name: string, value: any) {
211211
if (node.__ngt_renderer__[NgtRendererClassId.destroyed]) return;
212-
// setup [ref] here
213-
// ref should never change
214-
// if (name === SPECIAL_PROPERTIES.REF && is.ref(value)) {
215-
// node.__ngt_renderer__[NgtRendererClassId.ref] = value;
216-
// value.nativeElement = node;
217-
// return;
218-
// }
219212

220213
const parent = getLocalState(node).parent || node.__ngt_renderer__[NgtRendererClassId.parent];
221214

222215
// rawValue
223216
if (getLocalState(node).isRaw && name === SPECIAL_PROPERTIES.VALUE) {
224217
node.__ngt_renderer__[NgtRendererClassId.rawValue] = value;
225-
attachThreeChild(parent, node);
218+
if (parent) attachThreeChild(parent, node);
226219
return;
227220
}
228221

229222
// attach
230223
if (name === SPECIAL_PROPERTIES.ATTACH) {
231224
getLocalState(node).attach = Array.isArray(value) ? value.map((v) => v.toString()) : value;
232-
attachThreeChild(parent, node);
225+
if (parent) attachThreeChild(parent, node);
233226
return;
234227
}
235228

0 commit comments

Comments
 (0)