Skip to content

Commit 7acf098

Browse files
committed
fix: check for NgtRendererNode when accessing injectorFactory
1 parent 0d69e50 commit 7acf098

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

libs/angular-three/src/lib/renderer/renderer.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -341,7 +341,10 @@ export class NgtRenderer implements Renderer2 {
341341
}
342342

343343
listen(target: NgtRendererNode, eventName: string, callback: (event: any) => boolean | void): () => void {
344-
const targetCdr = target.__ngt_renderer__[NgtRendererClassId.injectorFactory]?.().get(ChangeDetectorRef, null);
344+
const targetCdr = target.__ngt_renderer__?.[NgtRendererClassId.injectorFactory]?.().get(
345+
ChangeDetectorRef,
346+
undefined
347+
);
345348
// if target is DOM node, then we pass that to delegate Renderer
346349
if (this.store.isDOM(target)) {
347350
const callbackWithCdr = (event: any) => {

libs/angular-three/src/lib/renderer/utils.ts

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ export function processThreeEvent(
144144
eventName: string,
145145
callback: (event: any) => void,
146146
cdr: ChangeDetectorRef,
147-
targetCdr: ChangeDetectorRef | null
147+
targetCdr?: ChangeDetectorRef
148148
): () => void {
149149
const lS = getLocalState(instance);
150150
if (eventName === SPECIAL_EVENTS.BEFORE_RENDER) {
@@ -194,11 +194,7 @@ export function processThreeEvent(
194194
};
195195
}
196196

197-
export function eventToHandler(
198-
callback: (event: any) => void,
199-
cdr: ChangeDetectorRef,
200-
targetCdr: ChangeDetectorRef | null
201-
) {
197+
export function eventToHandler(callback: (event: any) => void, cdr: ChangeDetectorRef, targetCdr?: ChangeDetectorRef) {
202198
return (event: Parameters<Exclude<NgtEventHandlers[(typeof supportedEvents)[number]], undefined>>[0]) => {
203199
callback(event);
204200
if (targetCdr) targetCdr.detectChanges();

0 commit comments

Comments
 (0)