Skip to content

Commit 3f847ef

Browse files
committed
feat(core): bump three 0.156
1 parent 909f661 commit 3f847ef

File tree

5 files changed

+43
-50
lines changed

5 files changed

+43
-50
lines changed

libs/core/src/lib/events.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ export function createEvents(store: NgtSignalStore<NgtState>) {
167167
state.events.compute?.(event, store, null);
168168
}
169169

170-
function handleRaycast(obj: THREE.Object3D<THREE.Event>) {
170+
function handleRaycast(obj: THREE.Object3D) {
171171
const objLocalState = getLocalState(obj);
172172
const objStore = objLocalState.store;
173173
const objState = objStore?.get();
@@ -186,7 +186,7 @@ export function createEvents(store: NgtSignalStore<NgtState>) {
186186
}
187187

188188
// Collect events
189-
let hits: THREE.Intersection<THREE.Object3D<THREE.Event>>[] = eventsObjects
189+
let hits: THREE.Intersection<THREE.Object3D>[] = eventsObjects
190190
// Intersect objects
191191
.flatMap(handleRaycast)
192192
// Sort by event priority and distance

libs/core/src/lib/loader.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ export interface NgtLoader<T> extends THREE.Loader {
1010
url: string,
1111
onLoad?: (result: T) => void,
1212
onProgress?: (event: ProgressEvent) => void,
13-
onError?: (event: ErrorEvent) => void,
13+
onError?: (event: unknown) => void,
1414
): unknown;
1515
loadAsync(url: string, onProgress?: (event: ProgressEvent) => void): Promise<T>;
1616
}

libs/soba/loaders/src/gltf-loader/gltf-loader.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,8 @@ export function injectNgtsGLTFLoader<TUrl extends string | string[] | Record<str
4444
} = {},
4545
): Signal<NgtLoaderResults<TUrl, GLTF & NgtObjectMap> | null> {
4646
return injectNgtLoader(() => GLTFLoader, path, {
47-
extensions: _extensions(useDraco, useMeshOpt, extensions),
47+
// TODO: fix "as any" when three-stdlib is updated with THREE 0.156
48+
extensions: _extensions(useDraco, useMeshOpt, extensions) as any,
4849
injector,
4950
});
5051
}

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@
5353
"@swc/core": "~1.3.83",
5454
"@types/jest": "^29.5.4",
5555
"@types/node": "20.6.0",
56-
"@types/three": "^0.155.1",
56+
"@types/three": "^0.156.0",
5757
"@typescript-eslint/eslint-plugin": "6.6.0",
5858
"@typescript-eslint/parser": "6.6.0",
5959
"autoprefixer": "^10.4.15",
@@ -80,7 +80,7 @@
8080
"raw-loader": "^4.0.2",
8181
"release-it": "^16.1.5",
8282
"tailwindcss": "^3.3.3",
83-
"three": "^0.155.0",
83+
"three": "^0.156.1",
8484
"ts-jest": "^29.1.1",
8585
"ts-node": "10.9.1",
8686
"typescript": "~5.1.0",

pnpm-lock.yaml

Lines changed: 36 additions & 44 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)