fix(core): comment out update matrix automatically

nartc · nartc · commit 2f813fa71a17 · 2024-08-11T01:38:54.000-05:00
diff --git a/libs/core/src/lib/utils/update.ts b/libs/core/src/lib/utils/update.ts
@@ -10,7 +10,8 @@ export function checkNeedsUpdate(value: unknown) {
 }
 
 export function checkUpdate(value: unknown) {
-	if (is.object3D(value)) value.updateMatrix();
+	// TODO (chau): this is messing with PivotControls. Re-evaluate later
+	// if (is.object3D(value)) value.updateMatrix();
 
 	if (is.camera(value)) {
 		if (is.perspectiveCamera(value) || is.orthographicCamera(value)) value.updateProjectionMatrix();

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,8 @@ export function checkNeedsUpdate(value: unknown) {`
`10`	`10`	`}`
`11`	`11`
`12`	`12`	`export function checkUpdate(value: unknown) {`
`13`		`- if (is.object3D(value)) value.updateMatrix();`
	`13`	`+ // TODO (chau): this is messing with PivotControls. Re-evaluate later`
	`14`	`+ // if (is.object3D(value)) value.updateMatrix();`
`14`	`15`
`15`	`16`	`if (is.camera(value)) {`
`16`	`17`	`if (is.perspectiveCamera(value) \|\| is.orthographicCamera(value)) value.updateProjectionMatrix();`