fix: ts strict type issues pt.1

Author: James Salas

package.json

@@ -37,16 +37,16 @@
     "node": ">=8"
   },
   "devDependencies": {
-    "@angular/animations": "7.2.0",
-    "@angular/cli": "7.2.1",
-    "@angular/common": "7.2.0",
-    "@angular/compiler": "7.2.0",
-    "@angular/compiler-cli": "7.2.0",
-    "@angular/core": "7.2.0",
-    "@angular/forms": "7.2.0",
-    "@angular/platform-browser": "7.2.0",
-    "@angular/platform-browser-dynamic": "7.2.0",
-    "@angular/router": "7.2.0",
+    "@angular/animations": "7.2.1",
+    "@angular/cli": "7.2.2",
+    "@angular/common": "7.2.1",
+    "@angular/compiler": "7.2.1",
+    "@angular/compiler-cli": "7.2.1",
+    "@angular/core": "7.2.1",
+    "@angular/forms": "7.2.1",
+    "@angular/platform-browser": "7.2.1",
+    "@angular/platform-browser-dynamic": "7.2.1",
+    "@angular/router": "7.2.1",
     "@commitlint/cli": "7.0.0",
     "@commitlint/config-conventional": "7.0.1",
     "@commitlint/prompt-cli": "7.0.0",

packages/example-app/src/app/feedback/page.html

@@ -24,14 +24,14 @@ <h2>Feedback Form</h2>
       ngControl
       ngModel />
   </label>
-  
+
   <label for="comments">Comments:
     <textarea
       name="comments"
       [maxLength]="getMaxCommentChars()"
       ngControl
       ngModel></textarea>
-    <p>{{ charsLeft$ | async }} characters remaining.
+    <p>{{ charsLeft | async }} characters remaining.
   </label>
 
   <button>Send!</button>

packages/example-app/src/app/lions/page.html

@@ -1,7 +1,7 @@
 <zoo-animal-list
   animalsName="Lions"
   animalType="lion"
-  [animals]="animals$"
-  [loading]="loading$"
-  [error]="error$">
+  [animals]="animals"
+  [loading]="loading"
+  [error]="error">
 </zoo-animal-list>

packages/example-app/src/app/store/module.spec.ts

@@ -33,7 +33,7 @@ describe('Store Module', () => {
 
   it('should configure the store when the module is loaded', async(() => {
     const configureSpy = spyOn(MockNgRedux.getInstance(), 'configureStore');
-    new StoreModule(mockNgRedux, devTools, null, mockEpics as any);
+    new StoreModule(mockNgRedux, devTools, null as any, mockEpics as any);
 
     expect(configureSpy).toHaveBeenCalled();
   }));

packages/example-app/src/tsconfig.json

@@ -11,7 +11,6 @@
     "outDir": "../dist/out-tsc",
     "sourceMap": true,
     "target": "es5",
-    "typeRoots": ["../node_modules/@types"],
 
     // Causes problems for @Outputs with AoT.
     // See https://github.com/angular/angular/issues/17131.

packages/router/src/reducer.ts

@@ -9,7 +9,7 @@ export interface RouterAction extends Action {
 }
 
 export function routerReducer(
-  state: string = DefaultRouterState,
+  state: string | undefined = DefaultRouterState,
   action: RouterAction,
 ): string {
   switch (action.type) {

packages/store/src/components/root-store.spec.ts

@@ -195,9 +195,9 @@ describe('NgRedux Observable Store', () => {
   it('should wait until store is configured before emitting values', () => {
     // tslint:disable-next-line:max-classes-per-file
     class SomeService {
-      foo: string;
-      bar: string;
-      baz: number;
+      foo!: string;
+      bar!: string;
+      baz!: number;
 
       constructor(stateStore: NgRedux<any>) {
         stateStore.select(n => n.foo).subscribe(foo => (this.foo = foo));
@@ -217,9 +217,9 @@ describe('NgRedux Observable Store', () => {
   it('should have select decorators work before store is configured', done => {
     // tslint:disable-next-line:max-classes-per-file
     class SomeService {
-      @select() foo$: Observable<string>;
-      @select() bar$: Observable<string>;
-      @select() baz$: Observable<number>;
+      @select() foo$!: Observable<string>;
+      @select() bar$!: Observable<string>;
+      @select() baz$!: Observable<number>;
     }
 
     ngRedux = new RootStore<AppState>(mockNgZone);

packages/store/src/components/root-store.ts

@@ -7,6 +7,7 @@ import {
   Middleware,
   Reducer,
   Store,
+  StoreCreator,
   StoreEnhancer,
   Unsubscribe,
 } from 'redux';
@@ -49,12 +50,12 @@ export class RootStore<RootState> extends NgRedux<RootState> {
     enhancers: StoreEnhancer<RootState>[] = [],
   ): void => {
     assert(!this.store, 'Store already configured!');
-
     // Variable-arity compose in typescript FTW.
-    this.setStore(
-      compose.apply(null, [applyMiddleware(...middleware), ...enhancers])(
-        createStore,
-      )(enableFractalReducers(rootReducer), initState),
+    this.setStore(compose<StoreCreator>(
+      applyMiddleware(...middleware),
+        ...enhancers,
+      )(createStore)
+      (enableFractalReducers(rootReducer), initState),
     );
   };
 

packages/store/src/decorators/dispatch.spec.ts

@@ -31,7 +31,7 @@ describe('@dispatch', () => {
       instanceProperty: 'init-instanceProperty',
     };
 
-    rootReducer = (state = defaultState, action: PayloadAction) => {
+    rootReducer = (state = defaultState, action: PayloadAction): any => {
       switch (action.type) {
         case 'TEST':
           const { value = null, instanceProperty = null } =
@@ -54,7 +54,7 @@ describe('@dispatch', () => {
     class TestClass {
       instanceProperty = 'test';
 
-      @dispatch() externalFunction: (value: string) => PayloadAction;
+      @dispatch() externalFunction!: (value: string) => PayloadAction;
 
       @dispatch()
       classMethod(value: string): PayloadAction {

packages/store/src/decorators/dispatch.ts

@@ -15,7 +15,7 @@ export function dispatch(): PropertyDecorator {
   ): PropertyDescriptor {
     let originalMethod: () => void;
 
-    const wrapped = function(this: any, ...args: any[]) {
+    const wrapped = function(this: any, ...args: any) {
       const result = originalMethod.apply(this, args);
       if (result !== false) {
         const store = getBaseStore(this) || NgRedux.instance;

packages/store/src/decorators/select.spec.ts

@@ -40,7 +40,7 @@ describe('Select decorators', () => {
     describe('when passed no arguments', () => {
       it('binds to a store property that matches the name of the class property', done => {
         class MockClass {
-          @select() baz: Observable<number>;
+          @select() baz!: Observable<number>;
         }
         const mockInstance = new MockClass();
 
@@ -59,7 +59,7 @@ describe('Select decorators', () => {
 
       it('binds by name ignoring any $ characters in the class property name', done => {
         class MockClass {
-          @select() baz$: Observable<number>;
+          @select() baz$!: Observable<number>;
         }
         const mockInstance = new MockClass();
 
@@ -80,7 +80,7 @@ describe('Select decorators', () => {
     describe('when passed a string', () => {
       it('binds to the store property whose name matches the string value', done => {
         class MockClass {
-          @select('baz') obs$: Observable<number>;
+          @select('baz') obs$!: Observable<number>;
         }
         const mockInstance = new MockClass();
 
@@ -102,7 +102,7 @@ describe('Select decorators', () => {
       it('attempts to use that function as the selector function', done => {
         const selector = (state: AppState) => state.baz * 2;
         class MockClass {
-          @select(selector) obs$: Observable<number>;
+          @select(selector) obs$!: Observable<number>;
         }
         const mockInstance = new MockClass();
 
@@ -124,7 +124,7 @@ describe('Select decorators', () => {
       const comparator = (_: any, y: any): boolean => y === 1;
       class MockClass {
         @select('baz', comparator)
-        baz$: Observable<number>;
+        baz$!: Observable<number>;
       }
 
       it('should only trigger next when comparator returns true', done => {
@@ -147,7 +147,7 @@ describe('Select decorators', () => {
         const spy = jasmine.createSpy('spy');
         class LocalMockClass {
           @select('baz', spy)
-          baz$: Observable<number>;
+          baz$!: Observable<number>;
         }
 
         const mockInstance = new LocalMockClass();
@@ -169,7 +169,7 @@ describe('Select decorators', () => {
     it('applies a transformer to the observable', done => {
       class MockClass {
         @select$('baz', transformer)
-        baz$: Observable<number>;
+        baz$!: Observable<number>;
       }
       const mockInstance = new MockClass();
 
@@ -186,7 +186,7 @@ describe('Select decorators', () => {
       const comparator = (_: any, y: any): boolean => y === 1;
       class MockClass {
         @select$('baz', transformer, comparator)
-        baz$: Observable<number>;
+        baz$!: Observable<number>;
       }
 
       it('should only trigger next when the comparator returns true', done => {
@@ -209,7 +209,7 @@ describe('Select decorators', () => {
         const spy = jasmine.createSpy('spy');
         class SpyClass {
           @select$('baz', transformer, spy)
-          baz$: Observable<number>;
+          baz$!: Observable<number>;
         }
 
         const mockInstance = new SpyClass();