resolve comments

Author: jafu888

constraintlayout/core/src/main/java/androidx/constraintlayout/core/motion/Motion.java

@@ -31,7 +31,6 @@
 import androidx.constraintlayout.core.motion.utils.KeyCache;
 import androidx.constraintlayout.core.motion.utils.KeyCycleOscillator;
 import androidx.constraintlayout.core.motion.utils.KeyFrameArray;
-import androidx.constraintlayout.core.motion.utils.NonNull;
 import androidx.constraintlayout.core.motion.utils.Nullable;
 import androidx.constraintlayout.core.motion.utils.Rect;
 import androidx.constraintlayout.core.motion.utils.SplineSet;
@@ -250,6 +249,7 @@ public String getAnimateRelativeTo() {
     public void setupRelative(Motion motionController) {
         mRelativeMotion = motionController;
     }
+
     private void setupRelative() {
         if (mRelativeMotion == null) {
             return;
@@ -1734,9 +1734,9 @@ public boolean setValue(int id, String value) {
             mQuantizeMotionInterpolator = getInterpolator(SPLINE_STRING, value, 0);
             return true;
         }
-        if ( MotionType.TYPE_ANIMATE_RELATIVE_TO == id) {
-             mStartMotionPath.mAnimateRelativeTo = value;
-             return true;
+        if (MotionType.TYPE_ANIMATE_RELATIVE_TO == id) {
+            mStartMotionPath.mAnimateRelativeTo = value;
+            return true;
         }
         return false;
     }

constraintlayout/core/src/main/java/androidx/constraintlayout/core/motion/MotionPaths.java

@@ -158,9 +158,7 @@ void initPolar(int parentWidth,
         mHeight = (int) (s.mHeight + scaleY * scaleHeight);
         float startfactor = 1 - position;
         float endfactor = position;
-        Utils.log(mId+": start "+s.mX+","+s.mY);
-        Utils.log(mId+": end "+e.mX+","+e.mY);
-        Utils.log(mId+": mAnimateRelativeTo "+e.mAnimateRelativeTo);
+
         switch (c.mPositionType) {
             case MotionKeyPosition.TYPE_SCREEN:
                 this.mX = Float.isNaN(c.mPercentX) ? (position * (e.mX - s.mX) + s.mX)

constraintlayout/core/src/main/java/androidx/constraintlayout/core/state/Transition.java

@@ -705,33 +705,23 @@ public void addCustomColor(int state, String widgetId, String property, int colo
     }
 
     /**
-     * @TODO: add description
+     * Update container of parameters for the state
+     * @param container contains all the widget parameters
+     * @param state starting or ending
      */
     public void updateFrom(ConstraintWidgetContainer container, int state) {
         final ArrayList<ConstraintWidget> children = container.getChildren();
         final int count = children.size();
-        WidgetState [] states = new WidgetState[count];
-        boolean relative = false;
+        WidgetState[] states = new WidgetState[count];
+
         for (int i = 0; i < count; i++) {
             ConstraintWidget child = children.get(i);
             WidgetState widgetState = getWidgetState(child.stringId, null, state);
             states[i] = widgetState;
             widgetState.update(child, state);
-           String id =  widgetState.getPathRelativeId();
+            String id = widgetState.getPathRelativeId();
             if (id != null) {
-                relative = true;
-            }
-        }
-        if (relative) {
-            for (int i = 0; i < count; i++) {
-                ConstraintWidget child = children.get(i);
-                WidgetState widgetState = getWidgetState(child.stringId, null, state);
-                states[i] = widgetState;
-                String id = widgetState.getPathRelativeId();
-                if (id != null) {
-                     widgetState.setPathRelative(getWidgetState(id, null, state));
-
-                }
+                widgetState.setPathRelative(getWidgetState(id, null, state));
             }
         }