From 6ff6ed2b183165bb3847abffedc9e9d4a9ba9563 Mon Sep 17 00:00:00 2001 From: Nicholas Tindle Date: Sun, 28 Nov 2021 17:43:00 +0000 Subject: [PATCH 01/13] Add code Reviewers chapter --- contents/code_reviews/code_reviewers.md | 53 +++++++++++++++++++++++++ 1 file changed, 53 insertions(+) create mode 100644 contents/code_reviews/code_reviewers.md diff --git a/contents/code_reviews/code_reviewers.md b/contents/code_reviews/code_reviewers.md new file mode 100644 index 000000000..51b3387a6 --- /dev/null +++ b/contents/code_reviews/code_reviewers.md @@ -0,0 +1,53 @@ +# Code Reviewers + +If you are comfortable reviewing a language, please add yourself to the table below: + +[//]: # (To add yourself to the table, please add a link at the bottom of the article and reference yourself in the following format next to each language [@username]. If there are multiple usernames for a language, make sure to seperate them with commas) + +Language | Reviewers +-|- +asm | +c | +c# | +clojure | +coconut | [@amaras] +c++ | +emojicode | +fortran | [@leios] +gnuplot | [@leios] +go | +haskell | +java | +javascript | [@ntindle] +julia | [@leios] +kotlin | +lisp | +lua | +matlab | +nim | +php | +python | [@ntindle] +ruby | +rust | +scala | +scratch | [@leios] +swift | +typescript | [@ntindle] +viml | +whitespace | + +If you are comfortable reviewing a toolchain change, please add yourself to the list below: + +Feature | Reviewers +-|- +Dev Container | [@ntindle], [@ShadowMitia] +Docker | [@ntindle], [@ShadowMitia] +Github Actions | [@ntindle] +Honkit | +Scons | [@amaras] +Chapters | [@leios] + +[@leios]: https://github.com/leios +[@ntindle]: https://github.com/ntindle +[@amaras]: https://github.com/amaras +[@ShadowMitia]: https://github.com/ShadowMitia From f83bd3cd4e22a47b18a0bf83265efcffbf5a79d7 Mon Sep 17 00:00:00 2001 From: Nicholas Tindle Date: Sun, 28 Nov 2021 17:46:12 +0000 Subject: [PATCH 02/13] Add code reviews to summary --- SUMMARY.md | 1 + 1 file changed, 1 insertion(+) diff --git a/SUMMARY.md b/SUMMARY.md index e41ba39d4..4d4597b1c 100644 --- a/SUMMARY.md +++ b/SUMMARY.md @@ -3,6 +3,7 @@ * [Algorithm Archive](README.md) * [Introduction](contents/introduction/introduction.md) * [How To Contribute](contents/how_to_contribute/how_to_contribute.md) + * [Code Reviewers](contents/code_reviews/code_reviewers.md) * [Plotting](contents/plotting/plotting.md) * [Domain Coloring](contents/domain_coloring/domain_coloring.md) * [Iterated Function Systems](contents/IFS/IFS.md) From 89a91d606c39ad986aaf1d1ba958f0584a79cded Mon Sep 17 00:00:00 2001 From: Nicholas Tindle Date: Sun, 28 Nov 2021 17:58:59 +0000 Subject: [PATCH 03/13] add code reviews to how to contribute --- contents/how_to_contribute/how_to_contribute.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/contents/how_to_contribute/how_to_contribute.md b/contents/how_to_contribute/how_to_contribute.md index 010bc9a26..abadc5385 100644 --- a/contents/how_to_contribute/how_to_contribute.md +++ b/contents/how_to_contribute/how_to_contribute.md @@ -15,7 +15,9 @@ For now, here are the basics for submitting code to the Algorithm Archive: 3. **CONTRIBUTORS.md**: After contributing code, please echo your name to the end of `CONTRIBUTORS.md` with `echo "- name" >> CONTRIBUTORS.md`. 4. **Building the Algorithm Archive**: Before every submission, you should build the Algorithm Archive on your own machine. To do this, install [Node](https://nodejs.org/) and use `npm install` and then `npm run serve` in the main directory (where `README.md` is). This will provide a local URL to go to to view the archive in your browser of choice. Use this server to make sure your version of the Algorithm Archive works cleanly for the chapter you are updating! -To submit code, simply go to the `code/` directory of whatever chapter you want and add another directory for your language of choice. +To **submit code**, go to the `code/` directory of whatever chapter you want and add another directory for your language of choice. + +You can also help out by **reviewing code**, if you have the ability to review a language (and want to be asked to do so), please add yourself to [the Code Reviewers list](../code_reviews/code_reviewers.md) We use two GitBook plugins to allow users to flip between languages on different algorithms. One is the theme-api, and the other is the include-codeblock api. From a999adf0589bc4d7fc525bd53571c41dd9d244b4 Mon Sep 17 00:00:00 2001 From: Nicholas Tindle Date: Sun, 28 Nov 2021 12:09:40 -0600 Subject: [PATCH 04/13] Update contents/code_reviews/code_reviewers.md Co-authored-by: Dimitri Belopopsky --- contents/code_reviews/code_reviewers.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contents/code_reviews/code_reviewers.md b/contents/code_reviews/code_reviewers.md index 51b3387a6..a1f05a41f 100644 --- a/contents/code_reviews/code_reviewers.md +++ b/contents/code_reviews/code_reviewers.md @@ -28,7 +28,7 @@ nim | php | python | [@ntindle] ruby | -rust | +rust | [@ShadowMitia] scala | scratch | [@leios] swift | From 1a9dd0b82a8af7b8dcaf8a8991b0e1da119e2163 Mon Sep 17 00:00:00 2001 From: Nicholas Tindle Date: Sun, 28 Nov 2021 12:09:45 -0600 Subject: [PATCH 05/13] Update contents/code_reviews/code_reviewers.md Co-authored-by: Dimitri Belopopsky --- contents/code_reviews/code_reviewers.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contents/code_reviews/code_reviewers.md b/contents/code_reviews/code_reviewers.md index a1f05a41f..211e58e06 100644 --- a/contents/code_reviews/code_reviewers.md +++ b/contents/code_reviews/code_reviewers.md @@ -11,7 +11,7 @@ c | c# | clojure | coconut | [@amaras] -c++ | +c++ | [@ShadowMitia] emojicode | fortran | [@leios] gnuplot | [@leios] From 83f16eab95ab591b50b964001eaa342e70f8b4f5 Mon Sep 17 00:00:00 2001 From: Nicholas Tindle Date: Sun, 28 Nov 2021 12:19:17 -0600 Subject: [PATCH 06/13] Update contents/code_reviews/code_reviewers.md Co-authored-by: Dimitri Belopopsky --- contents/code_reviews/code_reviewers.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contents/code_reviews/code_reviewers.md b/contents/code_reviews/code_reviewers.md index 211e58e06..b5b2e792e 100644 --- a/contents/code_reviews/code_reviewers.md +++ b/contents/code_reviews/code_reviewers.md @@ -26,7 +26,7 @@ lua | matlab | nim | php | -python | [@ntindle] +python | [@ntindle],[@ShadowMitia] ruby | rust | [@ShadowMitia] scala | From f7f6eba9232c1332a8071297a37e4a0b41e0935c Mon Sep 17 00:00:00 2001 From: Nicholas Tindle Date: Sun, 28 Nov 2021 12:19:22 -0600 Subject: [PATCH 07/13] Update contents/code_reviews/code_reviewers.md Co-authored-by: Dimitri Belopopsky --- contents/code_reviews/code_reviewers.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contents/code_reviews/code_reviewers.md b/contents/code_reviews/code_reviewers.md index b5b2e792e..49835a8a5 100644 --- a/contents/code_reviews/code_reviewers.md +++ b/contents/code_reviews/code_reviewers.md @@ -18,7 +18,7 @@ gnuplot | [@leios] go | haskell | java | -javascript | [@ntindle] +javascript | [@ntindle],[@ShadowMitia] julia | [@leios] kotlin | lisp | From 42d318fe8ab04653318106f6a1ef6fd51c82b7d5 Mon Sep 17 00:00:00 2001 From: Nicholas Tindle Date: Sun, 28 Nov 2021 21:33:47 -0600 Subject: [PATCH 08/13] Apply suggestions from code review Co-authored-by: Dimitri Belopopsky --- contents/code_reviews/code_reviewers.md | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/contents/code_reviews/code_reviewers.md b/contents/code_reviews/code_reviewers.md index 49835a8a5..fe2f313b1 100644 --- a/contents/code_reviews/code_reviewers.md +++ b/contents/code_reviews/code_reviewers.md @@ -6,13 +6,19 @@ If you are comfortable reviewing a language, please add yourself to the table be Language | Reviewers -|- -asm | +asm-x64 | +bash | c | c# | clojure | coconut | [@amaras] c++ | [@ShadowMitia] +crystal | +D | +dart | +elm | emojicode | +factor | fortran | [@leios] gnuplot | [@leios] go | @@ -21,18 +27,28 @@ java | javascript | [@ntindle],[@ShadowMitia] julia | [@leios] kotlin | +labview | +lolcode | lisp | lua | matlab | nim | +ocaml | [@ShadowMitia] php | +piet | +powershell | python | [@ntindle],[@ShadowMitia] +r | +racket | ruby | rust | [@ShadowMitia] scala | +scheme | scratch | [@leios] +smalltask | swift | typescript | [@ntindle] +v | viml | whitespace | From 0308f9ad0938992bb739e327f93402009a933476 Mon Sep 17 00:00:00 2001 From: Dimitri Belopopsky Date: Mon, 29 Nov 2021 23:41:10 +0100 Subject: [PATCH 09/13] Update contents/code_reviews/code_reviewers.md Co-authored-by: Sammy Plat --- contents/code_reviews/code_reviewers.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contents/code_reviews/code_reviewers.md b/contents/code_reviews/code_reviewers.md index fe2f313b1..2ed428310 100644 --- a/contents/code_reviews/code_reviewers.md +++ b/contents/code_reviews/code_reviewers.md @@ -8,7 +8,7 @@ Language | Reviewers -|- asm-x64 | bash | -c | +c | [@amaras] c# | clojure | coconut | [@amaras] From b9544cda5f9645dfbdb2a04659a29a9cf63dbc05 Mon Sep 17 00:00:00 2001 From: Dimitri Belopopsky Date: Mon, 29 Nov 2021 23:41:15 +0100 Subject: [PATCH 10/13] Update contents/code_reviews/code_reviewers.md Co-authored-by: Sammy Plat --- contents/code_reviews/code_reviewers.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contents/code_reviews/code_reviewers.md b/contents/code_reviews/code_reviewers.md index 2ed428310..a82852ad8 100644 --- a/contents/code_reviews/code_reviewers.md +++ b/contents/code_reviews/code_reviewers.md @@ -37,7 +37,7 @@ ocaml | [@ShadowMitia] php | piet | powershell | -python | [@ntindle],[@ShadowMitia] +python | [@ntindle],[@ShadowMitia],[@amaras] r | racket | ruby | From bb6777335800b708fc3859d2210c743ca1b032a1 Mon Sep 17 00:00:00 2001 From: Dimitri Belopopsky Date: Mon, 29 Nov 2021 23:45:41 +0100 Subject: [PATCH 11/13] Update contents/code_reviews/code_reviewers.md --- contents/code_reviews/code_reviewers.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contents/code_reviews/code_reviewers.md b/contents/code_reviews/code_reviewers.md index a82852ad8..25a17686c 100644 --- a/contents/code_reviews/code_reviewers.md +++ b/contents/code_reviews/code_reviewers.md @@ -41,7 +41,7 @@ python | [@ntindle],[@ShadowMitia],[@amaras] r | racket | ruby | -rust | [@ShadowMitia] +rust | [@ShadowMitia],[@PeanutbutterWarrior] scala | scheme | scratch | [@leios] From 74fb317043f1b2f68f68f3d66c4e525f6b2a9be3 Mon Sep 17 00:00:00 2001 From: Dimitri Belopopsky Date: Mon, 29 Nov 2021 23:45:45 +0100 Subject: [PATCH 12/13] Update contents/code_reviews/code_reviewers.md --- contents/code_reviews/code_reviewers.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contents/code_reviews/code_reviewers.md b/contents/code_reviews/code_reviewers.md index 25a17686c..c8603150d 100644 --- a/contents/code_reviews/code_reviewers.md +++ b/contents/code_reviews/code_reviewers.md @@ -37,7 +37,7 @@ ocaml | [@ShadowMitia] php | piet | powershell | -python | [@ntindle],[@ShadowMitia],[@amaras] +python | [@ntindle],[@ShadowMitia],[@amaras],[@PeanutbutterWarrior] r | racket | ruby | From c20e86d4f3d4225917b380ba617fb3c5c6eb4bfb Mon Sep 17 00:00:00 2001 From: Dimitri Belopopsky Date: Mon, 29 Nov 2021 23:45:49 +0100 Subject: [PATCH 13/13] Update contents/code_reviews/code_reviewers.md --- contents/code_reviews/code_reviewers.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contents/code_reviews/code_reviewers.md b/contents/code_reviews/code_reviewers.md index c8603150d..0061ab996 100644 --- a/contents/code_reviews/code_reviewers.md +++ b/contents/code_reviews/code_reviewers.md @@ -60,7 +60,7 @@ Dev Container | [@ntindle], [@ShadowMitia] Docker | [@ntindle], [@ShadowMitia] Github Actions | [@ntindle] Honkit | -Scons | [@amaras] +Scons | [@amaras],[@PeanutbutterWarrior] Chapters | [@leios] [@leios]: https://github.com/leios