From eaaed0356687533d919f271e339386cbfd5bc282 Mon Sep 17 00:00:00 2001
From: Michal Hanajik <pudotta.pommin@gmail.com>
Date: Wed, 3 Oct 2018 15:12:33 +0100
Subject: [PATCH 1/5] Implementation Stable marriage problem in PHP

---
 .../code/php/stable_marriage.php              | 140 ++++++++++++++++++
 .../stable_marriage_problem.md                |   2 +
 2 files changed, 142 insertions(+)
 create mode 100644 contents/stable_marriage_problem/code/php/stable_marriage.php

diff --git a/contents/stable_marriage_problem/code/php/stable_marriage.php b/contents/stable_marriage_problem/code/php/stable_marriage.php
new file mode 100644
index 000000000..d2a09f04d
--- /dev/null
+++ b/contents/stable_marriage_problem/code/php/stable_marriage.php
@@ -0,0 +1,140 @@
+<?php
+declare(strict_types=1);
+
+abstract class Person
+{
+  private $name;
+  /** @var array Person[] */
+  protected $preferences = [];
+  /** @var Person */
+  protected $match;
+
+  public function __construct($name) { $this->name = $name; }
+
+  public function getName(): string
+  {
+    return $this->name;
+  }
+
+  public function setPreferences(array $preferences): void
+  {
+    shuffle($preferences);
+    $this->preferences = $preferences;
+  }
+
+  public function getMatch(): Person
+  {
+    return $this->match;
+  }
+
+  public function getPreferences(): array
+  {
+    return $this->preferences;
+  }
+
+  public function isSingle(): bool
+  {
+    return $this->match === null;
+  }
+
+  public function unmatch(): void
+  {
+    $this->match = null;
+  }
+
+  public function setMatch(Person $match): void
+  {
+    if ($this->match !== $match) {
+      if ($this->match !== null) {
+        $this->match->unmatch();
+      }
+      $this->match = $match;
+      if ($match !== null) $match->setMatch($this);
+    }
+  }
+
+  public function __toString(): string
+  {
+    return $this->name;
+  }
+}
+
+class Man extends Person
+{
+  public function propose(): void
+  {
+    if (!empty($this->preferences)) {
+      /** @var Woman $fiance */
+      $fiance = array_shift($this->preferences);
+      $fiance->receiveProposal($this);
+    }
+  }
+}
+
+class Woman extends Person
+{
+  /** @var Man[] */
+  private $suitors = [];
+
+  public function receiveProposal(Man $man): void
+  {
+    $this->suitors[] = $man;
+  }
+
+  public function chooseMatch(): void
+  {
+    foreach ($this->preferences as $preference) {
+      if ($preference === $this->match || in_array($preference, $this->suitors)) {
+        $this->setMatch($preference);
+        break;
+      }
+    }
+  }
+}
+
+function stable_marriage(array $men, array $women): void
+{
+  $smallerGroup = count($men) < count($women) ? $men : $women;
+  /** @var Woman $woman */
+  /** @var Man $man */
+  do {
+    foreach ($men as $man)
+      if ($man->isSingle()) $man->propose();
+
+    foreach ($women as $woman)
+      $woman->chooseMatch();
+
+    /** @var Person $person */
+    if (empty(array_filter($smallerGroup, function (Person $person) {
+      return $person->isSingle();
+    }))) break;
+
+  } while (true);
+
+  foreach ($women as $woman) echo sprintf('%s is married to %s%s', $woman, $woman->getMatch(), PHP_EOL);
+}
+
+$groupSize = 10;
+$men = [];
+$women = [];
+
+for ($i = 1; $i <= $groupSize; $i++) {
+  $men[] = new Man("M${i}");
+  $women[] = new Woman("W${i}");
+}
+
+/** @var Man $man */
+/** @var Woman $woman */
+foreach ($men as $man) {
+  $man->setPreferences($women);
+  echo sprintf('%s\'s choices:%s', $man->getName(), PHP_EOL);
+  echo sprintf('%s%s', implode(',', $man->getPreferences()), PHP_EOL);
+}
+echo PHP_EOL;
+foreach ($women as $woman) {
+  $woman->setPreferences($men);
+  echo sprintf('%s\'s choices:%s', $woman->getName(), PHP_EOL);
+  echo sprintf('%s%s', implode(',', $woman->getPreferences()), PHP_EOL);
+}
+echo PHP_EOL;
+stable_marriage($men, $women);
diff --git a/contents/stable_marriage_problem/stable_marriage_problem.md b/contents/stable_marriage_problem/stable_marriage_problem.md
index c1d12d674..9694b9f8c 100644
--- a/contents/stable_marriage_problem/stable_marriage_problem.md
+++ b/contents/stable_marriage_problem/stable_marriage_problem.md
@@ -44,6 +44,8 @@ I am incredibly interested to see what you guys do and how you implement the alg
 [import, lang:"csharp"](code/csharp/ListExtensions.cs)
 {% sample lang="java" %}
 [import, lang:"java"](code/java/stable-marriage.java)
+{% sample lang="php" %}
+[import, lang:"php"](code/php/stable_marriage.php)
 {% endmethod %}
 
 <script>

From 6d0d05e80444e811f133e894ff811fa9af05afb3 Mon Sep 17 00:00:00 2001
From: Michal Hanajik <pudotta.pommin@gmail.com>
Date: Thu, 4 Oct 2018 11:40:25 +0100
Subject: [PATCH 2/5] Changed code style

---
 .../code/php/stable_marriage.php              | 197 +++++++++---------
 1 file changed, 100 insertions(+), 97 deletions(-)

diff --git a/contents/stable_marriage_problem/code/php/stable_marriage.php b/contents/stable_marriage_problem/code/php/stable_marriage.php
index d2a09f04d..de126801e 100644
--- a/contents/stable_marriage_problem/code/php/stable_marriage.php
+++ b/contents/stable_marriage_problem/code/php/stable_marriage.php
@@ -3,115 +3,118 @@
 
 abstract class Person
 {
-  private $name;
-  /** @var array Person[] */
-  protected $preferences = [];
-  /** @var Person */
-  protected $match;
-
-  public function __construct($name) { $this->name = $name; }
-
-  public function getName(): string
-  {
-    return $this->name;
-  }
-
-  public function setPreferences(array $preferences): void
-  {
-    shuffle($preferences);
-    $this->preferences = $preferences;
-  }
-
-  public function getMatch(): Person
-  {
-    return $this->match;
-  }
-
-  public function getPreferences(): array
-  {
-    return $this->preferences;
-  }
-
-  public function isSingle(): bool
-  {
-    return $this->match === null;
-  }
-
-  public function unmatch(): void
-  {
-    $this->match = null;
-  }
-
-  public function setMatch(Person $match): void
-  {
-    if ($this->match !== $match) {
-      if ($this->match !== null) {
-        $this->match->unmatch();
-      }
-      $this->match = $match;
-      if ($match !== null) $match->setMatch($this);
+    private $name;
+    /** @var array Person[] */
+    protected $preferences = [];
+    /** @var Person */
+    protected $match;
+
+    public function __construct($name)
+    {
+        $this->name = $name;
     }
-  }
 
-  public function __toString(): string
-  {
-    return $this->name;
-  }
+    public function getName(): string
+    {
+        return $this->name;
+    }
+
+    public function setPreferences(array $preferences): void
+    {
+        shuffle($preferences);
+        $this->preferences = $preferences;
+    }
+
+    public function getMatch(): Person
+    {
+        return $this->match;
+    }
+
+    public function getPreferences(): array
+    {
+        return $this->preferences;
+    }
+
+    public function isSingle(): bool
+    {
+        return $this->match === null;
+    }
+
+    public function unmatch(): void
+    {
+        $this->match = null;
+    }
+
+    public function setMatch(Person $match): void
+    {
+        if ($this->match !== $match) {
+            if ($this->match !== null) {
+                $this->match->unmatch();
+            }
+            $this->match = $match;
+            if ($match !== null) $match->setMatch($this);
+        }
+    }
+
+    public function __toString(): string
+    {
+        return $this->name;
+    }
 }
 
 class Man extends Person
 {
-  public function propose(): void
-  {
-    if (!empty($this->preferences)) {
-      /** @var Woman $fiance */
-      $fiance = array_shift($this->preferences);
-      $fiance->receiveProposal($this);
+    public function propose(): void
+    {
+        if (!empty($this->preferences)) {
+            /** @var Woman $fiance */
+            $fiance = array_shift($this->preferences);
+            $fiance->receiveProposal($this);
+        }
     }
-  }
 }
 
 class Woman extends Person
 {
-  /** @var Man[] */
-  private $suitors = [];
-
-  public function receiveProposal(Man $man): void
-  {
-    $this->suitors[] = $man;
-  }
-
-  public function chooseMatch(): void
-  {
-    foreach ($this->preferences as $preference) {
-      if ($preference === $this->match || in_array($preference, $this->suitors)) {
-        $this->setMatch($preference);
-        break;
-      }
+    /** @var Man[] */
+    private $suitors = [];
+
+    public function receiveProposal(Man $man): void
+    {
+        $this->suitors[] = $man;
+    }
+
+    public function chooseMatch(): void
+    {
+        foreach ($this->preferences as $preference) {
+            if ($preference === $this->match || in_array($preference, $this->suitors)) {
+                $this->setMatch($preference);
+                break;
+            }
+        }
     }
-  }
 }
 
 function stable_marriage(array $men, array $women): void
 {
-  $smallerGroup = count($men) < count($women) ? $men : $women;
-  /** @var Woman $woman */
-  /** @var Man $man */
-  do {
-    foreach ($men as $man)
-      if ($man->isSingle()) $man->propose();
+    $smallerGroup = count($men) < count($women) ? $men : $women;
+    /** @var Woman $woman */
+    /** @var Man $man */
+    do {
+        foreach ($men as $man)
+            if ($man->isSingle()) $man->propose();
 
-    foreach ($women as $woman)
-      $woman->chooseMatch();
+        foreach ($women as $woman)
+            $woman->chooseMatch();
 
-    /** @var Person $person */
-    if (empty(array_filter($smallerGroup, function (Person $person) {
-      return $person->isSingle();
-    }))) break;
+        /** @var Person $person */
+        if (empty(array_filter($smallerGroup, function (Person $person) {
+            return $person->isSingle();
+        }))) break;
 
-  } while (true);
+    } while (true);
 
-  foreach ($women as $woman) echo sprintf('%s is married to %s%s', $woman, $woman->getMatch(), PHP_EOL);
+    foreach ($women as $woman) echo sprintf('%s is married to %s%s', $woman, $woman->getMatch(), PHP_EOL);
 }
 
 $groupSize = 10;
@@ -119,22 +122,22 @@ function stable_marriage(array $men, array $women): void
 $women = [];
 
 for ($i = 1; $i <= $groupSize; $i++) {
-  $men[] = new Man("M${i}");
-  $women[] = new Woman("W${i}");
+    $men[] = new Man("M${i}");
+    $women[] = new Woman("W${i}");
 }
 
 /** @var Man $man */
 /** @var Woman $woman */
 foreach ($men as $man) {
-  $man->setPreferences($women);
-  echo sprintf('%s\'s choices:%s', $man->getName(), PHP_EOL);
-  echo sprintf('%s%s', implode(',', $man->getPreferences()), PHP_EOL);
+    $man->setPreferences($women);
+    echo sprintf('%s\'s choices:%s', $man->getName(), PHP_EOL);
+    echo sprintf('%s%s', implode(',', $man->getPreferences()), PHP_EOL);
 }
 echo PHP_EOL;
 foreach ($women as $woman) {
-  $woman->setPreferences($men);
-  echo sprintf('%s\'s choices:%s', $woman->getName(), PHP_EOL);
-  echo sprintf('%s%s', implode(',', $woman->getPreferences()), PHP_EOL);
+    $woman->setPreferences($men);
+    echo sprintf('%s\'s choices:%s', $woman->getName(), PHP_EOL);
+    echo sprintf('%s%s', implode(',', $woman->getPreferences()), PHP_EOL);
 }
 echo PHP_EOL;
 stable_marriage($men, $women);

From 330eeabc4373343ee0444429204fdfc1bc93095a Mon Sep 17 00:00:00 2001
From: Michal Hanajik <pudotta.pommin@gmail.com>
Date: Sun, 7 Oct 2018 10:59:00 +0100
Subject: [PATCH 3/5] Update stable_marriage.php

removed annotations
changed sprintf to printf
---
 .../code/php/stable_marriage.php              | 19 +++++--------------
 1 file changed, 5 insertions(+), 14 deletions(-)

diff --git a/contents/stable_marriage_problem/code/php/stable_marriage.php b/contents/stable_marriage_problem/code/php/stable_marriage.php
index de126801e..6be8b8f1c 100644
--- a/contents/stable_marriage_problem/code/php/stable_marriage.php
+++ b/contents/stable_marriage_problem/code/php/stable_marriage.php
@@ -4,9 +4,7 @@
 abstract class Person
 {
     private $name;
-    /** @var array Person[] */
     protected $preferences = [];
-    /** @var Person */
     protected $match;
 
     public function __construct($name)
@@ -67,7 +65,6 @@ class Man extends Person
     public function propose(): void
     {
         if (!empty($this->preferences)) {
-            /** @var Woman $fiance */
             $fiance = array_shift($this->preferences);
             $fiance->receiveProposal($this);
         }
@@ -76,7 +73,6 @@ public function propose(): void
 
 class Woman extends Person
 {
-    /** @var Man[] */
     private $suitors = [];
 
     public function receiveProposal(Man $man): void
@@ -98,8 +94,6 @@ public function chooseMatch(): void
 function stable_marriage(array $men, array $women): void
 {
     $smallerGroup = count($men) < count($women) ? $men : $women;
-    /** @var Woman $woman */
-    /** @var Man $man */
     do {
         foreach ($men as $man)
             if ($man->isSingle()) $man->propose();
@@ -107,14 +101,13 @@ function stable_marriage(array $men, array $women): void
         foreach ($women as $woman)
             $woman->chooseMatch();
 
-        /** @var Person $person */
         if (empty(array_filter($smallerGroup, function (Person $person) {
             return $person->isSingle();
         }))) break;
 
     } while (true);
 
-    foreach ($women as $woman) echo sprintf('%s is married to %s%s', $woman, $woman->getMatch(), PHP_EOL);
+    foreach ($women as $woman) printf('%s is married to %s%s', $woman, $woman->getMatch(), PHP_EOL);
 }
 
 $groupSize = 10;
@@ -126,18 +119,16 @@ function stable_marriage(array $men, array $women): void
     $women[] = new Woman("W${i}");
 }
 
-/** @var Man $man */
-/** @var Woman $woman */
 foreach ($men as $man) {
     $man->setPreferences($women);
-    echo sprintf('%s\'s choices:%s', $man->getName(), PHP_EOL);
-    echo sprintf('%s%s', implode(',', $man->getPreferences()), PHP_EOL);
+    printf('%s\'s choices:%s', $man->getName(), PHP_EOL);
+    printf('%s%s', implode(',', $man->getPreferences()), PHP_EOL);
 }
 echo PHP_EOL;
 foreach ($women as $woman) {
     $woman->setPreferences($men);
-    echo sprintf('%s\'s choices:%s', $woman->getName(), PHP_EOL);
-    echo sprintf('%s%s', implode(',', $woman->getPreferences()), PHP_EOL);
+    printf('%s\'s choices:%s', $woman->getName(), PHP_EOL);
+    printf('%s%s', implode(',', $woman->getPreferences()), PHP_EOL);
 }
 echo PHP_EOL;
 stable_marriage($men, $women);

From 8157121e8aaa371f474f7064479551850766da46 Mon Sep 17 00:00:00 2001
From: Michal Hanajik <pudotta.pommin@gmail.com>
Date: Sun, 7 Oct 2018 17:29:08 +0100
Subject: [PATCH 4/5] Reworked implementation to one class and fixed some
 errors from PR

---
 .../code/php/stable_marriage.php              | 88 +++++++++++--------
 1 file changed, 49 insertions(+), 39 deletions(-)

diff --git a/contents/stable_marriage_problem/code/php/stable_marriage.php b/contents/stable_marriage_problem/code/php/stable_marriage.php
index 6be8b8f1c..7a69055eb 100644
--- a/contents/stable_marriage_problem/code/php/stable_marriage.php
+++ b/contents/stable_marriage_problem/code/php/stable_marriage.php
@@ -1,11 +1,12 @@
 <?php
 declare(strict_types=1);
 
-abstract class Person
+class Person
 {
     private $name;
-    protected $preferences = [];
-    protected $match;
+    private $suitors = [];
+    private $preferences = [];
+    private $match;
 
     public function __construct($name)
     {
@@ -19,11 +20,10 @@ public function getName(): string
 
     public function setPreferences(array $preferences): void
     {
-        shuffle($preferences);
         $this->preferences = $preferences;
     }
 
-    public function getMatch(): Person
+    public function getMatch(): ?Person
     {
         return $this->match;
     }
@@ -50,18 +50,10 @@ public function setMatch(Person $match): void
                 $this->match->unmatch();
             }
             $this->match = $match;
-            if ($match !== null) $match->setMatch($this);
+            $match->setMatch($this);
         }
     }
 
-    public function __toString(): string
-    {
-        return $this->name;
-    }
-}
-
-class Man extends Person
-{
     public function propose(): void
     {
         if (!empty($this->preferences)) {
@@ -69,13 +61,8 @@ public function propose(): void
             $fiance->receiveProposal($this);
         }
     }
-}
-
-class Woman extends Person
-{
-    private $suitors = [];
 
-    public function receiveProposal(Man $man): void
+    public function receiveProposal(Person $man): void
     {
         $this->suitors[] = $man;
     }
@@ -88,26 +75,40 @@ public function chooseMatch(): void
                 break;
             }
         }
+
+        $this->suitors = [];
+    }
+
+    public function __toString(): string
+    {
+        return $this->name;
     }
 }
 
-function stable_marriage(array $men, array $women): void
+function stable_marriage(array $men, array $women): array
 {
-    $smallerGroup = count($men) < count($women) ? $men : $women;
     do {
-        foreach ($men as $man)
-            if ($man->isSingle()) $man->propose();
+        foreach ($men as $man) {
+            if ($man->isSingle()) {
+                $man->propose();
+            }
+        }
 
-        foreach ($women as $woman)
+        foreach ($women as $woman) {
             $woman->chooseMatch();
+        }
 
-        if (empty(array_filter($smallerGroup, function (Person $person) {
-            return $person->isSingle();
-        }))) break;
+        $unmarried = false;
+        foreach ($women as $woman) {
+            if ($woman->isSingle()) {
+                $unmarried = true;
+                break;
+            }
+        }
 
-    } while (true);
+    } while ($unmarried);
 
-    foreach ($women as $woman) printf('%s is married to %s%s', $woman, $woman->getMatch(), PHP_EOL);
+    return $women;
 }
 
 $groupSize = 10;
@@ -115,20 +116,29 @@ function stable_marriage(array $men, array $women): void
 $women = [];
 
 for ($i = 1; $i <= $groupSize; $i++) {
-    $men[] = new Man("M${i}");
-    $women[] = new Woman("W${i}");
+    $men[] = new Person("M${i}");
+    $women[] = new Person("W${i}");
 }
 
 foreach ($men as $man) {
-    $man->setPreferences($women);
-    printf('%s\'s choices:%s', $man->getName(), PHP_EOL);
-    printf('%s%s', implode(',', $man->getPreferences()), PHP_EOL);
+    $preferences = $women;
+    shuffle($preferences);
+    $man->setPreferences($preferences);
+    printf('%s\'s choices: %s', $man->getName(), implode(',', $man->getPreferences()));
+    echo PHP_EOL;
 }
 echo PHP_EOL;
 foreach ($women as $woman) {
-    $woman->setPreferences($men);
-    printf('%s\'s choices:%s', $woman->getName(), PHP_EOL);
-    printf('%s%s', implode(',', $woman->getPreferences()), PHP_EOL);
+    $preferences = $men;
+    shuffle($preferences);
+    $woman->setPreferences($preferences);
+    printf('%s\'s choices: %s', $woman->getName(), implode(',', $woman->getPreferences()));
+    echo PHP_EOL;
 }
 echo PHP_EOL;
-stable_marriage($men, $women);
+
+$married = stable_marriage($men, $women);
+foreach ($married as $woman) {
+    printf('%s is married to %s', $woman, $woman->getMatch());
+    echo PHP_EOL;
+}

From 7da77b90acd1ee5c1ffa915c877623d36ea1a94a Mon Sep 17 00:00:00 2001
From: Michal Hanajik <pudotta.pommin@gmail.com>
Date: Mon, 8 Oct 2018 10:45:04 +0100
Subject: [PATCH 5/5] Update stable_marriage.php

return fix
---
 .../stable_marriage_problem/code/php/stable_marriage.php  | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/contents/stable_marriage_problem/code/php/stable_marriage.php b/contents/stable_marriage_problem/code/php/stable_marriage.php
index 7a69055eb..9599aff80 100644
--- a/contents/stable_marriage_problem/code/php/stable_marriage.php
+++ b/contents/stable_marriage_problem/code/php/stable_marriage.php
@@ -85,7 +85,7 @@ public function __toString(): string
     }
 }
 
-function stable_marriage(array $men, array $women): array
+function stable_marriage(array $men, array $women): void
 {
     do {
         foreach ($men as $man) {
@@ -107,8 +107,6 @@ function stable_marriage(array $men, array $women): array
         }
 
     } while ($unmarried);
-
-    return $women;
 }
 
 $groupSize = 10;
@@ -137,8 +135,8 @@ function stable_marriage(array $men, array $women): array
 }
 echo PHP_EOL;
 
-$married = stable_marriage($men, $women);
-foreach ($married as $woman) {
+stable_marriage($men, $women);
+foreach ($women as $woman) {
     printf('%s is married to %s', $woman, $woman->getMatch());
     echo PHP_EOL;
 }