Address code review comments

- remove asserts
- don't swap if it is a same row

Author: mika314

contents/gaussian_elimination/code/c++/gaussian_elimination.cpp

@@ -6,7 +6,6 @@
 #include <iomanip>
 
 void gaussian_elimination(std::vector<double>& a, int cols) {
-  assert(a.size() % cols == 0);
   int rows = a.size() / cols;
 
   int row = 0;
@@ -28,8 +27,10 @@ void gaussian_elimination(std::vector<double>& a, int cols) {
     }
 
     // Step 2: swap row with highest value for that column to the top
-    for (int c = 0; c < cols; ++c)
-      std::swap(a[c + row * cols], a[c + max_index * cols]);
+    if (row != max_index) {
+      for (int c = 0; c < cols; ++c)
+        std::swap(a[c + row * cols], a[c + max_index * cols]);
+    }
 
     // Loop for all remaining rows
     for (int i = row + 1; i < rows; ++i) {
@@ -52,7 +53,6 @@ void gaussian_elimination(std::vector<double>& a, int cols) {
 }
 
 std::vector<double> back_substitution(const std::vector<double>& a, int cols) {
-  assert(a.size() % cols == 0);
   int rows = a.size() / cols;
 
   // Creating the solution Vector
@@ -71,7 +71,6 @@ std::vector<double> back_substitution(const std::vector<double>& a, int cols) {
 }
 
 void gauss_jordan_elimination(std::vector<double>& a, int cols) {
-  assert(a.size() % cols == 0);
   // After this, we know what row to start on (r-1)
   // to go back through the matrix
   int row = 0;
@@ -92,7 +91,6 @@ void gauss_jordan_elimination(std::vector<double>& a, int cols) {
 }
 
 void print_matrix(const std::vector<double>& a, int cols) {
-  assert(a.size() % cols == 0);
   int rows = a.size() / cols;
   for (int i = 0; i < rows; ++i) {
     std::cout << "[";

contents/gaussian_elimination/gaussian_elimination.md

@@ -357,7 +357,7 @@ In code, this looks like:
 {% sample lang="c" %}
 [import:13-44, lang:"c_cpp"](code/c/gaussian_elimination.c)
 {% sample lang="cpp" %}
-[import:6-54, lang:"c_cpp"](code/c++/gaussian_elimination.cpp)
+[import:8-53, lang:"c_cpp"](code/c++/gaussian_elimination.cpp)
 {% sample lang="rs" %}
 [import:41-78, lang:"rust"](code/rust/gaussian_elimination.rs)
 {% sample lang="hs" %}
@@ -392,7 +392,7 @@ Here it is in code:
 This code does not exist yet in C, so here's Julia code (sorry for the inconvenience)
 [import:67-93, lang:"julia"](code/julia/gaussian_elimination.jl)
 {% sample lang="cpp" %}
-[import:79-98, lang:"c_cpp"](code/c++/gaussian_elimination.cpp)
+[import:73-91, lang:"c_cpp"](code/c++/gaussian_elimination.cpp)
 {% sample lang="rs" %}
 This code does not exist yet in rust, so here's Julia code (sorry for the inconvenience)
 [import:67-93, lang:"julia"](code/julia/gaussian_elimination.jl)
@@ -425,7 +425,7 @@ In code, this involves keeping a rolling sum of all the values we substitute in
 {% sample lang="c" %}
 [import:46-58, lang:"c_cpp"](code/c/gaussian_elimination.c)
 {% sample lang="cpp" %}
-[import:56-77, lang:"c_cpp"](code/c++/gaussian_elimination.cpp)
+[import:55-71, lang:"c_cpp"](code/c++/gaussian_elimination.cpp)
 {% sample lang="rs" %}
 [import:79-94, lang:"rust"](code/rust/gaussian_elimination.rs)
 {% sample lang="hs" %}