Skip to content

Commit accc3bf

Browse files
committed
Redact JWT token from logs
1 parent 7fa3245 commit accc3bf

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

src/app/code/community/Zendesk/Zendesk/controllers/Adminhtml/ZendeskController.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,10 @@ public function authenticateAction()
172172
$payload['external_id'] = $user->getId();
173173
}
174174

175-
Mage::log('Admin JWT: ' . var_export($payload, true), null, 'zendesk.log');
175+
// Redact token then log the rest of the payload
176+
$jti_redacted_payload = $payload; // arrays are copied by value in php, not just a ref being passed around
177+
$jti_redacted_payload["jti"] = "REDACTED";
178+
Mage::log('Admin JWT: ' . var_export($jti_redacted_payload, true), null, 'zendesk.log');
176179

177180
$jwt = JWT::encode($payload, $token);
178181
$return = $return_url ? "&return_to=".$return_url : "";

src/app/code/community/Zendesk/Zendesk/controllers/SsoController.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,10 @@ public function loginAction()
7575
$payload['external_id'] = $user->getId();
7676
}
7777

78-
Mage::log('End-user JWT: ' . var_export($payload, true), null, 'zendesk.log');
78+
// Redact token then log the rest of the payload
79+
$jti_redacted_payload = $payload; // arrays are copied by value in php, not just a ref being passed around
80+
$jti_redacted_payload["jti"] = "REDACTED";
81+
Mage::log('End-user JWT: ' . var_export($jti_redacted_payload, true), null, 'zendesk.log');
7982

8083
$jwt = JWT::encode($payload, $token);
8184
$return_url = $return_url ? "&return_to=".$return_url : "";

0 commit comments

Comments
 (0)