Skip to content

Commit 18dc535

Browse files
committed
[Java] Correct defaults for UINT32 type. Issue #455.
1 parent 410ceb3 commit 18dc535

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

sbe-tool/src/main/java/uk/co/real_logic/sbe/PrimitiveValue.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -59,18 +59,18 @@ public enum Representation
5959
public static final long NULL_VALUE_INT32 = -2147483648;
6060

6161
public static final long MIN_VALUE_UINT32 = 0;
62-
public static final long MAX_VALUE_UINT32 = 4294967293L; // 0xFFFFFFFD
63-
public static final long NULL_VALUE_UINT32 = 4294967294L; // 0xFFFFFFFE
62+
public static final long MAX_VALUE_UINT32 = 0xFFFF_FFFFL - 1;
63+
public static final long NULL_VALUE_UINT32 = 0xFFFF_FFFFL;
6464

65-
public static final long MIN_VALUE_INT64 = Long.MIN_VALUE + 1; // (-2 ^ 63) + 1
66-
public static final long MAX_VALUE_INT64 = Long.MAX_VALUE; // (2 ^ 63) - 1 (SBE spec says (-2 ^ 63) - 1)
67-
public static final long NULL_VALUE_INT64 = Long.MIN_VALUE; // (-2 ^ 63)
65+
public static final long MIN_VALUE_INT64 = Long.MIN_VALUE + 1; // (-2 ^ 63) + 1
66+
public static final long MAX_VALUE_INT64 = Long.MAX_VALUE; // ( 2 ^ 63) - 1
67+
public static final long NULL_VALUE_INT64 = Long.MIN_VALUE; // (-2 ^ 63)
6868

6969
public static final long MIN_VALUE_UINT64 = 0;
7070
public static final BigInteger BI_MAX_VALUE_UINT64 = new BigInteger("18446744073709551614");
71-
public static final long MAX_VALUE_UINT64 = BI_MAX_VALUE_UINT64.longValue(); // (2 ^ 64)- 2
71+
public static final long MAX_VALUE_UINT64 = BI_MAX_VALUE_UINT64.longValue(); // (2 ^ 64) - 2
7272
public static final BigInteger BI_NULL_VALUE_UINT64 = new BigInteger("18446744073709551615");
73-
public static final long NULL_VALUE_UINT64 = BI_NULL_VALUE_UINT64.longValue(); // (2 ^ 64)- 1
73+
public static final long NULL_VALUE_UINT64 = BI_NULL_VALUE_UINT64.longValue(); // (2 ^ 64) - 1
7474

7575
public static final float MIN_VALUE_FLOAT = Float.MIN_VALUE;
7676
public static final float MAX_VALUE_FLOAT = Float.MAX_VALUE;

0 commit comments

Comments
 (0)