From 67669715f95e8ed343c282195b16450579fe0a7d Mon Sep 17 00:00:00 2001 From: Alec Delaney Date: Mon, 28 Feb 2022 20:51:14 -0500 Subject: [PATCH 1/2] Add ValueError to start_range_continuous() Refactors `start_range_continuous()` and also adds throwing ValueError if out of range. --- adafruit_vl6180x.py | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/adafruit_vl6180x.py b/adafruit_vl6180x.py index e3c1beb..f953da7 100644 --- a/adafruit_vl6180x.py +++ b/adafruit_vl6180x.py @@ -170,15 +170,16 @@ def range_history_enabled(self) -> bool: def start_range_continuous(self, period: int = 100) -> None: """Start continuous range mode - :param int period: Time delay between measurements, in milliseconds + :param int period: Time delay between measurements, in milliseconds; the value you will be floored + to the nearest 10 milliseconds (setting to 157 ms sets it to 150 ms). Range is 10 - 2550 ms. """ # Set range between measurements - period_reg: int = 0 - if period > 10: - if period < 2250: - period_reg = (period // 10) - 1 - else: - period_reg = 254 + if not 10 <= period <= 2550: + raise ValueError( + "Delay must be in 10 millisecond increments between 10 and 2550 milliseconds" + ) + + period_reg = (period // 10) - 1 self._write_8(_VL6180X_REG_SYSRANGE_INTERMEASUREMENT_PERIOD, period_reg) # Start continuous range measurement From 374eaf9bc002f2dadda3d755ace69f036ec87697 Mon Sep 17 00:00:00 2001 From: Alec Delaney Date: Mon, 28 Feb 2022 20:58:12 -0500 Subject: [PATCH 2/2] Fix line length lint warnings --- adafruit_vl6180x.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/adafruit_vl6180x.py b/adafruit_vl6180x.py index f953da7..bf83d7a 100644 --- a/adafruit_vl6180x.py +++ b/adafruit_vl6180x.py @@ -170,8 +170,9 @@ def range_history_enabled(self) -> bool: def start_range_continuous(self, period: int = 100) -> None: """Start continuous range mode - :param int period: Time delay between measurements, in milliseconds; the value you will be floored - to the nearest 10 milliseconds (setting to 157 ms sets it to 150 ms). Range is 10 - 2550 ms. + :param int period: Time delay between measurements, in milliseconds; the value you + will be floored to the nearest 10 milliseconds (setting to 157 ms sets it to 150 + ms). Range is 10 - 2550 ms. """ # Set range between measurements if not 10 <= period <= 2550: