Fixes requested by reviewers

Author: mrmcwethy

.pylintrc

@@ -300,7 +300,7 @@ function-rgx=(([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$
 
 # Good variable names which should always be accepted, separated by a comma
 # good-names=i,j,k,ex,Run,_
-good-names=r,g,b,i,j,k,n,ex,Run,_
+good-names=r,g,b,w,i,j,k,n,x,y,z,ex,ok,Run,_
 
 # Include a hint for the correct naming format with invalid-name
 include-naming-hint=no
@@ -422,7 +422,7 @@ max-returns=6
 max-statements=50
 
 # Minimum number of public methods for a class (see R0903).
-min-public-methods=2
+min-public-methods=1
 
 
 [EXCEPTIONS]

adafruit_rgb_display/__init__.py

@@ -1,2 +1,2 @@
-"""import class color565"""
+"""Auto imports for Adafruit_CircuitPython_RGB_Display"""
 from adafruit_rgb_display.rgb import color565

adafruit_rgb_display/rgb.py

@@ -57,20 +57,20 @@ def init(self):
         for command, data in self._INIT:
             self.write(command, data)
 
-    #pylint: disable-msg=too-many-arguments
-    def _block(self, xpos0, ypos0, xpos1, ypos1, data=None):
+    #pylint: disable-msg=invalid-name,too-many-arguments
+    def _block(self, x0, y0, x1, y1, data=None):
         """Read or write a block of data."""
-        self.write(self._COLUMN_SET, self._encode_pos(xpos0, xpos1))
-        self.write(self._PAGE_SET, self._encode_pos(ypos0, ypos1))
+        self.write(self._COLUMN_SET, self._encode_pos(x0, x1))
+        self.write(self._PAGE_SET, self._encode_pos(y0, y1))
         if data is None:
             size = struct.calcsize(self._DECODE_PIXEL)
             return self.read(self._RAM_READ,
-                             (xpos1 - xpos0 + 1) * (ypos1 - ypos0 + 1) * size)
+                             (x1 - x0 + 1) * (y1 - y0 + 1) * size)
         self.write(self._RAM_WRITE, data)
         return None
-    #pylint: enable-msg=too-many-arguments
+    #pylint: enable-msg=invalid-name,too-many-arguments
 
-    def _encode_pos(self, x, y): #pylint: disable-msg=invalid-name
+    def _encode_pos(self, x, y):
         """Encode a postion into bytes."""
         return struct.pack(self._ENCODE_POS, x, y)
 
@@ -82,7 +82,7 @@ def _decode_pixel(self, data):
         """Decode bytes into a pixel color."""
         return color565(*struct.unpack(self._DECODE_PIXEL, data))
 
-    def pixel(self, x, y, color=None): #pylint: disable-msg=invalid-name
+    def pixel(self, x, y, color=None):
         """Read or write a pixel."""
         if color is None:
             return self._decode_pixel(self._block(x, y, x, y))
@@ -92,7 +92,7 @@ def pixel(self, x, y, color=None): #pylint: disable-msg=invalid-name
         return None
 
     #pylint: disable-msg=too-many-arguments
-    def fill_rectangle(self, x, y, width, height, color):  #pylint: disable-msg=invalid-name
+    def fill_rectangle(self, x, y, width, height, color):
         """Draw a filled rectangle."""
         x = min(self.width - 1, max(0, x))
         y = min(self.height - 1, max(0, y))
@@ -112,11 +112,11 @@ def fill(self, color=0):
         """Fill whole screen."""
         self.fill_rectangle(0, 0, self.width, self.height, color)
 
-    def hline(self, x, y, width, color): #pylint: disable-msg=invalid-name
+    def hline(self, x, y, width, color):
         """Draw a horizontal line."""
         self.fill_rectangle(x, y, width, 1, color)
 
-    def vline(self, x, y, height, color): #pylint: disable-msg=invalid-name
+    def vline(self, x, y, height, color):
         """Draw a vertical line."""
         self.fill_rectangle(x, y, 1, height, color)