Updated examples to work with smaller screen better #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could somebody please do a review on this? I would like it merged before I finish my guide. Thanks |
|
Summary of changes: |
|
👀 |
siddacious
suggested changes
Mar 1, 2019
examples/ra8875_bmptest.py
Outdated
| @@ -27,6 +27,9 @@ | |||
| display.init() | |||
| display.fill(WHITE) | |||
|
|
|||
| def color555(self, rgb): | |||
There was a problem hiding this comment.
I think this should be renamed something like cast_to_565 or something similar. Compared to color565 the name suggests that it's converting to 555.
Alternatively you could import color565 as color_565_from_24bpp and then make your own color565 that does the appropriate conversion based on bpp? Not a deal breaker either way
There was a problem hiding this comment.
I just went with convert_555_to_565()
siddacious
approved these changes
Mar 1, 2019
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Mar 2, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_RA8875 to 1.0.4 from 1.0.3: > Merge pull request adafruit/Adafruit_CircuitPython_RA8875#6 from makermelissa/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that I have a smaller screen that I can experiment with, I have updated the examples so that text and images are centered on both the large and small screen.