From 33103c49ed1bc232bbcf9fe4d1cdd457a2a1f82c Mon Sep 17 00:00:00 2001 From: John Ellis Date: Sat, 26 Mar 2022 11:16:16 -0400 Subject: [PATCH 1/3] Fix Attack Command Number; Add Chorus & Portamento Time - Fixed ATTACK_TIME value - Added CHORUS value - Added PORTAMENTO_TIME to match the PORTAMENTO on/off value --- adafruit_midi/control_change_values.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/adafruit_midi/control_change_values.py b/adafruit_midi/control_change_values.py index bad9f71..14dcd9f 100644 --- a/adafruit_midi/control_change_values.py +++ b/adafruit_midi/control_change_values.py @@ -46,13 +46,15 @@ EXPRESSION = 11 SUSTAIN_PEDAL = 64 PORTAMENTO = 65 +PORTAMENTO_TIME = 37 FILTER_RESONANCE = 71 RELEASE_TIME = 72 -ATTACK_TIME = 74 +ATTACK_TIME = 73 CUTOFF_FREQUENCY = 74 DECAY_TIME = 75 VIBRATO_RATE = 76 VIBRATO_DEPTH = 77 VIBRATO_DELAY = 78 +CHORUS = 93 ALL_CONTROLLERS_OFF = 121 ALL_NOTES_OFF = 123 From fcbd997e80e86b6a1f947cf9ba7a734608b56d9c Mon Sep 17 00:00:00 2001 From: John Ellis Date: Sat, 26 Mar 2022 11:43:19 -0400 Subject: [PATCH 2/3] Ordered by numeric value --- adafruit_midi/control_change_values.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/adafruit_midi/control_change_values.py b/adafruit_midi/control_change_values.py index 14dcd9f..fc698af 100644 --- a/adafruit_midi/control_change_values.py +++ b/adafruit_midi/control_change_values.py @@ -44,9 +44,9 @@ VOLUME = 7 PAN = 10 EXPRESSION = 11 +PORTAMENTO_TIME = 37 SUSTAIN_PEDAL = 64 PORTAMENTO = 65 -PORTAMENTO_TIME = 37 FILTER_RESONANCE = 71 RELEASE_TIME = 72 ATTACK_TIME = 73 From 7cf00b9462cd7b7b19c5d75ba65189ff6718ccc5 Mon Sep 17 00:00:00 2001 From: John Ellis Date: Sun, 3 Apr 2022 11:50:21 -0400 Subject: [PATCH 3/3] Updated to coarse control of portamento time Changed from fine to coarse control of portamento time based on feedback at https://github.com/adafruit/Adafruit_CircuitPython_MIDI/pull/49#issuecomment-1083193066 --- adafruit_midi/control_change_values.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/adafruit_midi/control_change_values.py b/adafruit_midi/control_change_values.py index fc698af..78ccb34 100644 --- a/adafruit_midi/control_change_values.py +++ b/adafruit_midi/control_change_values.py @@ -44,7 +44,7 @@ VOLUME = 7 PAN = 10 EXPRESSION = 11 -PORTAMENTO_TIME = 37 +PORTAMENTO_TIME = 5 SUSTAIN_PEDAL = 64 PORTAMENTO = 65 FILTER_RESONANCE = 71