From a249c47eced693acefd5da9c2e6269ef6ec1ef0a Mon Sep 17 00:00:00 2001 From: Jeff Epler Date: Tue, 20 Aug 2019 07:37:38 -0500 Subject: [PATCH 1/2] adafruit_itertools_extra: Fix import The import statement incorrectly referred to the package, not the submodule, leading to the reported traceback Testing performed: the user's testcase, ``` >>> from adafruit_itertools.adafruit_itertools import count >>> from adafruit_itertools.adafruit_itertools_extras import take >>> take(1, count(1, 5)) [1] ``` Closes: #3 --- adafruit_itertools/adafruit_itertools_extras.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/adafruit_itertools/adafruit_itertools_extras.py b/adafruit_itertools/adafruit_itertools_extras.py index 87fb2da..17efa1e 100644 --- a/adafruit_itertools/adafruit_itertools_extras.py +++ b/adafruit_itertools/adafruit_itertools_extras.py @@ -76,7 +76,7 @@ #pylint:disable=invalid-name,deprecated-lambda,keyword-arg-before-vararg -import adafruit_itertools as it +from . import adafruit_itertools as it __version__ = "0.0.0-auto.0" __repo__ = "https://github.com/adafruit/Adafruit_CircuitPython_Itertools.git" From 78d840f0850ac7c8f1c78547f417a15d62a9da0c Mon Sep 17 00:00:00 2001 From: Jeff Epler Date: Tue, 20 Aug 2019 07:44:54 -0500 Subject: [PATCH 2/2] Turn off linter message For technical reasons, pylint can't treat adafruit_itertools as a package when analyzing it, leading to the reported diagnostic ************* Module adafruit_itertools_extras E: 79, 0: Attempted relative import beyond top-level package (relative-beyond-top-level) Since creating an empty __init__.py would consume 512 valuable bytes of storage on a circuitpython device, instead just silence the message. --- adafruit_itertools/adafruit_itertools_extras.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/adafruit_itertools/adafruit_itertools_extras.py b/adafruit_itertools/adafruit_itertools_extras.py index 17efa1e..460475a 100644 --- a/adafruit_itertools/adafruit_itertools_extras.py +++ b/adafruit_itertools/adafruit_itertools_extras.py @@ -74,7 +74,7 @@ https://github.com/adafruit/circuitpython/releases """ -#pylint:disable=invalid-name,deprecated-lambda,keyword-arg-before-vararg +#pylint:disable=invalid-name,deprecated-lambda,keyword-arg-before-vararg,relative-beyond-top-level from . import adafruit_itertools as it