From 0f1ede65882cd1223aeb3fb4388b1da038130cbd Mon Sep 17 00:00:00 2001 From: dherrada Date: Tue, 28 Sep 2021 10:16:54 -0400 Subject: [PATCH 1/2] Linted --- examples/featherwing_keyboard_featherwing.py | 8 ++++++-- examples/featherwing_tft24_simpletest.py | 8 ++++++-- examples/featherwing_tft35_simpletest.py | 8 ++++++-- 3 files changed, 18 insertions(+), 6 deletions(-) diff --git a/examples/featherwing_keyboard_featherwing.py b/examples/featherwing_keyboard_featherwing.py index 643f443..841b60e 100644 --- a/examples/featherwing_keyboard_featherwing.py +++ b/examples/featherwing_keyboard_featherwing.py @@ -20,11 +20,15 @@ kbd_featherwing.neopixel[0] = 0x002244 try: - f = open("/sd/tft_featherwing.txt", "w") + f = open( # pylint: disable=unspecified-encoding,consider-using-with + "/sd/tft_featherwing.txt", "w" + ) f.write("Blinka\nBlackberry Q10 Keyboard") f.close() - f = open("/sd/tft_featherwing.txt", "r") + f = open( # pylint: disable=unspecified-encoding,consider-using-with + "/sd/tft_featherwing.txt", "r" + ) print(f.read()) f.close() except OSError as error: diff --git a/examples/featherwing_tft24_simpletest.py b/examples/featherwing_tft24_simpletest.py index 7f11eac..6a1ffab 100644 --- a/examples/featherwing_tft24_simpletest.py +++ b/examples/featherwing_tft24_simpletest.py @@ -13,11 +13,15 @@ tft_featherwing = tft_featherwing_24.TFTFeatherWing24() try: - f = open("/sd/tft_featherwing.txt", "w") + f = open( # pylint: disable=unspecified-encoding,consider-using-with + "/sd/tft_featherwing.txt", "w" + ) f.write("Blinka\nBlackberry Q10 Keyboard") f.close() - f = open("/sd/tft_featherwing.txt", "r") + f = open( # pylint: disable=unspecified-encoding,consider-using-with + "/sd/tft_featherwing.txt", "r" + ) print(f.read()) f.close() except OSError as error: diff --git a/examples/featherwing_tft35_simpletest.py b/examples/featherwing_tft35_simpletest.py index 475073a..57b8d77 100644 --- a/examples/featherwing_tft35_simpletest.py +++ b/examples/featherwing_tft35_simpletest.py @@ -13,11 +13,15 @@ tft_featherwing = tft_featherwing_35.TFTFeatherWing35() try: - f = open("/sd/tft_featherwing.txt", "w") + f = open( # pylint: disable=unspecified-encoding,consider-using-with + "/sd/tft_featherwing.txt", "w" + ) f.write("Blinka\nBlackberry Q10 Keyboard") f.close() - f = open("/sd/tft_featherwing.txt", "r") + f = open( # pylint: disable=unspecified-encoding,consider-using-with + "/sd/tft_featherwing.txt", "r" + ) print(f.read()) f.close() except OSError as error: From 9c5d052b42f5b69c2a8ffba5b7f180e8489168e1 Mon Sep 17 00:00:00 2001 From: dherrada Date: Tue, 28 Sep 2021 13:52:37 -0400 Subject: [PATCH 2/2] Fixed linting --- examples/featherwing_tft24_simpletest.py | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/examples/featherwing_tft24_simpletest.py b/examples/featherwing_tft24_simpletest.py index 6a1ffab..196c6aa 100644 --- a/examples/featherwing_tft24_simpletest.py +++ b/examples/featherwing_tft24_simpletest.py @@ -13,17 +13,16 @@ tft_featherwing = tft_featherwing_24.TFTFeatherWing24() try: - f = open( # pylint: disable=unspecified-encoding,consider-using-with + with open( # pylint: disable=unspecified-encoding "/sd/tft_featherwing.txt", "w" - ) - f.write("Blinka\nBlackberry Q10 Keyboard") - f.close() + ) as f: + f.write("Blinka\nBlackberry Q10 Keyboard") - f = open( # pylint: disable=unspecified-encoding,consider-using-with + with open( # pylint: disable=unspecified-encoding "/sd/tft_featherwing.txt", "r" - ) - print(f.read()) - f.close() + ) as f: + print(f.read()) + except OSError as error: print("Unable to write to SD Card.")