Ramsrq fixes #11
Merged
Ramsrq fixes #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some issues ares detected when - There are white spaces before and/or after when send press multiple keys - There is a empty line at the end of the file (index out of bound) - When default delay is modified, single or multiple key remain pressed during default delay period. 144: Fix white spaces after line 189: Prevent from key still pressed when default delay is more than zero. 202: Prevent error index out of bound whet read last line 203: Fix
Fix some issues
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Apr 27, 2023
Updating https://github.com/adafruit/Adafruit_CircuitPython_RGB_Display to 3.11.1 from 3.11.0: > Merge pull request adafruit/Adafruit_CircuitPython_RGB_Display#111 from matt-land/add-types-pycon-2023 Updating https://github.com/adafruit/Adafruit_CircuitPython_Ducky to 1.1.0 from 1.0.11: > Merge pull request adafruit/Adafruit_CircuitPython_Ducky#8 from pstray/no_sleep > Merge pull request adafruit/Adafruit_CircuitPython_Ducky#11 from FoamyGuy/ramsrq_fixes > Add upload url to release action > Add .venv to .gitignore Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes #10
I attempted to fix the formatting and one other noted change but it would not allow me to commit to the PR branch.
I wanted to get this one merged if possible to minimize chances for merge conflicts from the other PR which touched more code than this one.
From original PR:
I've omitted the first fix (144: Fix white spaces after line) because I was unable to replicate any issues related to that and during testing it seemed like this resulted in potentially stripping whitespace that was added intentionally by the user.
The other fixes noted in that PR are included here.
I tested all of them successfully on a Feather S2 TFT using the simpletest code and some basic "hello world" duckyscript code.