From 91674a178f699aa5bc7198a6afca3a55e5091318 Mon Sep 17 00:00:00 2001 From: Alex Colello Date: Mon, 22 Feb 2021 04:37:37 -0800 Subject: [PATCH 1/3] Fixed comment indentation This will fix a formatting issue in the documentation of the clue object where the sample code is not in the code block. --- adafruit_clue.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/adafruit_clue.py b/adafruit_clue.py index 7d27e20..ab77706 100644 --- a/adafruit_clue.py +++ b/adafruit_clue.py @@ -960,5 +960,5 @@ def simple_text_display( # pylint: disable=too-many-arguments .. code-block:: python - from adafruit_clue import clue + from adafruit_clue import clue """ From c84145f034f98d407ad2f9b57a8fcc3d377b3209 Mon Sep 17 00:00:00 2001 From: Alex Colello Date: Mon, 22 Feb 2021 05:55:23 -0800 Subject: [PATCH 2/3] Split linting for examples and advanced examples into two steps --- .github/workflows/build.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 59baa53..b748531 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -53,7 +53,8 @@ jobs: - name: PyLint run: | pylint $( find . -path './adafruit*.py' ) - ([[ ! -d "examples" ]] || pylint --disable=missing-docstring,invalid-name,bad-whitespace $( find . -path "./examples/*.py" )) + ([[ ! -d "examples" ]] || pylint --disable=missing-docstring,invalid-name,bad-whitespace $( find . -name "advanced_examples" -prune -false -o -path "./examples/*.py" )) + ([[ ! -d "examples/advanced_examples" ]] || pylint --disable=missing-docstring,invalid-name,bad-whitespace $( find . -path "./examples/advanced_examples/*.py" )) - name: Build assets run: circuitpython-build-bundles --filename_prefix ${{ steps.repo-name.outputs.repo-name }} --library_location . - name: Archive bundles From 66b9f8a15f42b710bb5af757b05060419cc40634 Mon Sep 17 00:00:00 2001 From: Alex Colello Date: Mon, 22 Feb 2021 15:16:05 -0800 Subject: [PATCH 3/3] Pinned PyLint version --- .github/workflows/build.yml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index b748531..c284ae1 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -44,7 +44,7 @@ jobs: source actions-ci/install.sh - name: Pip install pylint, Sphinx, pre-commit run: | - pip install --force-reinstall pylint Sphinx sphinx-rtd-theme pre-commit + pip install --force-reinstall pylint==2.6.* Sphinx sphinx-rtd-theme pre-commit - name: Library version run: git describe --dirty --always --tags - name: Pre-commit hooks @@ -53,8 +53,7 @@ jobs: - name: PyLint run: | pylint $( find . -path './adafruit*.py' ) - ([[ ! -d "examples" ]] || pylint --disable=missing-docstring,invalid-name,bad-whitespace $( find . -name "advanced_examples" -prune -false -o -path "./examples/*.py" )) - ([[ ! -d "examples/advanced_examples" ]] || pylint --disable=missing-docstring,invalid-name,bad-whitespace $( find . -path "./examples/advanced_examples/*.py" )) + ([[ ! -d "examples" ]] || pylint --disable=missing-docstring,invalid-name,bad-whitespace $( find . -path "./examples/*.py" )) - name: Build assets run: circuitpython-build-bundles --filename_prefix ${{ steps.repo-name.outputs.repo-name }} --library_location . - name: Archive bundles