Skip to content

Commit 46a1bb6

Browse files
authored
Merge pull request #1 from chickadee-tech/doc_fix
Fix up the docs.
2 parents dc79349 + f8897dc commit 46a1bb6

File tree

2 files changed

+31
-23
lines changed

2 files changed

+31
-23
lines changed

adafruit_bme280.py

Lines changed: 28 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
2121
# THE SOFTWARE.
2222
"""
23-
`adafruit_bmp280`
23+
`adafruit_bme280`
2424
====================================================
2525
2626
CircuitPython driver from BME280 Temperature, Humidity and Barometic Pressure sensor
@@ -63,6 +63,7 @@
6363
_BME280_HUMIDITY_MAX = const(100)
6464

6565
class Adafruit_BME280:
66+
"""Driver from BME280 Temperature, Humidity and Barometic Pressure sensor"""
6667
def __init__(self):
6768
"""Check the BME280 was found, read the coefficients and enable the sensor for continuous reads"""
6869
# Check device ID.
@@ -73,16 +74,17 @@ def __init__(self):
7374
time.sleep(0.5)
7475
self._read_coefficients()
7576
self.seaLevelhPa = 1013.25
77+
"""Pressure in hectoPascals at sea level. Used to calibrate `altitude`."""
7678
self._write_register_byte(_BME280_REGISTER_CTRL_HUM, 0x03) # turn on humidity oversample 16x
7779

7880
@property
7981
def temperature(self):
80-
"""Gets the compensated temperature in degrees celsius."""
82+
"""The compensated temperature in degrees celsius."""
8183
# perform one measurement
8284
self._write_register_byte(_BME280_REGISTER_CTRL_MEAS, 0xFE) # high res, forced mode
83-
85+
8486
# Wait for conversion to complete
85-
while (self._read_byte(_BME280_REGISTER_STATUS) & 0x08):
87+
while (self._read_byte(_BME280_REGISTER_STATUS) & 0x08):
8688
time.sleep(0.002)
8789
UT = self._read24(_BME280_REGISTER_TEMPDATA) / 16 # lowest 4 bits get dropped
8890
#print("raw temp: ", UT)
@@ -95,16 +97,16 @@ def temperature(self):
9597

9698
self.t_fine = int(var1 + var2)
9799
#print("t_fine: ", self.t_fine)
98-
100+
99101
temp = (var1 + var2) / 5120.0
100102
return temp
101103

102104
@property
103105
def pressure(self):
104-
"""Gets the compensated pressure in hectoPascals."""
106+
"""The compensated pressure in hectoPascals."""
105107
self.temperature # force read of t_fine
106-
107-
# Algorithm from the BME280 driver https://github.com/BoschSensortec/BME280_driver/blob/master/bme280.c
108+
109+
# Algorithm from the BME280 driver https://github.com/BoschSensortec/BME280_driver/blob/master/bme280.c
108110
adc = self._read24(_BME280_REGISTER_PRESSUREDATA) / 16 # lowest 4 bits get dropped
109111
var1 = float(self.t_fine) / 2.0 - 64000.0
110112
var2 = var1 * var1 * self.dig_P6 / 32768.0
@@ -123,14 +125,15 @@ def pressure(self):
123125
p = p + (var1 + var2 + self.dig_P7) / 16.0
124126

125127
p /= 100
126-
if (p < _BME280_PRESSURE_MIN_HPA): return _BME280_PRESSURE_MIN_HPA
127-
if (p > _BME280_PRESSURE_MAX_HPA): return _BME280_PRESSURE_MAX_HPA
128+
if (p < _BME280_PRESSURE_MIN_HPA): return _BME280_PRESSURE_MIN_HPA
129+
if (p > _BME280_PRESSURE_MAX_HPA): return _BME280_PRESSURE_MAX_HPA
128130
return p
129131
else:
130132
return _BME280_PRESSURE_MIN_HPA
131-
133+
132134
@property
133135
def humidity(self):
136+
"""The relative humidity in RH %"""
134137
self.temperature # force read of t_fine
135138
hum = self._read_register(_BME280_REGISTER_HUMIDDATA, 2)
136139
#print("Humidity data: ", hum)
@@ -140,27 +143,29 @@ def humidity(self):
140143
# Algorithm from the BME280 driver https://github.com/BoschSensortec/BME280_driver/blob/master/bme280.c
141144
var1 = float(self.t_fine) - 76800.0
142145
#print("var1 ", var1)
143-
var2 = (self.dig_H4 * 64.0 + (self.dig_H5 / 16384.0) * var1)
146+
var2 = (self.dig_H4 * 64.0 + (self.dig_H5 / 16384.0) * var1)
144147
#print("var2 ",var2)
145-
var3 = adc - var2
148+
var3 = adc - var2
146149
#print("var3 ",var3)
147-
var4 = self.dig_H2 / 65536.0
150+
var4 = self.dig_H2 / 65536.0
148151
#print("var4 ",var4)
149-
var5 = (1.0 + (self.dig_H3 / 67108864.0) * var1)
152+
var5 = (1.0 + (self.dig_H3 / 67108864.0) * var1)
150153
#print("var5 ",var5)
151-
var6 = 1.0 + (self.dig_H6 / 67108864.0) * var1 * var5
154+
var6 = 1.0 + (self.dig_H6 / 67108864.0) * var1 * var5
152155
#print("var6 ",var6)
153-
var6 = var3 * var4 * (var5 * var6)
154-
humidity = var6 * (1.0 - self.dig_H1 * var6 / 524288.0)
156+
var6 = var3 * var4 * (var5 * var6)
157+
humidity = var6 * (1.0 - self.dig_H1 * var6 / 524288.0)
155158

156-
if (humidity > _BME280_HUMIDITY_MAX): return _BME280_HUMIDITY_MAX
157-
if (humidity < _BME280_HUMIDITY_MIN): return _BME280_HUMIDITY_MIN
159+
if (humidity > _BME280_HUMIDITY_MAX):
160+
return _BME280_HUMIDITY_MAX
161+
if (humidity < _BME280_HUMIDITY_MIN):
162+
return _BME280_HUMIDITY_MIN
158163
# else...
159164
return humidity
160165

161166
@property
162167
def altitude(self):
163-
"""calculate the altitude based on the sea level pressure (seaLevelhPa) - which you must enter ahead of time)"""
168+
"""The altitude based on current `pressure` versus the sea level pressure (`seaLevelhPa`) - which you must enter ahead of time)"""
164169
p = self.pressure # in Si units for hPascal
165170
return 44330 * (1.0 - math.pow(p / self.seaLevelhPa, 0.1903));
166171

@@ -185,7 +190,7 @@ def _read_coefficients(self):
185190
#print("%d %d %d" % (self.dig_P7, self.dig_P8, self.dig_P9))
186191
#print("%d %d %d" % (self.dig_H1, self.dig_H2, self.dig_H3))
187192
#print("%d %d %d" % (self.dig_H4, self.dig_H5, self.dig_H6))
188-
193+
189194
def _read_byte(self, register):
190195
"""Read a byte register value and return it"""
191196
return self._read_register(register, 1)[0]
@@ -197,7 +202,7 @@ def _read24(self, register):
197202
ret *= 256.0
198203
ret += float(b & 0xFF)
199204
return ret
200-
205+
201206
class Adafruit_BME280_I2C(Adafruit_BME280):
202207
def __init__(self, i2c, address=_BME280_ADDRESS):
203208
import adafruit_bus_device.i2c_device as i2c_device

conf.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,9 @@
1515
'sphinx.ext.viewcode',
1616
]
1717

18+
# API docs fix
19+
autodoc_mock_imports = ['micropython']
20+
1821
intersphinx_mapping = {'python': ('https://docs.python.org/3.4', None),'BusDevice': ('https://circuitpython.readthedocs.io/projects/bus_device/en/latest/', None),'CircuitPython': ('https://circuitpython.readthedocs.io/en/latest/', None)}
1922

2023
# Add any paths that contain templates here, relative to this directory.

0 commit comments

Comments
 (0)