From 000126d26f66f2bdfe3d975a14162670ee115c17 Mon Sep 17 00:00:00 2001 From: madgrizzle Date: Sat, 11 Jul 2020 10:22:50 -0400 Subject: [PATCH 1/3] Add READ & NOTIFY Permissions to Battery Service This change allowed me to be able to read the battery service characteristic from nRF Connect as well as a forked version of GadgetBridge. The unmodified code has properties equal to 0 for this service. Reference this forum post: https://forums.adafruit.com/viewtopic.php?f=60&t=167056. --- adafruit_ble/services/standard/__init__.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/adafruit_ble/services/standard/__init__.py b/adafruit_ble/services/standard/__init__.py index 60b23d6..dcbccc2 100644 --- a/adafruit_ble/services/standard/__init__.py +++ b/adafruit_ble/services/standard/__init__.py @@ -29,6 +29,7 @@ from .. import Service from ...uuid import StandardUUID +from ...characteristics import Characteristic from ...characteristics.string import StringCharacteristic from ...characteristics import StructCharacteristic from ...characteristics.int import Uint8Characteristic @@ -69,7 +70,7 @@ class BatteryService(Service): """Provides battery level information""" uuid = StandardUUID(0x180F) - level = Uint8Characteristic(max_value=100, uuid=StandardUUID(0x2A19)) + level = Uint8Characteristic(max_value=100, properties=Characteristic.READ | Characteristic.NOTIFY, uuid=StandardUUID(0x2A19)) class CurrentTimeService(Service): From 2b153e1864bdf85cac450f6a2c34fc75eb2c8f9c Mon Sep 17 00:00:00 2001 From: Scott Shawcroft Date: Mon, 13 Jul 2020 15:41:50 -0700 Subject: [PATCH 2/3] Format the with black. https://black.now.sh/?version=stable&state=_Td6WFoAAATm1rRGAgAhARYAAAB0L-Wj4A6VBkxdAD2IimZxl1N_Wg0-BMH3ggP52tdMq8XoENZMIArGLxeGGbwOXRdKn_5wLHn6GD-UBxpmb4049NHGmxgLh-168CVYsCSbgwutcEKEAOza59ap8_IWfUrorQhe6Hk6tZcO2mHDw0bO3D9oSPvghceVtez2TM7l6G9T_Gepuk48S0uPslKCPlixEA1tTGrstm8yJOfqaPPCi0Pdog1uFTc4-Hrotchj3bvxi5QvKyn-x1Y3VFZcOJjzo61N2PjX0ghYvjxFHq-1Ny3Cy3egwfbEZ52_kKHOxHBFF0enY2eQ9kdIX80JvU0liSS-hSDi3WNYt9vcV6leA2HgYIOM-59OER8xDD4guJFzdSB5_24WvHJV8vuMCfbDVIZ1jU6AuTsaXDzF40Tj5J-rBQ87ZAgYargciTrdHPbpY54OQyv3rDEemkHnsu0U7iXkW_sJ2So5gD9xghatW5hhKRlS5U8HtePt33oxq6KLELQucM043Fa1u610Pmy7WnMw6ST118jlYvHV2GF2o-nWSdUC1QzEhYwziKE3TGFkYrxasVO3ACI7_lgqFNPQg_vMFzlh8NndOHl00QVGUBhCWIjP9vUTw2hrQaXBKY9jEz1c5IbS9zQ0Abxhp-ChOhSr9aZMzVVZqZqfEqN9thMA9csCmepdhzmVtxpRqbkexyFbJ3zAA3KktRrOPKxOfrvf9fHXjLDuW9gj8ImVsAsb3ntXURtnkR9qNvTDaBrfpBPPSsG-ptLkxPF6p1YAUMmL69c1-4kfh8OcfXmDIgFKKjOkMC8H6hHjNGgco0JHDBFd8xGuk_0OecsJTpJFDyUF9kOku7x6--rJJWNLeOk6t3DHDbDUrng5laXs22GBy-6FLazXPFTZnyz-LIlFjhaGjmUOQ_0J09cq2EO87ISVWyLEs07wZuEPLTpegNubN_x9neyH2Psyv-jHrdZ_M-7FthZ5YTln9mOs5aFs-1x38AXy4ZzyQ-drsUmKJ1-nVDoSI5GMr0J-7qoC4rRDJANvfzXhwsJlFN1GjbR6pULTVha7Vb-IPctEEkcUfBVBhbqNCa6fkF_rXPTEWlwj6IvR6wMTI2w3BzDTlryUrDgBgjSldU_E23sEv7kQfw84Ptygrr-Ckc6FeDNJm1_EowaBqlUyVpb5d81scneSrKFXxTuoW0RJVAW7VVzHS77hwJGjJfaz8GRNB-gxaKYM1YgQrP3ET-4s0nIAfrdiHpBPJWY8A_3bygvgI1i598fHEme2I4eaAghjn1c1sMZYuQ9vGs6mGsJRtnjjd2IIE9CCKFXy0bnPUX45iMCoLjVWuWxCDOSrcZhlxhhSMSyE5P4QHtBJrqVxscf2Ks1f73Y-m8IVsL_V5a_uRX6huNKXsEHSc8SjBzw1gzKP9mTa-QfzLJabscD-OsrzWZ1nR3C9qUEB9uwAJx92hX62uCBSr0lXSYbMZIDIgyejqvZAFfeINMYbO6P1eRyNCnlEqam70qfqscAt2R0nUa9tAOC6QTqZjPGe0K41GHv66rYDBpZSTB33wbLGZsGeNywFhwdJGyClfSZDWp3WQ_nqQwypUo6eVULKqHuro22KX9_m2PucsyId6lZoSTx4XV7XI0BQhNUTrCbRC52AXUBmDtDQRmwrF_p3KxNKxRaQKJctlHP8GTCDI8BQObgD4PqQrutRW4X1qvu-eHceIVMxJYvX1zYO3dvzxh6I80KEaRr7zKM-xxr5_K_3ymZpPhPPTAWZrBOwrk-qVnhuWpPFkoaWwV7j918LE1qe7sMt5Psr5pe1pI5-yM6qdPwXsxHqFVJfHxWqg8hlaWfSQ3cfFIqQM_TlmDsVzwQMZkYBaaUIhNmQR0hQzHjLua1NBFeBy0AMjGvf2n8edF-sYRV0xm6mLNHYFKCU66M71F_YNzBiU3l4YzcYeAtLOuSbvYMjzn-2sujxbyblQqgmxU9ssSPhkqwD4L312DKjn97Mr5vFkrVDTENhQ3dCYrAPtuT3VcRsJEwrmKvypLSE7pufsoItMKGnBDi7Tve-FHwg_lx-lSnpOvgebVKBguIrMFFJUjCXLjc8RfwZp7i3a4YuNcDMsRPs8pbMyWGqkbVXoruBKVG1fZ6TH2EETy7_Jbxn9JZNI_Ae6wLdrTaywReGtU_ARGE4oQAAGcFGQmlaFFwAAegMlh0AAGguZ3CxxGf7AgAAAAAEWVo= --- adafruit_ble/services/standard/__init__.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/adafruit_ble/services/standard/__init__.py b/adafruit_ble/services/standard/__init__.py index dcbccc2..8e072e3 100644 --- a/adafruit_ble/services/standard/__init__.py +++ b/adafruit_ble/services/standard/__init__.py @@ -70,8 +70,11 @@ class BatteryService(Service): """Provides battery level information""" uuid = StandardUUID(0x180F) - level = Uint8Characteristic(max_value=100, properties=Characteristic.READ | Characteristic.NOTIFY, uuid=StandardUUID(0x2A19)) - + level = Uint8Characteristic( + max_value=100, + properties=Characteristic.READ | Characteristic.NOTIFY, + uuid=StandardUUID(0x2A19), + ) class CurrentTimeService(Service): """Provides the current time.""" From d23e7cfbb0e7215c52e4a7bf8deb7cea4b433b55 Mon Sep 17 00:00:00 2001 From: Scott Shawcroft Date: Mon, 13 Jul 2020 15:49:19 -0700 Subject: [PATCH 3/3] Add second line --- adafruit_ble/services/standard/__init__.py | 1 + 1 file changed, 1 insertion(+) diff --git a/adafruit_ble/services/standard/__init__.py b/adafruit_ble/services/standard/__init__.py index 8e072e3..a452ede 100644 --- a/adafruit_ble/services/standard/__init__.py +++ b/adafruit_ble/services/standard/__init__.py @@ -76,6 +76,7 @@ class BatteryService(Service): uuid=StandardUUID(0x2A19), ) + class CurrentTimeService(Service): """Provides the current time."""