From 0282677650074f43995bd6e3ece108f8175a03b0 Mon Sep 17 00:00:00 2001
From: dherrada <dylan.herrada@gmail.com>
Date: Thu, 9 Jan 2020 21:53:36 -0500
Subject: [PATCH 1/4] Added pylint ignores so Actions will pass

---
 adafruit_ble/advertising/__init__.py       | 2 ++
 adafruit_ble/attributes/__init__.py        | 1 +
 adafruit_ble/characteristics/int.py        | 6 ++++++
 adafruit_ble/services/midi.py              | 1 +
 adafruit_ble/services/standard/__init__.py | 1 +
 adafruit_ble/services/standard/hid.py      | 4 +++-
 6 files changed, 14 insertions(+), 1 deletion(-)

diff --git a/adafruit_ble/advertising/__init__.py b/adafruit_ble/advertising/__init__.py
index b8fe84a..dc8e660 100644
--- a/adafruit_ble/advertising/__init__.py
+++ b/adafruit_ble/advertising/__init__.py
@@ -85,6 +85,8 @@ def encode_data(data_dict, *, key_encoding="B"):
 
 class AdvertisingDataField:
     """Top level class for any descriptor classes that live in Advertisement or its subclasses."""
+    # pylint: disable=too-few-public-methods
+    pass
 
 class AdvertisingFlag:
     """A single bit flag within an AdvertisingFlags object."""
diff --git a/adafruit_ble/attributes/__init__.py b/adafruit_ble/attributes/__init__.py
index b0b80d4..3138a21 100644
--- a/adafruit_ble/attributes/__init__.py
+++ b/adafruit_ble/attributes/__init__.py
@@ -63,6 +63,7 @@ class Attribute:
 
          security_mode: authenticated data signing, without man-in-the-middle protection
 """
+    # pylint: disable=too-few-public-methods
     NO_ACCESS = _bleio.Attribute.NO_ACCESS
     OPEN = _bleio.Attribute.OPEN
     ENCRYPT_NO_MITM = _bleio.Attribute.ENCRYPT_NO_MITM
diff --git a/adafruit_ble/characteristics/int.py b/adafruit_ble/characteristics/int.py
index 24df976..7f8c54f 100755
--- a/adafruit_ble/characteristics/int.py
+++ b/adafruit_ble/characteristics/int.py
@@ -60,30 +60,36 @@ def __set__(self, obj, value):
 
 class Int8Characteristic(IntCharacteristic):
     """Int8 number."""
+    # pylint: disable=too-few-public-methods
     def __init__(self, *, min_value=-128, max_value=127, **kwargs):
         super().__init__("<b", min_value, max_value, **kwargs)
 
 class Uint8Characteristic(IntCharacteristic):
     """Uint8 number."""
+    # pylint: disable=too-few-public-methods
     def __init__(self, *, min_value=0, max_value=0xff, **kwargs):
         super().__init__("<B", min_value, max_value, **kwargs)
 
 class Int16Characteristic(IntCharacteristic):
     """Int16 number."""
+    # pylint: disable=too-few-public-methods
     def __init__(self, *, min_value=-32768, max_value=32767, **kwargs):
         super().__init__("<h", min_value, max_value, **kwargs)
 
 class Uint16Characteristic(IntCharacteristic):
     """Uint16 number."""
+    # pylint: disable=too-few-public-methods
     def __init__(self, *, min_value=0, max_value=0xffff, **kwargs):
         super().__init__("<H", min_value, max_value, **kwargs)
 
 class Int32Characteristic(IntCharacteristic):
     """Int32 number."""
+    # pylint: disable=too-few-public-methods
     def __init__(self, *, min_value=-2147483648, max_value=2147483647, **kwargs):
         super().__init__("<i", min_value, max_value, **kwargs)
 
 class Uint32Characteristic(IntCharacteristic):
     """Uint32 number."""
+    # pylint: disable=too-few-public-methods
     def __init__(self, *, min_value=0, max_value=0xffffffff, **kwargs):
         super().__init__("<I", min_value, max_value, **kwargs)
diff --git a/adafruit_ble/services/midi.py b/adafruit_ble/services/midi.py
index 229031d..ab94d44 100644
--- a/adafruit_ble/services/midi.py
+++ b/adafruit_ble/services/midi.py
@@ -36,6 +36,7 @@
 
 class MidiIOCharacteristic(Characteristic):
     """Workhorse MIDI Characteristic that carries midi messages both directions. Unimplemented."""
+    # pylint: disable=too-few-public-methods
     uuid = VendorUUID("7772E5DB-3868-4112-A1A9-F2669D106BF3")
     def __init__(self, **kwargs):
         super().__init__(properties=(Characteristic.NOTIFY |
diff --git a/adafruit_ble/services/standard/__init__.py b/adafruit_ble/services/standard/__init__.py
index 1719ad2..1914f0a 100644
--- a/adafruit_ble/services/standard/__init__.py
+++ b/adafruit_ble/services/standard/__init__.py
@@ -38,6 +38,7 @@
 
 class AppearanceCharacteristic(StructCharacteristic):
     """What type of device it is"""
+    # pylint: disable=too-few-public-methods
     uuid = StandardUUID(0x2a01)
 
     def __init__(self, **kwargs):
diff --git a/adafruit_ble/services/standard/hid.py b/adafruit_ble/services/standard/hid.py
index d24f94b..bcb8d0d 100755
--- a/adafruit_ble/services/standard/hid.py
+++ b/adafruit_ble/services/standard/hid.py
@@ -96,6 +96,7 @@ def send_report(self, report):
 
 class ReportOut:
     """A single HID report that receives HID data from a client."""
+    # pylint: disable=too-few-public-methods
     uuid = StandardUUID(_REPORT_UUID_NUM)
     def __init__(self, service, report_id, usage_page, usage, *, max_length):
         self._characteristic = _bleio.Characteristic.add_to_service(
@@ -248,6 +249,7 @@ def _init_devices(self):
             i += size
 
         def get_report_info(collection, reports):
+            """ Gets info about hid reports """
             for main in collection["mains"]:
                 if "type" in main:
                     get_report_info(main, reports)
@@ -269,7 +271,7 @@ def get_report_info(collection, reports):
             reports = {}
             get_report_info(collection, reports)
             if len(reports) > 1:
-                raise NotImplementedError("Only on report id per Application collection supported")
+                raise NotImplementedError("Only one report id per Application collection supported")
 
             report_id, report = list(reports.items())[0]
             output_size = report["output_size"]

From a609685ba47bea20498e92f5f10c23b870db12bf Mon Sep 17 00:00:00 2001
From: dherrada <dylan.herrada@gmail.com>
Date: Sat, 11 Jan 2020 20:20:33 -0500
Subject: [PATCH 2/4] Removed pylint disable from .travis.yml

---
 .travis.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.travis.yml b/.travis.yml
index 59f76f0..341eff0 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -20,7 +20,7 @@ install:
 - pip install --force-reinstall "pylint<3"
 
 script:
-- pylint --disable=too-few-public-methods adafruit_ble/**/*.py adafruit_ble/*.py
+- pylint adafruit_ble/**/*.py adafruit_ble/*.py
 - ([[ ! -d "examples" ]] || pylint --disable=missing-docstring,invalid-name,bad-whitespace
   examples/*.py)
 - circuitpython-build-bundles --filename_prefix adafruit-circuitpython-ble

From d462c0b02580389960b58b0585984b0012c352d9 Mon Sep 17 00:00:00 2001
From: dherrada <dylan.herrada@gmail.com>
Date: Sat, 11 Jan 2020 20:35:01 -0500
Subject: [PATCH 3/4] This fails locally, but travis indicates that it might
 pass on its end

---
 adafruit_ble/advertising/__init__.py | 1 -
 1 file changed, 1 deletion(-)

diff --git a/adafruit_ble/advertising/__init__.py b/adafruit_ble/advertising/__init__.py
index dc8e660..f19cf5d 100644
--- a/adafruit_ble/advertising/__init__.py
+++ b/adafruit_ble/advertising/__init__.py
@@ -86,7 +86,6 @@ def encode_data(data_dict, *, key_encoding="B"):
 class AdvertisingDataField:
     """Top level class for any descriptor classes that live in Advertisement or its subclasses."""
     # pylint: disable=too-few-public-methods
-    pass
 
 class AdvertisingFlag:
     """A single bit flag within an AdvertisingFlags object."""

From bdc8b44c28d92115976b983316956e5c94456132 Mon Sep 17 00:00:00 2001
From: dherrada <dylan.herrada@gmail.com>
Date: Sat, 11 Jan 2020 20:38:44 -0500
Subject: [PATCH 4/4] disabled unnecessary-pass for a problematic function

---
 adafruit_ble/advertising/__init__.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/adafruit_ble/advertising/__init__.py b/adafruit_ble/advertising/__init__.py
index f19cf5d..a1d201a 100644
--- a/adafruit_ble/advertising/__init__.py
+++ b/adafruit_ble/advertising/__init__.py
@@ -85,7 +85,8 @@ def encode_data(data_dict, *, key_encoding="B"):
 
 class AdvertisingDataField:
     """Top level class for any descriptor classes that live in Advertisement or its subclasses."""
-    # pylint: disable=too-few-public-methods
+    # pylint: disable=too-few-public-methods,unnecessary-pass
+    pass
 
 class AdvertisingFlag:
     """A single bit flag within an AdvertisingFlags object."""