Skip to content

Commit b36b7c2

Browse files
committed
Avoid shallow copies of webhook
ref kubernetes-sigs/controller-runtime#1667
1 parent ceef0cd commit b36b7c2

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

test/integration/envtest/resourcemanager/tokeninvalidator/tokeninvalidator_suite_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,8 +103,8 @@ var _ = AfterSuite(func() {
103103
Expect(testEnv.Stop()).To(Succeed())
104104
})
105105

106-
func getMutatingWebhookConfigurations() []admissionregistrationv1.MutatingWebhookConfiguration {
107-
return []admissionregistrationv1.MutatingWebhookConfiguration{
106+
func getMutatingWebhookConfigurations() []*admissionregistrationv1.MutatingWebhookConfiguration {
107+
return []*admissionregistrationv1.MutatingWebhookConfiguration{
108108
{
109109
TypeMeta: metav1.TypeMeta{
110110
APIVersion: admissionregistrationv1.SchemeGroupVersion.String(),

test/integration/envtest/seedadmissioncontroller/seedadmission_suite_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,8 @@ var _ = BeforeSuite(func() {
6868
By("starting test environment")
6969
testEnv = &envtest.Environment{
7070
WebhookInstallOptions: envtest.WebhookInstallOptions{
71-
ValidatingWebhooks: []admissionregistrationv1.ValidatingWebhookConfiguration{*getValidatingWebhookConfig()},
72-
MutatingWebhooks: []admissionregistrationv1.MutatingWebhookConfiguration{*getMutatingWebhookConfig()},
71+
ValidatingWebhooks: []*admissionregistrationv1.ValidatingWebhookConfiguration{getValidatingWebhookConfig()},
72+
MutatingWebhooks: []*admissionregistrationv1.MutatingWebhookConfiguration{getMutatingWebhookConfig()},
7373
},
7474
}
7575
restConfig, err = testEnv.Start()

0 commit comments

Comments
 (0)