Removed deprecated code

Author: GrahamCampbell

doc/rate_limits.md

@@ -5,7 +5,6 @@ Get rate limit wrappers from [GitHub Rate Limit API](http://developer.github.com
 
 #### Get All Rate Limits
 
-##### new way
 ```php
 /** @var \Github\Api\RateLimit\RateLimitResource[] $rateLimits */
 $rateLimits = $client->api('rate_limit')->getResources();
@@ -61,14 +60,6 @@ array(4) {
 }
 ```
 
-
-##### deprecated way
-
-```php
-/** @var array $rateLimits */
-$rateLimits = $client->api('rate_limit')->getRateLimits();
-```
-
 #### Get Core Rate Limit
 
 ```php

doc/security.md

@@ -6,7 +6,8 @@ properties on Repositories and some others. Therefore this step is facultative.
 
 ### Authenticate
 
-GitHub provides some different ways of authentication. This API implementation implements three of them which are handled by one function:
+GitHub provides some different ways of authentication. This API implementation implements three of them which are
+handled by one function:
 
 ```php
 $client->authenticate($usernameOrToken, $password, $method);
@@ -15,38 +16,19 @@ $client->authenticate($usernameOrToken, $password, $method);
 `$usernameOrToken` is, of course, the username (or in some cases token/client ID, more details you can find below),
 and guess what should contain `$password`. The `$method` can contain one of the five allowed values:
 
-#### Deprecated methods
-* `Github\Client::AUTH_URL_TOKEN` use `Github\Client::AUTH_ACCESS_TOKEN` instead.
-* `Github\Client::AUTH_URL_CLIENT_ID` use `Github\Client::AUTH_CLIENT_ID` instead.
-* `Github\Client::AUTH_HTTP_TOKEN` use `Github\Client::AUTH_ACCESS_TOKEN` instead.
-* `Github\Client::AUTH_HTTP_PASSWORD` use `Github\Client::AUTH_ACCESS_TOKEN` instead.
-
 #### Supported methods
 * `Github\Client::AUTH_CLIENT_ID` - https://developer.github.com/v3/#oauth2-keysecret
 * `Github\Client::AUTH_ACCESS_TOKEN` - https://developer.github.com/v3/#oauth2-token-sent-in-a-header
 * `Github\Client::AUTH_JWT` - https://developer.github.com/apps/building-github-apps/authenticating-with-github-apps/#authenticating-as-a-github-app
 
-The required value of `$password` depends on the chosen `$method`. For `Github\Client::AUTH_URL_TOKEN`,
-`Github\Client::AUTH_HTTP_TOKEN` and `Github\Client::JWT` methods you should provide the API token in
-`$usernameOrToken` variable (`$password` is omitted in this particular case). For the
-`Github\Client::AUTH_HTTP_PASSWORD`, you should provide the password of the account. When using `Github\Client::AUTH_URL_CLIENT_ID`
-`$usernameOrToken` should contain your client ID, and `$password` should contain client secret.
-
-After executing the `$client->authenticate($usernameOrToken, $secret, $method);` method using correct credentials,
-all further requests are done as the given user.
+The required value of `$password` depends on the chosen `$method`. For `Github\Client::AUTH_ACCESS_TOKEN` and
+`Github\Client::JWT` methods you should provide the API token in `$usernameOrToken` variable (`$password` is omitted in
+this particular case).
 
-### About authentication methods
-
-The `Github\Client::AUTH_URL_TOKEN` authentication method sends the API token in URL parameters.
-The `Github\Client::AUTH_URL_CLIENT_ID` authentication method sends the client ID and secret in URL parameters.
-The `Github\Client::AUTH_HTTP_*` authentication methods send their values to GitHub using HTTP Basic Authentication.
 The `Github\Client::AUTH_JWT` authentication method sends the specified JSON Web Token in an Authorization header.
 
-`Github\Client::AUTH_URL_TOKEN` used to be the only available authentication method. To prevent existing applications
-from changing their behavior in case of an API upgrade, this method is chosen as the default for this API implementation.
-
-Note however that GitHub describes this method as deprecated. In most case you should use the
-`Github\Client::AUTH_HTTP_TOKEN` instead.
+After executing the `$client->authenticate($usernameOrToken, $secret, $method);` method using correct credentials, all
+further requests are done as the given user.
 
 ### Authenticating as an Integration
 

lib/Github/Api/Authorizations.php

@@ -13,98 +13,6 @@ class Authorizations extends AbstractApi
 {
     use AcceptHeaderTrait;
 
-    private function configurePreviewHeader()
-    {
-        $this->acceptHeaderValue = 'application/vnd.github.doctor-strange-preview+json';
-    }
-
-    /**
-     * List all authorizations.
-     *
-     * @return array
-     *
-     * @deprecated GitHub will remove this endpoint on 13th November 2020. No replacement will be offered. The "web application flow" should be used instead.
-     */
-    public function all()
-    {
-        return $this->get('/authorizations');
-    }
-
-    /**
-     * Show a single authorization.
-     *
-     * @param string $clientId
-     *
-     * @return array
-     *
-     * @deprecated GitHub will remove this endpoint on 13th November 2020. No replacement will be offered. The "web application flow" should be used instead.
-     */
-    public function show($clientId)
-    {
-        return $this->get('/authorizations/'.rawurlencode($clientId));
-    }
-
-    /**
-     * Create an authorization.
-     *
-     * @param array       $params
-     * @param string|null $OTPCode
-     *
-     * @return array
-     *
-     * @deprecated GitHub will remove this endpoint on 13th November 2020. No replacement will be offered. The "web application flow" should be used instead.
-     */
-    public function create(array $params, $OTPCode = null)
-    {
-        $headers = null === $OTPCode ? [] : ['X-GitHub-OTP' => $OTPCode];
-
-        return $this->post('/authorizations', $params, $headers);
-    }
-
-    /**
-     * Update an authorization.
-     *
-     * @param string $clientId
-     * @param array  $params
-     *
-     * @return array
-     *
-     * @deprecated GitHub will remove this endpoint on 13th November 2020. No replacement will be offered. The "web application flow" should be used instead.
-     */
-    public function update($clientId, array $params)
-    {
-        return $this->patch('/authorizations/'.rawurlencode($clientId), $params);
-    }
-
-    /**
-     * Remove an authorization.
-     *
-     * @param string $clientId
-     *
-     * @return array
-     *
-     * @deprecated GitHub will remove this endpoint on 13th November 2020. No replacement will be offered. The "web application flow" should be used instead.
-     */
-    public function remove($clientId)
-    {
-        return $this->delete('/authorizations/'.rawurlencode($clientId));
-    }
-
-    /**
-     * Check an authorization.
-     *
-     * @param string $clientId
-     * @param string $token
-     *
-     * @return array
-     *
-     * @deprecated GitHub will remove this endpoint on 1st July 2020. Use self::checkToken() instead.
-     */
-    public function check($clientId, $token)
-    {
-        return $this->get('/applications/'.rawurlencode($clientId).'/tokens/'.rawurlencode($token));
-    }
-
     /**
      * Check an application token.
      *
@@ -120,21 +28,6 @@ public function checkToken($clientId, $token = null)
         return $this->post('/applications/'.rawurlencode($clientId).'/token', $token ? ['access_token' => $token] : []);
     }
 
-    /**
-     * Reset an authorization.
-     *
-     * @param string $clientId
-     * @param string $token
-     *
-     * @return array
-     *
-     * @deprecated GitHub will remove this endpoint on 1st July 2020. Use self::resetToken() instead.
-     */
-    public function reset($clientId, $token)
-    {
-        return $this->post('/applications/'.rawurlencode($clientId).'/tokens/'.rawurlencode($token));
-    }
-
     /**
      * Reset an application token.
      *
@@ -150,31 +43,6 @@ public function resetToken($clientId, $token = null)
         return $this->patch('/applications/'.rawurlencode($clientId).'/token', $token ? ['access_token' => $token] : []);
     }
 
-    /**
-     * Remove an authorization.
-     *
-     * @param string $clientId
-     * @param string $token
-     *
-     * @deprecated GitHub will remove this endpoint on 1st July 2020. Use self::deleteToken() instead.
-     */
-    public function revoke($clientId, $token)
-    {
-        $this->delete('/applications/'.rawurlencode($clientId).'/tokens/'.rawurlencode($token));
-    }
-
-    /**
-     * Revoke all authorizations.
-     *
-     * @param string $clientId
-     *
-     * @deprecated GitHub will remove this endpoint on 1st July 2020. Use self::deleteGrant() instead.
-     */
-    public function revokeAll($clientId)
-    {
-        $this->delete('/applications/'.rawurlencode($clientId).'/tokens');
-    }
-
     /**
      * Revoke an application token.
      *

lib/Github/Api/CurrentUser.php

@@ -150,16 +150,6 @@ public function watchers()
         return new Watchers($this->client);
     }
 
-    /**
-     * @deprecated Use watchers() instead
-     */
-    public function watched($page = 1)
-    {
-        return $this->get('/user/watched', [
-            'page' => $page,
-        ]);
-    }
-
     /**
      * @return Starring
      */
@@ -168,16 +158,6 @@ public function starring()
         return new Starring($this->client);
     }
 
-    /**
-     * @deprecated Use starring() instead
-     */
-    public function starred($page = 1)
-    {
-        return $this->get('/user/starred', [
-            'page' => $page,
-        ]);
-    }
-
     /**
      *  @link https://developer.github.com/v3/activity/watching/#list-repositories-being-watched
      */

lib/Github/Api/Integrations.php

@@ -58,28 +58,6 @@ public function all($username, $repository, array $params = [])
         return $this->get('/repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/issues', array_merge(['page' => 1], $params));
     }
 
-    /**
-     * Search issues by username, repo, state and keyword.
-     *
-     * @deprecated This method is deprecated use the Search api instead. See https://developer.github.com/v3/search/legacy/#legacy-search-api-is-deprecated
-     * @link http://developer.github.com/v3/search/#search-issues
-     *
-     * @param string $username   the username
-     * @param string $repository the repository
-     * @param string $state      the issue state, can be open or closed
-     * @param string $keyword    the keyword to filter issues by
-     *
-     * @return array list of issues found
-     */
-    public function find($username, $repository, $state, $keyword)
-    {
-        if (!in_array($state, ['open', 'closed'])) {
-            $state = 'open';
-        }
-
-        return $this->get('/legacy/issues/search/'.rawurlencode($username).'/'.rawurlencode($repository).'/'.rawurlencode($state).'/'.rawurlencode($keyword));
-    }
-
     /**
      * List issues by organization.
      *

lib/Github/Api/Issue.php

@@ -3,6 +3,7 @@
 namespace Github\Api\Issue;
 
 use Github\Api\AbstractApi;
+use Github\Exception\InvalidArgumentException;
 use Github\Exception\MissingArgumentException;
 
 class Assignees extends AbstractApi
@@ -47,6 +48,7 @@ public function check($username, $repository, $assignee)
      * @param string $issue
      * @param array  $parameters
      *
+     * @throws InvalidArgumentException
      * @throws MissingArgumentException
      *
      * @return string
@@ -58,9 +60,7 @@ public function add($username, $repository, $issue, array $parameters)
         }
 
         if (!is_array($parameters['assignees'])) {
-            @trigger_error(sprintf('Passing the "assignees" parameter as a string in "%s" is deprecated and will throw an exception in php-github-api version 3.0. Pass an array of strings instead', __METHOD__), E_USER_DEPRECATED);
-
-            $parameters['assignees'] = [$parameters['assignees']];
+            throw new InvalidArgumentException('The assignees parameter should be an array of assignees');
         }
 
         return $this->post('/repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/issues/'.rawurlencode($issue).'/assignees', $parameters);

lib/Github/Api/Issue/Assignees.php

@@ -41,25 +41,16 @@ public function configure($bodyType = null)
      *
      * @link https://developer.github.com/v3/issues/comments/#list-comments-on-an-issue
      *
-     * @param string    $username
-     * @param string    $repository
-     * @param int       $issue
-     * @param int|array $page       Passing integer is deprecated and will throw an exception in php-github-api version 3.0. Pass an array instead.
+     * @param string $username
+     * @param string $repository
+     * @param int    $issue
+     * @param array  $params
      *
      * @return array
      */
-    public function all($username, $repository, $issue, $page = 1)
+    public function all($username, $repository, $issue, array $params = [])
     {
-        if (is_array($page)) {
-            $parameters = $page;
-        } else {
-            @trigger_error(sprintf('Passing integer to the "page" argument in "%s" is deprecated and will throw an exception in php-github-api version 3.0. Pass an array instead.', __METHOD__), E_USER_DEPRECATED);
-            $parameters = [
-                'page' => $page,
-            ];
-        }
-
-        return $this->get('/repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/issues/'.$issue.'/comments', $parameters);
+        return $this->get('/repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/issues/'.$issue.'/comments', $params);
     }
 
     /**