Skip to content

Commit cbf08fc

Browse files
committed
Removed validation of parameters
removed MissingArgumentException
1 parent 289c0ab commit cbf08fc

File tree

2 files changed

+0
-24
lines changed

2 files changed

+0
-24
lines changed

lib/Github/Api/Environment/Secrets.php

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
namespace Github\Api\Environment;
44

55
use Github\Api\AbstractApi;
6-
use Github\Exception\MissingArgumentException;
76

87
/**
98
* @link https://docs.github.com/en/rest/actions/secrets?apiVersion=2022-11-28
@@ -45,20 +44,10 @@ public function show(int $id, string $name, string $secretName)
4544
* @param string $secretName
4645
* @param array $parameters
4746
*
48-
* @throws MissingArgumentException
49-
*
5047
* @return array|string
5148
*/
5249
public function createOrUpdate(int $id, string $name, string $secretName, array $parameters = [])
5350
{
54-
if (!isset($parameters['encrypted_value'])) {
55-
throw new MissingArgumentException(['encrypted_value']);
56-
}
57-
58-
if (!isset($parameters['key_id'])) {
59-
throw new MissingArgumentException(['key_id']);
60-
}
61-
6251
return $this->put('/repositories/'.$id.'/environments/'.rawurlencode($name).'/secrets/'.rawurlencode($secretName), $parameters);
6352
}
6453

lib/Github/Api/Environment/Variables.php

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
namespace Github\Api\Environment;
44

55
use Github\Api\AbstractApi;
6-
use Github\Exception\MissingArgumentException;
76

87
/**
98
* @link https://docs.github.com/en/rest/actions/variables?apiVersion=2022-11-28
@@ -44,20 +43,10 @@ public function show(int $id, string $name, string $variableName)
4443
* @param string $name
4544
* @param array $parameters
4645
*
47-
* @throws MissingArgumentException
48-
*
4946
* @return array|string
5047
*/
5148
public function create(int $id, string $name, array $parameters)
5249
{
53-
if (!isset($parameters['name'])) {
54-
throw new MissingArgumentException(['name']);
55-
}
56-
57-
if (!isset($parameters['value'])) {
58-
throw new MissingArgumentException(['value']);
59-
}
60-
6150
return $this->post('/repositories/'.$id.'/environments/'.rawurlencode($name).'/variables', $parameters);
6251
}
6352

@@ -69,8 +58,6 @@ public function create(int $id, string $name, array $parameters)
6958
* @param string $variableName
7059
* @param array $parameters
7160
*
72-
* @throws MissingArgumentException
73-
*
7461
* @return array|string
7562
*/
7663
public function update(int $id, string $name, string $variableName, array $parameters)

0 commit comments

Comments
 (0)