Fix (almost) all PHPStan errors

Author: WyriHaximus

phpstan.neon

@@ -1,4 +1,8 @@
 parameters:
+	ignoreErrors:
+		- '#Default value of the parameter \#3 $timeout \(60\) of method WyriHaximus\AsyncTestUtilities\AsyncTestCase::await\(\) is incompatible with type float\|null.#'
+		- '#Method [a-zA-Z0-9\\_]+::[a-zA-Z0-9_]+\(\) has parameter \$[a-zA-Z0-9_]+ with a nullable type declaration.#'
+		- '#Method [a-zA-Z0-9\\_]+::[a-zA-Z0-9_]+\(\) has parameter \$[a-zA-Z0-9_]+ with null as default value.#'
 	classesAllowedToBeExtended:
 		- WyriHaximus\AsyncTestUtilities\AsyncTestCase
 

src/AsyncTestCase.php

@@ -17,9 +17,10 @@ abstract class AsyncTestCase extends TestCase
     /**
      * @param  PromiseInterface   $promise
      * @param  LoopInterface|null $loop
+     * @param  float|null         $timeout
      * @return mixed
      */
-    protected function await(PromiseInterface $promise, LoopInterface $loop = null, float $timeout = self::DEFAULT_AWAIT_TIMEOUT)
+    protected function await(PromiseInterface $promise, ?LoopInterface $loop = null, ?float $timeout = self::DEFAULT_AWAIT_TIMEOUT)
     {
         if (!($loop instanceof LoopInterface)) {
             $loop = Factory::create();
@@ -31,9 +32,10 @@ protected function await(PromiseInterface $promise, LoopInterface $loop = null,
     /**
      * @param  array              $promises
      * @param  LoopInterface|null $loop
+     * @param  float|null         $timeout
      * @return array
      */
-    protected function awaitAll(array $promises, LoopInterface $loop = null, float $timeout = self::DEFAULT_AWAIT_TIMEOUT)
+    protected function awaitAll(array $promises, ?LoopInterface $loop = null, ?float $timeout = self::DEFAULT_AWAIT_TIMEOUT): array
     {
         if (!($loop instanceof LoopInterface)) {
             $loop = Factory::create();
@@ -45,9 +47,10 @@ protected function awaitAll(array $promises, LoopInterface $loop = null, float $
     /**
      * @param  array              $promises
      * @param  LoopInterface|null $loop
+     * @param  float|null         $timeout
      * @return mixed
      */
-    protected function awaitAny(array $promises, LoopInterface $loop = null, float $timeout = self::DEFAULT_AWAIT_TIMEOUT)
+    protected function awaitAny(array $promises, ?LoopInterface $loop = null, ?float $timeout = self::DEFAULT_AWAIT_TIMEOUT)
     {
         if (!($loop instanceof LoopInterface)) {
             $loop = Factory::create();

tests/AsyncTestCaseTest.php

@@ -12,17 +12,7 @@
 
 final class AsyncTestCaseTest extends AsyncTestCase
 {
-    protected function setUp(): void
-    {
-        parent::setUp();
-    }
-
-    protected function tearDown(): void
-    {
-        parent::tearDown();
-    }
-
-    public function provideEventLoop()
+    public function provideEventLoop(): iterable
     {
         yield [null];
         yield [Factory::create()];
@@ -32,7 +22,7 @@ public function provideEventLoop()
     /**
      * @dataProvider provideEventLoop
      */
-    public function testAwait(LoopInterface $loop = null)
+    public function testAwait(?LoopInterface $loop): void
     {
         $value = time();
         static::assertSame($value, $this->await(resolve($value), $loop));
@@ -41,7 +31,7 @@ public function testAwait(LoopInterface $loop = null)
     /**
      * @dataProvider provideEventLoop
      */
-    public function testAwaitAll(LoopInterface $loop = null)
+    public function testAwaitAll(?LoopInterface $loop): void
     {
         $value = time();
         static::assertSame([$value, $value], $this->awaitAll([resolve($value), resolve($value)], $loop));
@@ -50,7 +40,7 @@ public function testAwaitAll(LoopInterface $loop = null)
     /**
      * @dataProvider provideEventLoop
      */
-    public function testAwaitAny(LoopInterface $loop = null)
+    public function testAwaitAny(?LoopInterface $loop): void
     {
         $value = time();
         static::assertSame($value, $this->awaitAny([resolve($value), resolve($value)], $loop));
@@ -59,7 +49,7 @@ public function testAwaitAny(LoopInterface $loop = null)
     /**
      * @dataProvider provideEventLoop
      */
-    public function testAwaitTimeout(LoopInterface $loop = null)
+    public function testAwaitTimeout(?LoopInterface $loop): void
     {
         self::expectException(TimeoutException::class);