Skip to content

Commit ac88d68

Browse files
committed
Use same argument names in overwritten methods
1 parent ffb017b commit ac88d68

File tree

1 file changed

+20
-20
lines changed

1 file changed

+20
-20
lines changed

webware/WebUtils/HTMLTag.py

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -544,18 +544,18 @@ def handle_pi(self, data):
544544
raise HTMLTagProcessingInstructionError(
545545
f'Was not expecting a processing instruction: {data!r}')
546546

547-
def handle_starttag(self, name, attrs): # pylint: disable=arguments-differ
547+
def handle_starttag(self, tag, attrs):
548548
if self._finished:
549549
return
550-
tag = HTMLTag(name, lineNumber=self._lineNumber)
550+
htmlTag = HTMLTag(tag, lineNumber=self._lineNumber)
551551
for attrName, value in attrs:
552-
tag.readAttr(attrName, value)
553-
if name in self._emptyTagSet:
552+
htmlTag.readAttr(attrName, value)
553+
if tag in self._emptyTagSet:
554554
# We'll never have any children. Boo hoo.
555555
if not self._rootTag:
556556
raise HTMLTagError(
557-
f'Cannot start HTML with an empty tag: {tag!r}')
558-
self._tagStack[-1].addChild(tag)
557+
f'Cannot start HTML with an empty tag: {htmlTag!r}')
558+
self._tagStack[-1].addChild(htmlTag)
559559
empty = True
560560
else:
561561
# We could have children, so we go on the stack
@@ -567,37 +567,37 @@ def handle_starttag(self, name, attrs): # pylint: disable=arguments-differ
567567
# is this legal?
568568
tagConfig = self._tagContainmentConfig.get(lastTag.name())
569569
if tagConfig:
570-
tagConfig.encounteredTag(name, self._lineNumber)
570+
tagConfig.encounteredTag(tag, self._lineNumber)
571571
# tell last tag about his new child
572-
lastTag.addChild(tag)
573-
elif name != 'html' and self._fakeRootTagIfNeeded:
572+
lastTag.addChild(htmlTag)
573+
elif tag != 'html' and self._fakeRootTagIfNeeded:
574574
self._rootTag = HTMLTag('html')
575575
self._tagStack.append(self._rootTag)
576-
self._tagStack[-1].addChild(tag)
576+
self._tagStack[-1].addChild(htmlTag)
577577
self._usedFakeRootTag = True
578578
else:
579-
self._rootTag = tag
580-
self._tagStack.append(tag)
579+
self._rootTag = htmlTag
580+
self._tagStack.append(htmlTag)
581581
empty = False
582582
if self._printsStack:
583583
prefix = ('START', '-----')[empty]
584-
print(f'{prefix} {name.ljust(6)}: {self._tagStack!r}')
584+
print(f'{prefix} {tag.ljust(6)}: {self._tagStack!r}')
585585

586-
def handle_endtag(self, name): # pylint: disable=arguments-differ
586+
def handle_endtag(self, tag):
587587
if self._finished:
588588
return
589-
if name == self._endingTag:
589+
if tag == self._endingTag:
590590
self._finished = True
591591
openingTag = self._tagStack.pop()
592592
if self._printsStack:
593-
print(f'END {name.ljust(6)}: {self._tagStack}')
594-
if openingTag.name() != name:
593+
print(f'END {tag.ljust(6)}: {self._tagStack}')
594+
if openingTag.name() != tag:
595595
raise HTMLTagUnbalancedError(
596596
f'line {self._lineNumber}:'
597-
f' opening is {openingTag}, but closing is <{name}>.',
597+
f' opening is {openingTag}, but closing is <{tag}>.',
598598
line=self._lineNumber, opening=openingTag.name(),
599-
closing=name, tagStack=self._tagStack)
600-
openingTag.closedBy(name, self._lineNumber)
599+
closing=tag, tagStack=self._tagStack)
600+
openingTag.closedBy(tag, self._lineNumber)
601601

602602
def close(self):
603603
stackSize = len(self._tagStack)

0 commit comments

Comments
 (0)