✨ Add more rules

Author: VincentLanglet

SymfonyCustom/Sniffs/WhiteSpace/CloseBracketSpacingSniff.php

@@ -22,6 +22,7 @@ public function register()
         return [
             T_CLOSE_CURLY_BRACKET,
             T_CLOSE_PARENTHESIS,
+            T_CLOSE_SHORT_ARRAY,
         ];
     }
 

SymfonyCustom/Sniffs/WhiteSpace/OpenBracketSpacingSniff.php

@@ -21,6 +21,7 @@ public function register()
         return [
             T_OPEN_CURLY_BRACKET,
             T_OPEN_PARENTHESIS,
+            T_OPEN_SHORT_ARRAY,
         ];
     }
 

SymfonyCustom/Tests/WhiteSpace/CloseBracketSpacingUnitTest.inc

@@ -5,3 +5,5 @@ testFunction( args1, args2 );
 function f( ) { };
 
 $array = array( 1, 2 );
+
+$array = [ 1, 2 ];

SymfonyCustom/Tests/WhiteSpace/CloseBracketSpacingUnitTest.inc.fixed

@@ -5,3 +5,5 @@ testFunction( args1, args2);
 function f() {};
 
 $array = array( 1, 2);
+
+$array = [ 1, 2];

SymfonyCustom/Tests/WhiteSpace/CloseBracketSpacingUnitTest.php

@@ -25,6 +25,7 @@ public function getErrorList()
             3 => 1,
             5 => 2,
             7 => 1,
+            9 => 1,
         ];
     }
 

SymfonyCustom/Tests/WhiteSpace/OpenBracketSpacingUnitTest.inc

@@ -5,3 +5,5 @@ testFunction( args1, args2 );
 function f( ) { };
 
 $array = array( 1, 2 );
+
+$array = [ 1, 2 ];

SymfonyCustom/Tests/WhiteSpace/OpenBracketSpacingUnitTest.inc.fixed

@@ -5,3 +5,5 @@ testFunction(args1, args2 );
 function f() {};
 
 $array = array(1, 2 );
+
+$array = [1, 2 ];

SymfonyCustom/Tests/WhiteSpace/OpenBracketSpacingUnitTest.php

@@ -25,6 +25,7 @@ public function getErrorList()
             3 => 1,
             5 => 2,
             7 => 1,
+            9 => 1,
         ];
     }
 

SymfonyCustom/ruleset.xml

@@ -81,9 +81,20 @@
             <property name="ignoreNewlines" value="true"/>
         </properties>
     </rule>
+    <rule ref="Squiz.WhiteSpace.ObjectOperatorSpacing">
+        <properties>
+            <property name="ignoreNewlines" value="true"/>
+        </properties>
+    </rule>
     <rule ref="Squiz.WhiteSpace.SemicolonSpacing"/>
     <rule ref="Generic.Arrays.DisallowLongArraySyntax"/>
     <rule ref="Generic.CodeAnalysis.EmptyPHPStatement"/>
     <rule ref="Squiz.WhiteSpace.LogicalOperatorSpacing"/>
     <rule ref="Squiz.WhiteSpace.CastSpacing"/>
+    <rule ref="Squiz.WhiteSpace.ObjectOperatorSpacing"/>
+    <rule ref="Generic.Strings.UnnecessaryStringConcat">
+        <properties>
+            <property name="allowMultiline" value="true"/>
+        </properties>
+    </rule>
 </ruleset>

docs/standards.md

@@ -122,20 +122,40 @@ we do not respect this rule:
 <rule ref="Generic.CodeAnalysis.EmptyPHPStatement"/>
 ```
 
-- Add a single space before and after logical operator
+- Add a single space around logical operator (`&&`, `||`, `...`)
 
 ```
 <rule ref="Squiz.WhiteSpace.LogicalOperatorSpacing"/>
 ```
 
+- Do not use space around object operators (`->`)
+
+```
+<rule ref="Squiz.WhiteSpace.ObjectOperatorSpacing">
+    <properties>
+        <property name="ignoreNewlines" value="true"/>
+    </properties>
+</rule>
+```
+
+- Do not use unnecessary concat operator
+
+```
+<rule ref="Generic.Strings.UnnecessaryStringConcat">
+    <properties>
+        <property name="allowMultiline" value="true"/>
+    </properties>
+</rule>
+```
+
 ### Custom
 - Some others checks are made about array (`=>` alignments and indentation)
 
 ```
 <rule ref="SymfonyCustom.Array.ArrayDeclaration"/>
 ```
 
-- Do not use spaces after `(` or `{` and before `)` or `}`
+- Do not use spaces after `(`, `{` or `[` and before `)`, `}` or `]`
 
 ```
 <rule ref="SymfonyCustom.WhiteSpace.CloseBracketSpacing"/>

docs/standards/symfony.md

@@ -12,7 +12,12 @@ From [symfony standard](http://symfony.com/doc/current/contributing/code/standar
  with the exception of the concatenation (`.`) operator
 
 ```
-<rule ref="Squiz.WhiteSpace.OperatorSpacing"/>
+<rule ref="Squiz.WhiteSpace.LogicalOperatorSpacing"/>
+<rule ref="Squiz.WhiteSpace.OperatorSpacing">
+    <properties>
+        <property name="ignoreNewlines" value="true"/>
+    </properties>
+</rule>
 <rule ref="Squiz.Strings.ConcatenationSpacing">
     <properties>
         <property name="ignoreNewlines" value="true"/>