Skip to content

Commit 464981a

Browse files
Merge pull request #89 from VincentLanglet/fixUnused
🐛 Fix false unused
2 parents aeda1b6 + 1412524 commit 464981a

File tree

3 files changed

+29
-1
lines changed

3 files changed

+29
-1
lines changed

SymfonyCustom/Sniffs/Namespaces/UnusedUseSniff.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,7 @@ private function isClassUsed(File $phpcsFile, int $usePtr, int $classPtr): bool
311311
|| ('class' === $type
312312
&& ((T_DOC_COMMENT_STRING === $tokens[$classUsed]['code']
313313
&& preg_match(
314-
'/(\s|\||\(|^)'.preg_quote($searchName, '/').'(\s|\||\\\\|$|\[\])/i',
314+
'/(\s|\||\(|^)'.preg_quote($searchName, '/').'(\s|\||\\\\|<|$|\[\])/i',
315315
$tokens[$classUsed]['content']
316316
))
317317
|| (T_DOC_COMMENT_TAG === $tokens[$classUsed]['code']

SymfonyCustom/Tests/Namespaces/UnusedUseUnitTest.inc

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -131,3 +131,17 @@ use /* comment */DateTime;
131131
new MyClass1();
132132
new MyClass2();
133133
new MyClass3();
134+
135+
namespace BugCollection;
136+
137+
use Doctrine\Collection;
138+
139+
/**
140+
* @param Collection<int, \Client> $a
141+
*
142+
* @return null
143+
*/
144+
function ($a)
145+
{
146+
return null;
147+
}

SymfonyCustom/Tests/Namespaces/UnusedUseUnitTest.inc.fixed

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,3 +118,17 @@ use \Hello\MyClass2;
118118
new MyClass1();
119119
new MyClass2();
120120
new MyClass3();
121+
122+
namespace BugCollection;
123+
124+
use Doctrine\Collection;
125+
126+
/**
127+
* @param Collection<int, \Client> $a
128+
*
129+
* @return null
130+
*/
131+
function ($a)
132+
{
133+
return null;
134+
}

0 commit comments

Comments
 (0)