Merge pull request #102 from VincentLanglet/uselessCheck

💄 Remove duplicate check

Author: VincentLanglet

SymfonyCustom/Sniffs/Arrays/ArrayDeclarationSniff.php

@@ -36,20 +36,6 @@ public function process(File $phpcsFile, $stackPtr): void
         $tokens = $phpcsFile->getTokens();
 
         if (T_ARRAY === $tokens[$stackPtr]['code']) {
-            // Array keyword should be lower case.
-            if (strtolower($tokens[$stackPtr]['content']) !== $tokens[$stackPtr]['content']) {
-                $fix = $phpcsFile->addFixableError(
-                    'Array keyword should be lower case; expected "array" but found "%s"',
-                    $stackPtr,
-                    'NotLowerCase',
-                    [$tokens[$stackPtr]['content']]
-                );
-
-                if ($fix) {
-                    $phpcsFile->fixer->replaceToken($stackPtr, 'array');
-                }
-            }
-
             $arrayStart = $tokens[$stackPtr]['parenthesis_opener'];
             if (!isset($tokens[$arrayStart]['parenthesis_closer'])) {
                 return;

SymfonyCustom/Tests/Arrays/ArrayDeclarationUnitTest.inc.fixed

@@ -4,9 +4,9 @@ function test()
 {
     $a = array();
 
-    $b = array();
+    $b = Array();
 
-    $c = array(
+    $c = Array(
         'a' => 1,
     );
 }
@@ -19,7 +19,7 @@ class TestClass
         'height' => '',
     );
 
-    private $_bad = array(
+    private $_bad = Array(
         'width'  => '',
         'height' => '',
     );
@@ -32,7 +32,7 @@ class TestClass
             'height' => '',
         );
 
-        $plane = array(
+        $plane = Array(
             'width'  => '',
             'height' => '',
         );
@@ -55,15 +55,15 @@ class TestClass
 
         $inline = array('aaa', 'bbb', 'ccc');
         $inline = array('aaa');
-        $inline = array('aaa');
+        $inline = Array('aaa');
 
         $bigone = array(
             'name'       => 'bigone',
-            'children'   => array(
+            'children'   => Array(
                 '1a'       => 'child',
                 '11b'      => 'child',
                 '111c'     => 'child',
-                'children' => array(
+                'children' => Array(
                     'child' => 'aaa',
                 ),
             ),

SymfonyCustom/Tests/Arrays/ArrayDeclarationUnitTest.php

@@ -19,28 +19,23 @@ class ArrayDeclarationUnitTest extends AbstractSniffUnitTest
     protected function getErrorList(): array
     {
         return [
-            7   => 2,
-            9   => 1,
-            22  => 1,
+            7   => 1,
             23  => 1,
             24  => 2,
             25  => 1,
             31  => 1,
-            35  => 1,
             36  => 1,
             41  => 1,
             46  => 1,
             47  => 1,
             50  => 1,
             51  => 1,
             53  => 1,
-            58  => 1,
             61  => 1,
-            62  => 1,
             63  => 1,
             64  => 1,
             65  => 1,
-            66  => 2,
+            66  => 1,
             67  => 1,
             68  => 1,
             70  => 1,