From a7943ee38e4c2e62848e9d2195fffc7cdd7214fe Mon Sep 17 00:00:00 2001 From: Olga Naumenko <64418523+olganaumenko@users.noreply.github.com> Date: Wed, 30 Nov 2022 13:01:30 +0300 Subject: [PATCH 1/3] Unit testing requirement added --- .github/pull_request_template.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 2590811bdd..66b65ac482 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -16,6 +16,11 @@ Please delete options that are not relevant. # How Has This Been Tested? +## Unit tests + +You _must_ provide unit tests for the proposed code changes. If you don't do that, your reviewer will reject your PR +unless you clearly explain why it is impossible to submit unit tests in your case. + ## Automated Testing Specify tests that help to verify the change automatically. From d14b096bd6d0402119874b71f59f1719dd45e052 Mon Sep 17 00:00:00 2001 From: Olga Naumenko <64418523+olganaumenko@users.noreply.github.com> Date: Wed, 30 Nov 2022 14:07:32 +0300 Subject: [PATCH 2/3] Wording updated --- .github/pull_request_template.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 66b65ac482..9b5b88378e 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -18,8 +18,7 @@ Please delete options that are not relevant. ## Unit tests -You _must_ provide unit tests for the proposed code changes. If you don't do that, your reviewer will reject your PR -unless you clearly explain why it is impossible to submit unit tests in your case. +Please, provide regression or integration tests for your code changes. If you don't do that, the reviewer can and highly likely **_will reject_** the PR. It is the contributor's responsibility to provide such tests or to reason why they are missing. ## Automated Testing From 63fcbe61d679b29973773b66d09252eaa0b72cc7 Mon Sep 17 00:00:00 2001 From: Olga Naumenko <64418523+olganaumenko@users.noreply.github.com> Date: Wed, 30 Nov 2022 14:20:24 +0300 Subject: [PATCH 3/3] Headline updated --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 9b5b88378e..2e7f48e853 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -16,7 +16,7 @@ Please delete options that are not relevant. # How Has This Been Tested? -## Unit tests +## Regression and integration tests Please, provide regression or integration tests for your code changes. If you don't do that, the reviewer can and highly likely **_will reject_** the PR. It is the contributor's responsibility to provide such tests or to reason why they are missing.