Fix various problems with fuzzing in ContestEstimator

Author: Markoutte

utbot-framework-api/src/main/kotlin/org/utbot/framework/plugin/api/Api.kt

@@ -880,6 +880,8 @@ val Type.classId: ClassId
         else -> error("Unknown type $this")
     }
 
+private val logger = KotlinLogging.logger {}
+
 /**
  * Class id. Contains name, not a full qualified name.
  *
@@ -904,7 +906,9 @@ open class ClassId @JvmOverloads constructor(
         get() = jClass.modifiers
 
     open val canonicalName: String
-        get() = jClass.canonicalName ?: error("ClassId $name does not have canonical name")
+        get() = jClass.canonicalName ?: name.also {
+            logger.error("ClassId $name does not have canonical name")
+        }
 
     open val simpleName: String get() = jClass.simpleName
 

utbot-fuzzing/src/main/kotlin/org/utbot/fuzzing/Api.kt

@@ -7,6 +7,7 @@ import org.utbot.fuzzing.seeds.KnownValue
 import org.utbot.fuzzing.utils.MissedSeed
 import org.utbot.fuzzing.utils.chooseOne
 import org.utbot.fuzzing.utils.flipCoin
+import org.utbot.fuzzing.utils.transformIfNotEmpty
 import kotlin.random.Random
 
 private val logger by lazy { KotlinLogging.logger {} }
@@ -515,11 +516,11 @@ private fun <TYPE, RESULT, DESCRIPTION : Description<TYPE>, FEEDBACK : Feedback<
                 }
             ),
             modify = task.modify
-//                .toMutableList()
-//                .transformIfNotEmpty {
-//                    shuffle(random)
-//                    take(random.nextInt(size + 1))
-//                }
+                .toMutableList()
+                .transformIfNotEmpty {
+                    shuffle(random)
+                    take(configuration.maxNumberOfRecursiveSeedModifications)
+                }
                 .mapTo(arrayListOf()) { routine ->
                     fuzz(
                         routine.types,

utbot-java-fuzzing/src/main/kotlin/org/utbot/fuzzing/JavaLanguage.kt

@@ -44,7 +44,7 @@ fun defaultValueProviders(idGenerator: IdentityPreservingIdGenerator<Int>) = lis
     StringValueProvider,
     NumberValueProvider,
     ObjectValueProvider(idGenerator).letIf(UtSettings.fuzzObjectWhenTheyCannotBeCreatedClean) { ovp ->
-        ovp.withFallback(CreateObjectAnywayValueProvider(idGenerator, useMock = true))
+        ovp.withFallback(CreateObjectAnywayValueProvider(idGenerator, useMock = false))
     },
     ArrayValueProvider(idGenerator),
     EnumValueProvider(idGenerator),

utbot-java-fuzzing/src/main/kotlin/org/utbot/fuzzing/providers/Objects.kt

@@ -134,7 +134,7 @@ object NullValueProvider : ValueProvider<FuzzedType, FuzzedValue, FuzzedDescript
 
 class CreateObjectAnywayValueProvider(
     val idGenerator: IdGenerator<Int>,
-    val useMock: Boolean = true,
+    val useMock: Boolean = false,
 ) : ValueProvider<FuzzedType, FuzzedValue, FuzzedDescription> {
 
     override fun accept(type: FuzzedType) = type.classId.isRefType