Fix: review comments

Author: sergeypospelov

utbot-framework-test/src/main/java/org/utbot/examples/strings/StringConcat.java

@@ -4,7 +4,7 @@
 
 
 public class StringConcat {
-    static class Test {
+    public static class Test {
         public int x;
 
         @Override

utbot-framework/src/main/kotlin/org/utbot/engine/ConstructedSootMethods.kt

@@ -223,17 +223,15 @@ fun makeSootConcat(declaringClass: SootClass, recipe: String, paramTypes: List<T
     var constantPointer = 0 // pointer to constant list
     var delayedString = "" // string which is build of sequent values from [constants]
 
+    val appendStringSootMethod = sbSootClass.getMethod("append", listOf(STRING_TYPE), sbSootClass.type)
+
     // helper function for appending constants to delayedString
     fun appendDelayedStringIfNotEmpty() {
         if (delayedString.isEmpty()) {
             return
         }
 
-        val type = STRING_TYPE
-
-        val appendSootMethod = sbSootClass.getMethod("append", listOf(type), sbSootClass.type)
-
-        val invokeStringBuilderAppendStmt = appendSootMethod.toVirtualInvokeExpr(sb, StringConstant.v(delayedString))
+        val invokeStringBuilderAppendStmt = appendStringSootMethod.toVirtualInvokeExpr(sb, StringConstant.v(delayedString))
         units += invokeStringBuilderAppendStmt.toInvokeStmt()
 
         delayedString = ""
@@ -258,11 +256,8 @@ fun makeSootConcat(declaringClass: SootClass, recipe: String, paramTypes: List<T
                 appendDelayedStringIfNotEmpty()
 
                 val const = constants[constantPointer++]
-                val type = STRING_TYPE
-
-                val appendSootMethod = sbSootClass.getMethod("append", listOf(type), sbSootClass.type)
 
-                val stringBuilderAppendExpr = appendSootMethod.toVirtualInvokeExpr(sb, StringConstant.v(const))
+                val stringBuilderAppendExpr = appendStringSootMethod.toVirtualInvokeExpr(sb, StringConstant.v(const))
                 units += stringBuilderAppendExpr.toInvokeStmt()
             }
             else -> {

utbot-framework/src/main/kotlin/org/utbot/engine/DynamicInvokeResolver.kt

@@ -100,12 +100,12 @@ object StringMakeConcatResolver : DynamicInvokeResolver {
         )
 
         val invocationTarget = InvocationTarget(
-            null,
+            instance = null,
             sootMethod
         )
 
         return Invocation(
-            null,
+            instance = null,
             sootMethod,
             parameters,
             invocationTarget

utbot-framework/src/main/kotlin/org/utbot/engine/JimpleCreation.kt

@@ -74,7 +74,7 @@ fun createSootMethod(
     declaringClass: SootClass,
     graphBody: JimpleBody,
     isStatic: Boolean = true
-) = SootMethod(name, argsTypes, returnType, (if (isStatic) Modifier.STATIC else 0))
+) = SootMethod(name, argsTypes, returnType, if (isStatic) Modifier.STATIC else 0)
     .also {
         declaringClass.addMethod(it)
         it.activeBody = graphBody