Replace Kotlin getters/setters with property access in codegen

Author: volivan239

utbot-framework-api/src/main/kotlin/org/utbot/framework/plugin/api/util/IdUtil.kt

@@ -387,6 +387,12 @@ fun ClassId.defaultValueModel(): UtModel = when (this) {
     else -> UtNullModel(this)
 }
 
+val ClassId.allDeclaredFieldIds: Sequence<FieldId>
+    get() =
+        generateSequence(this.jClass) { it.superclass }
+            .flatMap { it.declaredFields.asSequence() }
+            .map { it.fieldId }
+
 // FieldId utils
 val FieldId.safeJField: Field?
     get() = declaringClass.jClass.declaredFields.firstOrNull { it.name == name }

utbot-framework/src/main/kotlin/org/utbot/framework/codegen/model/constructor/tree/CgCallableAccessManager.kt

@@ -293,7 +293,7 @@ internal class CgCallableAccessManagerImpl(val context: CgContext) : CgCallableA
 
     private fun FieldId.accessSuitability(accessor: CgExpression?): FieldAccessorSuitability {
         // Check field accessibility.
-        if (!isAccessibleFrom(testClassPackageName)) {
+        if (!isAccessibleFrom(context)) {
             return ReflectionOnly
         }
 

utbot-framework/src/main/kotlin/org/utbot/framework/codegen/model/constructor/tree/CgFieldStateManager.kt

@@ -182,7 +182,7 @@ internal class CgFieldStateManagerImpl(val context: CgContext)
         for ((index, fieldPathElement) in path.withIndex()) {
             when (fieldPathElement) {
                 is FieldAccess -> {
-                    if (!fieldPathElement.field.isAccessibleFrom(testClassPackageName)) {
+                    if (!fieldPathElement.field.isAccessibleFrom(context)) {
                         lastAccessibleIndex = index - 1
                         break
                     }
@@ -246,7 +246,7 @@ internal class CgFieldStateManagerImpl(val context: CgContext)
 
     private fun variableForStaticFieldState(owner: ClassId, fieldPath: FieldPath, customName: String?): CgVariable {
         val firstField = (fieldPath.elements.first() as FieldAccess).field
-        val firstAccessor = if (owner.isAccessibleFrom(testClassPackageName) && firstField.isAccessibleFrom(testClassPackageName)) {
+        val firstAccessor = if (owner.isAccessibleFrom(testClassPackageName) && firstField.isAccessibleFrom(context)) {
             owner[firstField]
         } else {
             // TODO: there is a function getClassOf() for these purposes, but it is not accessible from here for now

utbot-framework/src/main/kotlin/org/utbot/framework/codegen/model/constructor/tree/CgMethodConstructor.kt

@@ -218,7 +218,7 @@ internal class CgMethodConstructor(val context: CgContext) : CgContextOwner by c
         val accessibleStaticFields = statics.accessibleFields()
         for ((field, _) in accessibleStaticFields) {
             val declaringClass = field.declaringClass
-            val fieldAccessible = field.isAccessibleFrom(testClassPackageName)
+            val fieldAccessible = field.isAccessibleFrom(context)
 
             // prevValue is nullable if not accessible because of getStaticFieldValue(..) : Any?
             val prevValue = newVar(
@@ -243,7 +243,7 @@ internal class CgMethodConstructor(val context: CgContext) : CgContextOwner by c
         val accessibleStaticFields = statics.accessibleFields()
         for ((field, model) in accessibleStaticFields) {
             val declaringClass = field.declaringClass
-            val fieldAccessible = field.canBeSetIn(testClassPackageName)
+            val fieldAccessible = field.canBeSetIn(context)
 
             val fieldValue = if (isParametrized) {
                 currentMethodParameters[CgParameterKind.Statics(model)]
@@ -264,7 +264,7 @@ internal class CgMethodConstructor(val context: CgContext) : CgContextOwner by c
 
     private fun recoverStaticFields() {
         for ((field, prevValue) in prevStaticFieldValues.accessibleFields()) {
-            if (field.canBeSetIn(testClassPackageName)) {
+            if (field.canBeSetIn(context)) {
                 field.declaringClass[field] `=` prevValue
             } else {
                 val declaringClass = getClassOf(field.declaringClass)
@@ -1039,7 +1039,7 @@ internal class CgMethodConstructor(val context: CgContext) : CgContextOwner by c
     private fun FieldId.getAccessExpression(variable: CgVariable): CgExpression =
         // Can directly access field only if it is declared in variable class (or in its ancestors)
         // and is accessible from current package
-        if (variable.type.hasField(this) && isAccessibleFrom(testClassPackageName)) {
+        if (variable.type.hasField(this) && isAccessibleFrom(context)) {
             if (jField.isStatic) CgStaticFieldAccess(this) else CgFieldAccess(variable, this)
         } else {
             utilsClassId[getFieldValue](variable, this.declaringClass.name, this.name)

utbot-framework/src/main/kotlin/org/utbot/framework/codegen/model/constructor/tree/CgVariableConstructor.kt

@@ -14,6 +14,7 @@ import org.utbot.framework.codegen.model.constructor.util.isDefaultValueOf
 import org.utbot.framework.codegen.model.constructor.util.isNotDefaultValueOf
 import org.utbot.framework.codegen.model.constructor.util.typeCast
 import org.utbot.framework.codegen.model.tree.CgAllocateArray
+import org.utbot.framework.codegen.model.tree.CgAssignment
 import org.utbot.framework.codegen.model.tree.CgDeclaration
 import org.utbot.framework.codegen.model.tree.CgEnumConstantAccess
 import org.utbot.framework.codegen.model.tree.CgExecutableCall
@@ -22,18 +23,22 @@ import org.utbot.framework.codegen.model.tree.CgFieldAccess
 import org.utbot.framework.codegen.model.tree.CgGetJavaClass
 import org.utbot.framework.codegen.model.tree.CgLiteral
 import org.utbot.framework.codegen.model.tree.CgMethodCall
+import org.utbot.framework.codegen.model.tree.CgStatement
 import org.utbot.framework.codegen.model.tree.CgStaticFieldAccess
 import org.utbot.framework.codegen.model.tree.CgValue
 import org.utbot.framework.codegen.model.tree.CgVariable
 import org.utbot.framework.codegen.model.util.at
 import org.utbot.framework.codegen.model.util.canBeSetIn
+import org.utbot.framework.codegen.model.util.fieldThisIsGetterFor
+import org.utbot.framework.codegen.model.util.fieldThisIsSetterFor
 import org.utbot.framework.codegen.model.util.inc
 import org.utbot.framework.codegen.model.util.isAccessibleFrom
 import org.utbot.framework.codegen.model.util.lessThan
 import org.utbot.framework.codegen.model.util.nullLiteral
 import org.utbot.framework.codegen.model.util.resolve
 import org.utbot.framework.plugin.api.BuiltinClassId
 import org.utbot.framework.plugin.api.ClassId
+import org.utbot.framework.plugin.api.CodegenLanguage
 import org.utbot.framework.plugin.api.ConstructorId
 import org.utbot.framework.plugin.api.MethodId
 import org.utbot.framework.plugin.api.UtArrayModel
@@ -188,7 +193,7 @@ internal class CgVariableConstructor(val context: CgContext) :
             // byteBuffer is field of type ByteBuffer and upper line is incorrect
             val canFieldBeDirectlySetByVariableAndFieldTypeRestrictions =
                 fieldFromVariableSpecifiedType != null && fieldFromVariableSpecifiedType.type.id == variableForField.type
-            if (canFieldBeDirectlySetByVariableAndFieldTypeRestrictions && fieldId.canBeSetIn(testClassPackageName)) {
+            if (canFieldBeDirectlySetByVariableAndFieldTypeRestrictions && fieldId.canBeSetIn(context)) {
                 // TODO: check if it is correct to use declaringClass of a field here
                 val fieldAccess = if (field.isStatic) CgStaticFieldAccess(fieldId) else CgFieldAccess(obj, fieldId)
                 fieldAccess `=` variableForField
@@ -212,7 +217,8 @@ internal class CgVariableConstructor(val context: CgContext) :
                     instance[statementModel.fieldId] `=` declareOrGet(statementModel.fieldModel)
                 }
                 is UtExecutableCallModel -> {
-                    +createCgExecutableCallFromUtExecutableCall(statementModel)
+                    val call = createCgExecutableCallFromUtExecutableCall(statementModel)
+                    +replaceCgExecutableCallWithFieldAccessIfNeeded(call)
                 }
             }
         }
@@ -236,6 +242,7 @@ internal class CgVariableConstructor(val context: CgContext) :
         val initExpr = if (isPrimitiveWrapperOrString(type)) {
             cgLiteralForWrapper(params)
         } else {
+            // TODO: if instantiation chain could be a setter call, we need to replace it in Kotlin
             createCgExecutableCallFromUtExecutableCall(executableCall)
         }
         newVar(type, model, baseName) {
@@ -261,6 +268,23 @@ internal class CgVariableConstructor(val context: CgContext) :
         return cgCall
     }
 
+    private fun replaceCgExecutableCallWithFieldAccessIfNeeded(call: CgExecutableCall): CgStatement {
+        if (call !is CgMethodCall || context.codegenLanguage != CodegenLanguage.KOTLIN)
+            return call
+
+        val caller = call.caller ?: return call
+
+        caller.type.fieldThisIsSetterFor(call.executableId)?.let {
+            return CgAssignment(caller[it], call.arguments.single())
+        }
+        caller.type.fieldThisIsGetterFor(call.executableId)?.let {
+            require(call.arguments.isEmpty())
+            return caller[it]
+        }
+
+        return call
+    }
+
     /**
      * Makes a replacement of constructor call to instantiate a primitive wrapper
      * with direct setting of the value. The reason is that in Kotlin constructors

utbot-framework/src/main/kotlin/org/utbot/framework/codegen/model/util/ClassIdUtil.kt

@@ -1,6 +1,9 @@
 package org.utbot.framework.codegen.model.util
 
 import org.utbot.framework.plugin.api.ClassId
+import org.utbot.framework.plugin.api.FieldId
+import org.utbot.framework.plugin.api.MethodId
+import org.utbot.framework.plugin.api.util.allDeclaredFieldIds
 import org.utbot.framework.plugin.api.util.id
 import org.utbot.framework.plugin.api.util.isArray
 
@@ -28,4 +31,16 @@ infix fun ClassId.isAccessibleFrom(packageName: String): Boolean {
     } else {
         isPublic || (this.packageName == packageName && (isPackagePrivate || isProtected))
     }
-}
+}
+
+/**
+ * Returns field of [this], such that [methodId] is a getter for it (or null if methodId doesn't represent a getter)
+ */
+internal fun ClassId.fieldThisIsGetterFor(methodId: MethodId): FieldId? =
+    allDeclaredFieldIds.firstOrNull { it.getter == methodId }
+
+/**
+ * Returns field of [this], such that [methodId] is a setter for it (or null if methodId doesn't represent a setter)
+ */
+internal fun ClassId.fieldThisIsSetterFor(methodId: MethodId): FieldId? =
+    allDeclaredFieldIds.firstOrNull { it.setter == methodId }

utbot-framework/src/main/kotlin/org/utbot/framework/codegen/model/util/FieldIdUtil.kt

@@ -1,15 +1,25 @@
 package org.utbot.framework.codegen.model.util
 
+import org.utbot.framework.codegen.model.constructor.context.CgContext
+import org.utbot.framework.plugin.api.CodegenLanguage
 import org.utbot.framework.plugin.api.FieldId
+import org.utbot.framework.plugin.api.MethodId
+import org.utbot.framework.plugin.api.util.voidClassId
 
 /**
  * For now we will count field accessible if it is not private and its class is also accessible,
  * because we generate tests in the same package with the class under test,
  * which means we can access public, protected and package-private fields
  *
- * @param packageName name of the package we check accessibility from
+ * @param context context in which code is generated (it is needed because the method needs to know package and language)
  */
-infix fun FieldId.isAccessibleFrom(packageName: String): Boolean {
+// TODO: change parameter from packageName: String to context: CgContext in ClassId.isAccessibleFrom and ExecutableId.isAccessibleFrom ?
+internal infix fun FieldId.isAccessibleFrom(context: CgContext): Boolean {
+    if (context.codegenLanguage == CodegenLanguage.KOTLIN) {
+        // Here we call field accessible iff its getter is accessible, checks for setter are made in FieldId.canBeSetIn
+        return declaringClass.allMethods.contains(getter) && getter.isAccessibleFrom(context.testClassPackageName)
+    }
+    val packageName = context.testClassPackageName
     val isClassAccessible = declaringClass.isAccessibleFrom(packageName)
     val isAccessibleByVisibility = isPublic || (declaringClass.packageName == packageName && (isPackagePrivate || isProtected))
     val isAccessibleFromPackageByModifiers = isAccessibleByVisibility && !isSynthetic
@@ -20,4 +30,21 @@ infix fun FieldId.isAccessibleFrom(packageName: String): Boolean {
 /**
  * Whether or not a field can be set without reflection
  */
-fun FieldId.canBeSetIn(packageName: String): Boolean = isAccessibleFrom(packageName) && !isFinal
+internal fun FieldId.canBeSetIn(context: CgContext): Boolean {
+    if (context.codegenLanguage == CodegenLanguage.KOTLIN) {
+        return declaringClass.allMethods.contains(setter) && setter.isAccessibleFrom(context.testClassPackageName)
+    }
+    return isAccessibleFrom(context) && !isFinal
+}
+
+/**
+ * The default getter method for field (the one which is generated by Kotlin compiler)
+ */
+val FieldId.getter: MethodId
+    get() = MethodId(declaringClass, "get${name.replaceFirstChar { it.uppercase() } }", type, emptyList())
+
+/**
+ * The default setter method for field (the one which is generated by Kotlin compiler)
+ */
+val FieldId.setter: MethodId
+    get() = MethodId(declaringClass, "set${name.replaceFirstChar { it.uppercase() } }", voidClassId, listOf(type))