Merge avoidSpeculativeNotNullChecks and speculativelyCannotProduceNullPointerException into one method

Author: IlyaMuravjov

utbot-framework/src/main/kotlin/org/utbot/engine/Traverser.kt

@@ -2336,12 +2336,8 @@ class Traverser(
      * See more detailed documentation in [ApplicationContext] mentioned methods.
      */
     private fun checkAndMarkLibraryFieldSpeculativelyNotNull(field: SootField, createdField: SymbolicValue) {
-        if (applicationContext.avoidSpeculativeNotNullChecks(field) ||
-                !applicationContext.speculativelyCannotProduceNullPointerException(field, methodUnderTest.classId)) {
-            return
-        }
-
-        markAsSpeculativelyNotNull(createdField.addr)
+        if (applicationContext.speculativelyCannotProduceNullPointerException(field, methodUnderTest.classId))
+            markAsSpeculativelyNotNull(createdField.addr)
     }
 
     private fun createArray(pName: String, type: ArrayType): ArrayValue {

utbot-framework/src/main/kotlin/org/utbot/framework/context/ApplicationContext.kt

@@ -49,15 +49,6 @@ open class ApplicationContext(
      */
     open fun replaceTypeIfNeeded(type: RefType): ClassId? = null
 
-    /**
-     * Sets the restrictions on speculative not null
-     * constraints in current application context.
-     *
-     * @see docs/SpeculativeFieldNonNullability.md for more information.
-     */
-    open fun avoidSpeculativeNotNullChecks(field: SootField): Boolean =
-        UtSettings.maximizeCoverageUsingReflection || !field.declaringClass.isFromTrustedLibrary()
-
     /**
      * Checks whether accessing [field] (with a method invocation or field access) speculatively
      * cannot produce [NullPointerException] (according to its finality or accessibility).
@@ -67,7 +58,10 @@ open class ApplicationContext(
     open fun speculativelyCannotProduceNullPointerException(
         field: SootField,
         classUnderTest: ClassId,
-    ): Boolean = field.isFinal || !field.isPublic
+    ): Boolean =
+        !UtSettings.maximizeCoverageUsingReflection &&
+                field.declaringClass.isFromTrustedLibrary() &&
+                (field.isFinal || !field.isPublic)
 
     open fun preventsFurtherTestGeneration(): Boolean = false
 

utbot-framework/src/main/kotlin/org/utbot/framework/context/SpringApplicationContext.kt

@@ -123,8 +123,6 @@ class SpringApplicationContext(
             null
         }
 
-    override fun avoidSpeculativeNotNullChecks(field: SootField): Boolean = false
-
     /**
      * In Spring applications we can mark as speculatively not null
      * fields if they are mocked and injecting into class under test so on.