Improved tests, readability fixes and a corrected typo

Author: dtim

utbot-framework/src/main/kotlin/org/utbot/engine/ObjectWrappers.kt

@@ -88,7 +88,7 @@ val classToWrapper: MutableMap<TypeToBeWrapped, WrapperType> =
         putSootClass(java.util.stream.Stream::class, UT_STREAM.className)
         // TODO primitive streams https://github.com/UnitTestBot/UTBotJava/issues/146
 
-        putSootClass(java.lang.SecurityManager::class, utSecurityManagerClass)
+        putSootClass(java.lang.SecurityManager::class, UtSecurityManager::class)
     }
 
 /**

utbot-framework/src/main/kotlin/org/utbot/engine/SecurityManagerWrapper.kt

@@ -10,9 +10,6 @@ import soot.Scene
 import soot.SootClass
 import soot.SootMethod
 
-val utSecurityManagerClass: SootClass
-    get() = Scene.v().getSootClass(UtSecurityManager::class.qualifiedName)
-
 class SecurityManagerWrapper : BaseOverriddenWrapper(utSecurityManagerClass.name) {
     private val baseModelName: String = "securityManager"
 
@@ -34,4 +31,9 @@ class SecurityManagerWrapper : BaseOverriddenWrapper(utSecurityManagerClass.name
         val modificationChain = mutableListOf<UtStatementModel>()
         return UtAssembleModel(addr, classId, modelName, instantiationChain, modificationChain)
     }
+
+    companion object {
+        val utSecurityManagerClass: SootClass
+            get() = Scene.v().getSootClass(UtSecurityManager::class.qualifiedName)
+    }
 }

utbot-framework/src/test/kotlin/org/utbot/examples/exceptions/JvmCrashExamplesTest.kt

@@ -9,14 +9,7 @@ import org.utbot.examples.withoutSandbox
 import org.utbot.framework.codegen.CodeGeneration
 import org.utbot.framework.plugin.api.CodegenLanguage
 
-internal class JvmCrashExamplesTest : UtValueTestCaseChecker(
-    testClass = JvmCrashExamples::class,
-    testCodeGeneration = true,
-    languagePipelines = listOf(
-        CodeGenerationLanguageLastStage(CodegenLanguage.JAVA),
-        CodeGenerationLanguageLastStage(CodegenLanguage.KOTLIN, CodeGeneration)
-    )
-) {
+internal class JvmCrashExamplesTest : UtValueTestCaseChecker(testClass = JvmCrashExamples::class) {
     @Test
     @Disabled("JIRA:1527")
     fun testExit() {
@@ -32,6 +25,7 @@ internal class JvmCrashExamplesTest : UtValueTestCaseChecker(
             check(
                 JvmCrashExamples::crash,
                 eq(1), // we expect only one execution after minimization
+                // It seems that we can't calculate coverage when the child JVM has crashed
                 coverage = DoNotCalculate
             )
         }
@@ -42,6 +36,7 @@ internal class JvmCrashExamplesTest : UtValueTestCaseChecker(
         check(
             JvmCrashExamples::crashPrivileged,
             eq(1), // we expect only one execution after minimization
+            // It seems that we can't calculate coverage when the child JVM has crashed
             coverage = DoNotCalculate
         )
     }

utbot-framework/src/test/kotlin/org/utbot/examples/unsafe/UnsafeOperationsTest.kt

@@ -9,22 +9,17 @@ import org.utbot.framework.codegen.CodeGeneration
 import org.utbot.framework.plugin.api.CodegenLanguage
 import org.utbot.framework.plugin.api.MockStrategyApi
 
-internal class UnsafeOperationsTest : UtValueTestCaseChecker(
-    testClass = UnsafeOperations::class,
-    testCodeGeneration = true,
-    languagePipelines = listOf(
-        CodeGenerationLanguageLastStage(CodegenLanguage.JAVA),
-        CodeGenerationLanguageLastStage(CodegenLanguage.KOTLIN, CodeGeneration)
-    )
-) {
+internal class UnsafeOperationsTest : UtValueTestCaseChecker(testClass = UnsafeOperations::class) {
     @Test
     fun checkGetAddressSizeOrZero() {
         withoutSandbox {
             check(
                 UnsafeOperations::getAddressSizeOrZero,
                 eq(1),
-                { r -> r == 8 },
-                coverage = DoNotCalculate
+                { r -> r!! > 0 },
+                // Coverage matcher fails (branches: 0/0, instructions: 15/21, lines: 0/0)
+                // TODO: check coverage calculation
+                // coverage = DoNotCalculate
             )
         }
     }
@@ -35,8 +30,10 @@ internal class UnsafeOperationsTest : UtValueTestCaseChecker(
             check(
                 UnsafeOperations::getAddressSizeOrZero,
                 eq(1),
-                { r -> r == 8 },
-                coverage = DoNotCalculate,
+                { r -> r!! > 0 },
+                // Coverage matcher fails (branches: 0/0, instructions: 15/21, lines: 0/0)
+                // TODO: check coverage calculation
+                // coverage = DoNotCalculate,
                 mockStrategy = MockStrategyApi.OTHER_CLASSES
             )
         }

utbot-instrumentation/src/main/kotlin/org/utbot/instrumentation/process/ChildProcess.kt

@@ -49,7 +49,7 @@ private fun log(any: Any?) {
 private val kryoHelper: KryoHelper = KryoHelper(System.`in`, System.`out`)
 
 /**
- * Command-line option do disable the sandbox
+ * Command-line option to disable the sandbox
  */
 const val DISABLE_SANDBOX_OPTION = "--disable-sandbox"