Skip to content

Commit 417e5d5

Browse files
committed
Fix a bug with param names
1 parent 32c4e95 commit 417e5d5

File tree

3 files changed

+13
-18
lines changed

3 files changed

+13
-18
lines changed

utbot-framework/src/main/kotlin/org/utbot/framework/codegen/model/CodeGenerator.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ import org.utbot.framework.plugin.api.util.id
2121

2222
class CodeGenerator(
2323
private val classUnderTest: Class<*>,
24-
params: MutableMap<ExecutableId, List<String>> = mutableMapOf(),
24+
paramNames: MutableMap<ExecutableId, List<String>> = mutableMapOf(),
2525
testFramework: TestFramework = TestFramework.defaultItem,
2626
mockFramework: MockFramework? = MockFramework.defaultItem,
2727
staticsMocking: StaticsMocking = StaticsMocking.defaultItem,
@@ -36,7 +36,7 @@ class CodeGenerator(
3636
) {
3737
private var context: CgContext = CgContext(
3838
classUnderTest = classUnderTest.id,
39-
paramNames = params,
39+
paramNames = paramNames,
4040
testFramework = testFramework,
4141
mockFramework = mockFramework ?: MockFramework.MOCKITO,
4242
codegenLanguage = codegenLanguage,

utbot-framework/src/test/kotlin/org/utbot/framework/codegen/TestCodeGeneratorPipeline.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import org.utbot.common.bracket
77
import org.utbot.common.info
88
import org.utbot.common.packageName
99
import org.utbot.examples.TestFrameworkConfiguration
10-
import org.utbot.examples.conflictTriggers
1110
import org.utbot.framework.codegen.ExecutionStatus.SUCCESS
1211
import org.utbot.framework.codegen.model.CodeGenerator
1312
import org.utbot.framework.plugin.api.CodegenLanguage
@@ -222,7 +221,7 @@ class TestCodeGeneratorPipeline(private val testFrameworkConfiguration: TestFram
222221
val codeGenerator = with(testFrameworkConfiguration) {
223222
CodeGenerator(
224223
classUnderTest.java,
225-
params = params,
224+
paramNames = params,
226225
testFramework = testFramework,
227226
staticsMocking = staticsMocking,
228227
forceStaticMocking = forceStaticMocking,

utbot-intellij/src/main/kotlin/org/utbot/intellij/plugin/generator/CodeGenerationController.kt

Lines changed: 10 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ object CodeGenerationController {
101101
val file = testClass.containingFile
102102
runWriteCommandAction(model.project, "Generate tests with UtBot", null, {
103103
try {
104-
generateCodeAndReport(testClass, file, testSets, model, latch, reports)
104+
generateCodeAndReport(srcClass, testClass, file, testSets, model, latch, reports)
105105
} catch (e: IncorrectOperationException) {
106106
showCreatingClassError(model.project, createTestClassName(srcClass))
107107
}
@@ -251,31 +251,27 @@ object CodeGenerationController {
251251
}
252252

253253
private fun generateCodeAndReport(
254+
srcClass: PsiClass,
254255
testClass: PsiClass,
255256
file: PsiFile,
256257
testSets: List<UtMethodTestSet>,
257258
model: GenerateTestsModel,
258259
reportsCountDown: CountDownLatch,
259260
reports: MutableList<TestsGenerationReport>,
260261
) {
261-
val selectedMethods = TestIntegrationUtils.extractClassMethods(testClass, false)
262-
val testFramework = model.testFramework
263-
val mockito = model.mockFramework
264-
val staticsMocking = model.staticsMocking
265-
266262
val classUnderTest = testSets.first().method.clazz
267-
268-
val params = DumbService.getInstance(model.project)
269-
.runReadActionInSmartMode(Computable { findMethodParams(classUnderTest, selectedMethods) })
263+
val classMethods = TestIntegrationUtils.extractClassMethods(srcClass, false)
264+
val paramNames = DumbService.getInstance(model.project)
265+
.runReadActionInSmartMode(Computable { findMethodParamNames(classUnderTest, classMethods) })
270266

271267
val codeGenerator = CodeGenerator(
272268
classUnderTest = classUnderTest.java,
273-
params = params.toMutableMap(),
274-
testFramework = testFramework,
275-
mockFramework = mockito,
269+
paramNames = paramNames.toMutableMap(),
270+
testFramework = model.testFramework,
271+
mockFramework = model.mockFramework,
276272
codegenLanguage = model.codegenLanguage,
277273
parameterizedTestSource = model.parametrizedTestSource,
278-
staticsMocking = staticsMocking,
274+
staticsMocking = model.staticsMocking,
279275
forceStaticMocking = model.forceStaticMocking,
280276
generateWarningsForStaticMocking = model.generateWarningsForStaticMocking,
281277
runtimeExceptionTestsBehaviour = model.runtimeExceptionTestsBehaviour,
@@ -348,7 +344,7 @@ object CodeGenerationController {
348344
}
349345
}
350346

351-
private fun findMethodParams(clazz: KClass<*>, methods: List<MemberInfo>): Map<ExecutableId, List<String>> {
347+
private fun findMethodParamNames(clazz: KClass<*>, methods: List<MemberInfo>): Map<ExecutableId, List<String>> {
352348
val bySignature = methods.associate { it.signature() to it.paramNames() }
353349
return clazz.functions
354350
.mapNotNull { method -> bySignature[method.signature()]?.let { params -> method.executableId to params } }

0 commit comments

Comments
 (0)