Skip to content

Commit 24fe475

Browse files
authored
Inconsistent DisplayName is generated for a Collection used as the only parameter #684 (#840)
1 parent 439a0d8 commit 24fe475

File tree

1 file changed

+11
-3
lines changed

1 file changed

+11
-3
lines changed

utbot-summary/src/main/kotlin/org/utbot/summary/fuzzer/names/ModelBasedNameSuggester.kt

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ import org.utbot.framework.plugin.api.exceptionOrNull
1111
import org.utbot.framework.plugin.api.util.voidClassId
1212
import org.utbot.fuzzer.FuzzedMethodDescription
1313
import org.utbot.fuzzer.FuzzedValue
14+
import java.util.*
1415

1516
class ModelBasedNameSuggester(
1617
private val suggester: List<SingleModelNameSuggester> = listOf(
@@ -52,7 +53,8 @@ class ModelBasedNameSuggester(
5253
is UtExecutionSuccess -> (result.model as? UtPrimitiveModel)?.value?.let { v ->
5354
when (v) {
5455
is Number -> prettifyNumber(v)
55-
is Boolean -> v.toString().capitalize()
56+
is Boolean -> v.toString()
57+
.replaceFirstChar { if (it.isLowerCase()) it.titlecase(Locale.getDefault()) else it.toString() }
5658
else -> null
5759
}?.let { "Returns$it" }
5860
}
@@ -78,7 +80,8 @@ class ModelBasedNameSuggester(
7880

7981
return buildString {
8082
append("test")
81-
append(description.compilableName?.capitalize() ?: "Method")
83+
append(description.compilableName?.replaceFirstChar { if (it.isLowerCase()) it.titlecase(Locale.getDefault()) else it.toString() }
84+
?: "Method")
8285
append(returnString)
8386
if (parameters.isNotEmpty()) {
8487
append("With", parameters)
@@ -101,7 +104,12 @@ class ModelBasedNameSuggester(
101104
.filterNotNull()
102105
.toList()
103106

104-
val parameters = summaries.joinToString(postfix = if (summaries.size < values.size) " and others" else "")
107+
val postfix = when {
108+
summaries.isEmpty() && values.isNotEmpty() -> "with generated values"
109+
summaries.size < values.size -> " and others"
110+
else -> ""
111+
}
112+
val parameters = summaries.joinToString(postfix = postfix)
105113

106114
val returnValue = when(result) {
107115
is UtExecutionSuccess -> result.model.let { m ->

0 commit comments

Comments
 (0)