Constant evaluation of implode()

dstogov · dstogov · commit 9e36a748b288 · 2017-07-10T11:13:37.000+03:00
diff --git a/ext/opcache/Optimizer/sccp.c b/ext/opcache/Optimizer/sccp.c
@@ -573,6 +573,12 @@ static inline int ct_eval_func_call(
 					return FAILURE;
 				}
 			}
+			/* pass */
+		} else if (zend_string_equals_literal(name, "implode")
+				&& ((num_args == 1 && Z_TYPE_P(args[0]) == IS_ARRAY)
+					|| (num_args == 2 && Z_TYPE_P(args[0]) == IS_STRING && Z_TYPE_P(args[1]) == IS_ARRAY)
+					|| (num_args == 2 && Z_TYPE_P(args[0]) == IS_ARRAY && Z_TYPE_P(args[1]) == IS_STRING))) {
+			/* pass */
 		} else {
 #if 0
 			fprintf(stderr, "constant ICALL to %s()\n", ZSTR_VAL(name));

Original file line number	Diff line number	Diff line change
`@@ -573,6 +573,12 @@ static inline int ct_eval_func_call(`
`573`	`573`	`return FAILURE;`
`574`	`574`	`}`
`575`	`575`	`}`
	`576`	`+ /* pass */`
	`577`	`+ } else if (zend_string_equals_literal(name, "implode")`
	`578`	`+ && ((num_args == 1 && Z_TYPE_P(args[0]) == IS_ARRAY)`
	`579`	`+ \|\| (num_args == 2 && Z_TYPE_P(args[0]) == IS_STRING && Z_TYPE_P(args[1]) == IS_ARRAY)`
	`580`	`+ \|\| (num_args == 2 && Z_TYPE_P(args[0]) == IS_ARRAY && Z_TYPE_P(args[1]) == IS_STRING))) {`
	`581`	`+ /* pass */`
`576`	`582`	`} else {`
`577`	`583`	`#if 0`
`578`	`584`	`fprintf(stderr, "constant ICALL to %s()\n", ZSTR_VAL(name));`