Skip to content

Commit 942f341

Browse files
committed
Document zend_hash_sort and zend_ts_hash_sort signature change
Cf. <php#3936>.
1 parent 915abeb commit 942f341

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

UPGRADING.INTERNALS

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ PHP 8.0 INTERNALS UPGRADE NOTES
1414
k. The 'I' length modifier
1515
l. Some VM instructions switched to IS_TMP_VAR result instead of IS_VAR
1616
m. All internal functions must have arginfo
17-
n. zend_hash_sort compare function signature change
17+
n. zend_hash_sort and zend_hash_sort compare function signature change
1818
o. cast_object() object handler is now required
1919
p. ARG_COUNT() macro removed
2020
q. GC_COLLECTABLE flag
@@ -113,6 +113,8 @@ PHP 8.0 INTERNALS UPGRADE NOTES
113113
typedef int (*bucket_compare_func_t)(Bucket *a, Bucket *b);
114114

115115
Previously compare_func_t was used, which accepted void pointers.
116+
Furthermore, the return type of zend_hash_sort and zend_ts_hash_sort has
117+
been changed from int to void; these functions always succeed.
116118

117119
o. The cast_object() handler is now required, i.e. must be non-null. You can
118120
indicate that casting is not supported by always returning FAILURE.

0 commit comments

Comments
 (0)