Skip to content

Commit d349280

Browse files
committed
ReflectionSymbolId.pos uses getStart for position
1 parent 40d1cec commit d349280

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,16 +4,20 @@
44

55
- Updated Chinese translations, #2706.
66
- Exported constants no longer render the type and default value if they are the same, #2717.
7+
- The HTML output now wraps tag blocks with `<div>` tags and includes the tag name in a class name, #2723.
78

89
### Bug Fixes
910

1011
- Correctly handle external link resolver link text when referencing an external symbol, #2700.
1112
- Big integer literals are now supported as default values, #2721.
1213
- Corrected handling of `@link` tags present in comments at the start of source files.
14+
- `ReflectionSymbolId.pos` no longer references the position _before_ any doc comments for a symbol.
15+
This could cause typedoc-plugin-dt-links to produce links which didn't go to the expected location in a file.
1316

1417
### Thanks!
1518

1619
- @Corso02
20+
- @lriggle-strib
1721
- @XeroAlpha
1822

1923
## v0.26.7 (2024-09-09)

src/lib/models/reflections/ReflectionSymbolId.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ export class ReflectionSymbolId {
6161
} else {
6262
this.qualifiedName = getQualifiedName(symbol, symbol.name);
6363
}
64-
this.pos = declaration?.pos ?? Infinity;
64+
this.pos = declaration?.getStart() ?? Infinity;
6565
if (symbol.flags & ts.SymbolFlags.Transient) {
6666
this.transientId = transientIds.get(symbol) ?? ++transientCount;
6767
transientIds.set(symbol, this.transientId);

0 commit comments

Comments
 (0)