Fix missing this parameters

Resolves #1875

Author: Gerrit0

CHANGELOG.md

@@ -8,6 +8,7 @@
 ### Bug Fixes
 
 -   Fixed validation for `--requiredToBeDocumented` option, #1872.
+-   Fixed missing `this` parameters in documentation for some functions, #1875.
 
 ## v0.22.12 (2022-02-20)
 

src/lib/converter/factories/signature.ts

@@ -58,10 +58,15 @@ export function createSignature(
         signature.typeParameters
     );
 
+    const parameterSymbols: ReadonlyArray<ts.Symbol & { type?: ts.Type }> =
+        signature.thisParameter
+            ? [signature.thisParameter, ...signature.parameters]
+            : signature.parameters;
+
     sigRef.parameters = convertParameters(
         context,
         sigRef,
-        signature.parameters as readonly (ts.Symbol & { type: ts.Type })[],
+        parameterSymbols,
         declaration?.parameters
     );
 
@@ -105,7 +110,7 @@ export function createSignature(
 function convertParameters(
     context: Context,
     sigRef: SignatureReflection,
-    parameters: readonly (ts.Symbol & { type: ts.Type })[],
+    parameters: ReadonlyArray<ts.Symbol & { type?: ts.Type }>,
     parameterNodes: readonly ts.ParameterDeclaration[] | undefined
 ) {
     return parameters.map((param, i) => {
@@ -129,7 +134,7 @@ function convertParameters(
             declaration
         );
 
-        let type: ts.Type | ts.TypeNode;
+        let type: ts.Type | ts.TypeNode | undefined;
         if (declaration) {
             type = context.checker.getTypeOfSymbolAtLocation(
                 param,

src/lib/types/ts-internal/index.d.ts

@@ -22,6 +22,10 @@ declare module "typescript" {
         ): ts.TypePredicate | undefined;
     }
 
+    export interface Signature {
+        thisParameter?: ts.Symbol;
+    }
+
     // https://github.com/microsoft/TypeScript/blob/e213b2af3430bdc9cf5fbc76a8634d832e7aaaaa/src/compiler/types.ts#L5298-L5299
     export interface UnionType {
         /* @internal */

src/test/converter2/issues/gh1875.ts

@@ -0,0 +1,3 @@
+export declare function test(this: typeof globalThis, param: string): string;
+
+export declare function test2(this, param: string): string;

src/test/converter2/tsconfig.json

@@ -6,6 +6,8 @@
         "outDir": "dist",
         "target": "ESNext",
 
+        "noImplicitAny": false,
+
         // See #1524. We might force this to false eventually.
         "skipLibCheck": true
     },

src/test/issueTests.ts

@@ -292,6 +292,20 @@ export const issueTests: {
         ok(project.children![1].kind !== ReflectionKind.Reference);
     },
 
+    gh1875(project) {
+        const test = query(project, "test");
+        equal(
+            test.signatures?.[0].parameters?.map((p) => p.type?.toString()),
+            ["typeof globalThis", "string"]
+        );
+
+        const test2 = query(project, "test2");
+        equal(
+            test2.signatures?.[0].parameters?.map((p) => p.type?.toString()),
+            ["any", "string"]
+        );
+    },
+
     gh1876(project) {
         const foo = query(project, "foo");
         const fooSig = foo.signatures?.[0].parameters?.[0];