random: Initialize the mode field when seeding in php_random_default_status() (php#13608)

TimWolla · web-flow · commit bf0abd162929 · 2024-03-06T18:57:17.000+01:00
This is a follow-up fix for phpGH-13579. The issue was detected in the nightly MSAN build.
diff --git a/ext/random/random.c b/ext/random/random.c
@@ -312,6 +312,7 @@ PHPAPI void *php_random_default_status(void)
 	php_random_status_state_mt19937 *state = &RANDOM_G(mt19937);
 
 	if (!RANDOM_G(mt19937_seeded)) {
+		state->mode = MT_RAND_MT19937;
 		php_random_mt19937_seed_default(state);
 		RANDOM_G(mt19937_seeded) = true;
 	}

Original file line number	Diff line number	Diff line change
`@@ -312,6 +312,7 @@ PHPAPI void *php_random_default_status(void)`
`312`	`312`	`php_random_status_state_mt19937 *state = &RANDOM_G(mt19937);`
`313`	`313`
`314`	`314`	`if (!RANDOM_G(mt19937_seeded)) {`
	`315`	`+ state->mode = MT_RAND_MT19937;`
`315`	`316`	`php_random_mt19937_seed_default(state);`
`316`	`317`	`RANDOM_G(mt19937_seeded) = true;`
`317`	`318`	`}`