Skip to content

Commit bf157bd

Browse files
committed
[TASK] Explicitly provide all fgetcsv() arguments
With [1] the 5th parameter `$escape` of `fgetcsv()` must be provided either positional or using named arguments or a E_DEPRECATED will be emitted since `PHP 8.4.0 RC1` [2]. This change provide now all five parameter for `fgetcsv()` calls and thus using the positional approach to allow easier backporting to older TYPO3 version where named arguements are not usable. [1] php/php-src#15569 [2] https://github.com/php/php-src/blob/ebee8df27ed/UPGRADING#L617-L622 Releases: main, 8, 7
1 parent d317133 commit bf157bd

File tree

1 file changed

+1
-1
lines changed
  • Classes/Core/Functional/Framework/DataHandling

1 file changed

+1
-1
lines changed

Classes/Core/Functional/Framework/DataHandling/DataSet.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ private static function readData(string $fileName): array
186186
// BOM not found - rewind pointer to start of file.
187187
rewind($fileHandle);
188188
}
189-
while (!feof($fileHandle) && ($values = fgetcsv($fileHandle, 0)) !== false) {
189+
while (!feof($fileHandle) && ($values = fgetcsv($fileHandle, 0, ',', '"', '\\')) !== false) {
190190
$rawData[] = $values;
191191
}
192192
fclose($fileHandle);

0 commit comments

Comments
 (0)