Skip to content

Commit ba44320

Browse files
committed
align with upstream, make Dates dep explicit
1 parent ef2d0d8 commit ba44320

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

ext/DynamicQuantitiesMakieExt.jl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ end
2222

2323
function unit_convert(quantity::UnionAbstractQuantity, value)
2424
conv = ustrip(quantity, value)
25-
return Float64(conv)
25+
return float(conv)
2626
end
2727

2828
"""
@@ -55,7 +55,7 @@ scatter(1:4, [0.01u"km", 0.02u"km", 0.03u"km", 0.04u"km"]; axis=(dim2_conversion
5555
```
5656
"""
5757
struct DQConversion <: M.AbstractDimConversion
58-
quantity::M.Observable{UnionAbstractQuantity{T1, SymbolicDimensions{T2}} where {T1 <: Real, T2 <: Real}}
58+
quantity::M.Observable{Any}
5959
automatic_units::Bool
6060
units_in_label::M.Observable{Bool}
6161
end
@@ -99,7 +99,7 @@ function M.convert_dim_value(conversion::DQConversion, values)
9999
end
100100

101101
@testitem "1 arg expansion" begin
102-
using DynamicQuantities, Makie, Dates
102+
using DynamicQuantities, Makie
103103

104104
f, ax, pl = scatter(u"m" .* (1:10))
105105
@test pl isa Scatter{Tuple{Vector{Point2{Float64}}}}

test/Project.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
[deps]
22
Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
3+
Dates = "ade2ca70-3891-5945-98fb-dc099432e06a"
34
DispatchDoctor = "8d63f2c5-f18a-4cf2-ba9d-b3f60fc568c8"
45
LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
56
Makie = "ee78f7c6-11fb-53f2-987a-cfe4a2b5a57a"

0 commit comments

Comments
 (0)